Skip to content

Commit

Permalink
Merge pull request #324 from DHI/xarray-for-skill-class2
Browse files Browse the repository at this point in the history
Further improvements to SkillTable and SkillArray
  • Loading branch information
ecomodeller authored Dec 13, 2023
2 parents 30736b8 + 294684a commit 19d9990
Show file tree
Hide file tree
Showing 4 changed files with 203 additions and 169 deletions.
4 changes: 2 additions & 2 deletions modelskill/comparison/_collection.py
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,7 @@ def score(
if skill is None:
return None

df = skill.df
df = skill.to_dataframe()

if n_models == 1:
score = df[metric.__name__].values.mean()
Expand Down Expand Up @@ -1070,7 +1070,7 @@ def taylor(
skill_func = cmp.mean_skill if aggregate_observations else cmp.skill
s = skill_func(metrics=metrics)

df = s.df
df = s.to_dataframe()
ref_std = 1.0 if normalize_std else df.iloc[0]["_std_obs"]

if isinstance(df.index, pd.MultiIndex):
Expand Down
Loading

0 comments on commit 19d9990

Please sign in to comment.