Additional icons for new statuses & Change Password Requirement for IEC Security #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finz-Azmi
reviewed
Aug 19, 2024
Comment on lines
132
to
147
| const handleError = (error, action) => { | ||
| try { | ||
| if (error instanceof Error) { | ||
| const errorMessage = error.message; | ||
|
|
||
| const parsedError = JSON.parse(errorMessage); | ||
| const firstErrorMessage = parsedError.errors[0]?.description; | ||
| setErrorMessage(firstErrorMessage); | ||
| } else { | ||
| console.log(`${action}: Received non-Error object:`, error); | ||
| } | ||
| } catch (e) { | ||
| console.log(`${action}: Failed to parse error response.`, e); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
why create a function inside a function? it seems better to split the functionality
Comment on lines
130
to
141
| if (isNew) { | ||
| commitAddedRows({ rowIds }); | ||
| onSave(editedRow, isNew); | ||
| } else { | ||
| onSave(editedRow); | ||
| if (errorMessage !== '') { | ||
| onSave(editedRow); | ||
| stopEditRows({ rowIds }); | ||
| commitChangedRows({ rowIds }); | ||
| } else { | ||
| onSave(editedRow); | ||
| } |
There was a problem hiding this comment.
you dont need to call onSave three times. just put onSave in the last line.
Finz-Azmi
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dhigroup.visualstudio.com/Domain%20Services%20Planning/_workitems/edit/97241
https://dhigroup.visualstudio.com/Domain%20Services%20Planning/_workitems/edit/96620/