Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included source .proto files from ISIS, regenerated _pb2 files with p… #211

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

jrcain-usgs
Copy link
Contributor

@jrcain-usgs jrcain-usgs commented Nov 7, 2024

included source .proto files from ISIS, regenerated _pb2 files with proton

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Fixes #210

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Nov 7, 2024

we can probably ignore 3.8, probably safe to remove 3.8 tests altogether.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Nov 7, 2024

Add changelog entry and reference the issue this addresses. I imagine the existing io_controlnetork tests would catch any protobuf failures due to using latest version

@jrcain-usgs
Copy link
Contributor Author

we can probably ignore 3.8, probably save to remove 3.8 tests altogether.

Removed 3.8 and added 3.12, think I should worry about python 3.13?

CHANGELOG.md Outdated Show resolved Hide resolved
@Kelvinrr Kelvinrr merged commit 2fc704b into DOI-USGS:main Nov 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong libprotobuf Version Dependency?
2 participants