Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #41 scroll to get next page data #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 29 additions & 95 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -1,100 +1,34 @@
name: CI

on:
push:
branches: [feat_*, dev]
pull_request:
branches: [master, dev]
push:
branches: "master"
pull_request:
branches: "*"

jobs:
setup:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2

- name: 'Set pnpm'
uses: pnpm/[email protected]
with:
version: 6.32.20

- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 14.x
cache: pnpm

- name: Cache pnpm-lock.yaml
uses: actions/cache@v2
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: Hack for single file
run: |
if [ ! -d "package-temp-dir" ]; then
mkdir package-temp-dir
fi
cp pnpm-lock.yaml package-temp-dir
- name: Cache node_modules
id: node_modules_cache_id
uses: actions/cache@v2
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-temp-dir/pnpm-lock.yaml') }}

- name: Install dependencies
if: steps.node_modules_cache_id.outputs.cache-hit != 'true'
run: pnpm install

lint:
needs: [setup]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: 'Set pnpm'
uses: pnpm/[email protected]
with:
version: 6.32.20

- name: Restore cache from pnpm-lock.yaml
uses: actions/cache@v2
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: Restore cache from node_modules
uses: actions/cache@v2
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-temp-dir/pnpm-lock.yaml') }}

- name: Run lint
run: pnpm run lint

build:
runs-on: ubuntu-latest
needs: [setup, lint]
steps:
- uses: actions/checkout@v2

- name: 'Set pnpm'
uses: pnpm/[email protected]
with:
version: 6.32.20

- name: Restore cache from pnpm-lock.yaml
uses: actions/cache@v2
with:
path: package-temp-dir
key: lock-${{ github.sha }}

- name: Restore cache from node_modules
uses: actions/cache@v2
with:
path: node_modules
key: node_modules-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-temp-dir/pnpm-lock.yaml') }}

- name: Build test
run: pnpm run build
setup:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2

- name: "Set pnpm"
uses: pnpm/[email protected]
with:
version: 6.32.20

- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 14.x
cache: pnpm

- name: Install dependencies
run: pnpm install

- name: Run lint
run: pnpm run lint

- name: Build test
run: pnpm run build
2 changes: 1 addition & 1 deletion src/pages/article/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const Article = (data) => {
// 内容高度,180 是移动端顶部内容,318 是移动端名称图片内容,80 是 PC 端顶部内容,226 是 PC 端名称图片内容
const contentHeight = mobile ? (document.getElementById('articleContent')?.offsetHeight + 180 + 318) : (document.getElementById('articleContent')?.offsetHeight + 80 + 226)

if (hasMore && (scrollTop + windowHeight >= contentHeight)) {
if (hasMore && (scrollTop + windowHeight + 5 >= contentHeight)) {
console.log('下一页')
handleNext()
}
Expand Down