Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump FluentAssertions and add analyzers #5087

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump FluentAssertions and add analyzers #5087

wants to merge 2 commits into from

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Jan 19, 2024 •
edited
Loading

Summary of changes

  • Update fluent assertions library from 6.4.0 => 7.0.0
  • Add FluentAssertions.Analyzers for best practices

Reason for change

I hate seeing Assert.Equals() in the logs and trying to work out what it was referring to 😅

Implementation details

Bump some versions

Test coverage

Pretty well covered

Other details

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Jan 19, 2024
@andrewlock andrewlock requested review from a team as code owners January 19, 2024 10:50
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 19, 2024 •
edited
Loading

Datadog Report

Branch report: adnrew/ci/bump-fluent-assertion
Commit report: b6d5a42
Test service: dd-trace-dotnet

✅ 0 Failed, 306714 Passed, 1508 Skipped, 1h 0m 18.53s Wall Time

@andrewlock
Copy link
Member Author

andrewlock commented Jan 19, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5087) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (5087) - mean (979ms)  : 956, 1002
     .   : milestone, 979,
    master - mean (979ms)  : 957, 1000
     .   : milestone, 979,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5087) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5087) - mean (679ms)  : 662, 696
     .   : milestone, 679,
    master - mean (682ms)  : 668, 696
     .   : milestone, 682,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5087) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (5087) - mean (634ms)  : 617, 650
     .   : milestone, 634,
    master - mean (639ms)  : 625, 654
     .   : milestone, 639,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5087) - mean (195ms)  : 191, 199
     .   : milestone, 195,
    master - mean (195ms)  : 190, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (5087) - mean (1,106ms)  : 1084, 1128
     .   : milestone, 1106,
    master - mean (1,099ms)  : 1062, 1136
     .   : milestone, 1099,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5087) - mean (280ms)  : 273, 286
     .   : milestone, 280,
    master - mean (278ms)  : 274, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (5087) - mean (874ms)  : 851, 897
     .   : milestone, 874,
    master - mean (869ms)  : 838, 899
     .   : milestone, 869,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5087) - mean (268ms)  : 263, 272
     .   : milestone, 268,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5087) - mean (849ms)  : 809, 888
     .   : milestone, 849,
    master - mean (845ms)  : 814, 877
     .   : milestone, 845,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #5087 compared to master:

  • 4 benchmarks are faster, with geometric mean 1.166
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.88μs 49.3ns 304ns 0.0188 0.00938 0 7.49 KB
master StartStopWithChild netcoreapp3.1 10.9μs 58.7ns 316ns 0.0276 0.011 0 7.57 KB
master StartStopWithChild net472 17μs 73.4ns 284ns 1.34 0.341 0.119 7.95 KB
#5087 StartStopWithChild net6.0 8.61μs 32.1ns 111ns 0.034 0.017 0 7.48 KB
#5087 StartStopWithChild netcoreapp3.1 11μs 61.3ns 383ns 0.023 0.0115 0 7.58 KB
#5087 StartStopWithChild net472 17.4μs 47.4ns 171ns 1.34 0.37 0.112 7.96 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 455μs 196ns 735ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 623μs 170ns 657ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 816μs 520ns 1.95μs 0.408 0 0 3.3 KB
#5087 WriteAndFlushEnrichedTraces net6.0 453μs 156ns 583ns 0 0 0 2.7 KB
#5087 WriteAndFlushEnrichedTraces netcoreapp3.1 634μs 263ns 1.02μs 0 0 0 2.7 KB
#5087 WriteAndFlushEnrichedTraces net472 801μs 462ns 1.79μs 0.401 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.6μs 14.7ns 51ns 0.0193 0 0 1.77 KB
master AllCycleSimpleBody netcoreapp3.1 42.3μs 79.4ns 308ns 0.0208 0 0 1.74 KB
master AllCycleSimpleBody net472 44.7μs 71.4ns 258ns 0.288 0 0 1.81 KB
master AllCycleMoreComplexBody net6.0 198μs 110ns 427ns 0.0989 0 0 9.25 KB
master AllCycleMoreComplexBody netcoreapp3.1 211μs 125ns 483ns 0.106 0 0 9.14 KB
master AllCycleMoreComplexBody net472 224μs 77ns 288ns 1.45 0 0 9.32 KB
master ObjectExtractorSimpleBody net6.0 145ns 0.0748ns 0.259ns 0.00397 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 242ns 0.132ns 0.513ns 0.00378 0 0 272 B
master ObjectExtractorSimpleBody net472 166ns 0.163ns 0.609ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.94μs 2.4ns 8.99ns 0.0529 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.98μs 1.28ns 4.61ns 0.0498 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.81μs 4.32ns 16.2ns 0.602 0.00571 0 3.8 KB
#5087 AllCycleSimpleBody net6.0 39.2μs 37.5ns 145ns 0.0198 0 0 1.77 KB
#5087 AllCycleSimpleBody netcoreapp3.1 41.9μs 114ns 440ns 0.0206 0 0 1.74 KB
#5087 AllCycleSimpleBody net472 44.8μs 11.9ns 41.1ns 0.268 0 0 1.81 KB
#5087 AllCycleMoreComplexBody net6.0 200μs 196ns 760ns 0.0995 0 0 9.25 KB
#5087 AllCycleMoreComplexBody netcoreapp3.1 211μs 258ns 998ns 0.106 0 0 9.14 KB
#5087 AllCycleMoreComplexBody net472 227μs 149ns 579ns 1.47 0 0 9.32 KB
#5087 ObjectExtractorSimpleBody net6.0 136ns 0.123ns 0.459ns 0.00391 0 0 280 B
#5087 ObjectExtractorSimpleBody netcoreapp3.1 235ns 0.119ns 0.446ns 0.00367 0 0 272 B
#5087 ObjectExtractorSimpleBody net472 176ns 0.122ns 0.474ns 0.0446 0 0 281 B
#5087 ObjectExtractorMoreComplexBody net6.0 2.96μs 2.13ns 7.97ns 0.0534 0 0 3.78 KB
#5087 ObjectExtractorMoreComplexBody netcoreapp3.1 4μs 1.62ns 6.29ns 0.0499 0 0 3.69 KB
#5087 ObjectExtractorMoreComplexBody net472 3.77μs 1.77ns 6.87ns 0.603 0.00563 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 50.8μs 21ns 78.4ns 0.226 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 70.1μs 179ns 692ns 0.206 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) net472 98.2μs 495ns 2.16μs 2.55 0.1 0 16.14 KB
master RunWafTwice(args=NestedMap (10)) net6.0 52.3μs 22.4ns 83.9ns 0.236 0 0 16.6 KB
master RunWafTwice(args=NestedMap (10)) netcoreapp3.1 75μs 385ns 1.72μs 0.19 0 0 16.58 KB
master RunWafTwice(args=NestedMap (10)) net472 104μs 49.8ns 193ns 2.62 0.105 0 16.69 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 119μs 57.4ns 222ns 0.326 0 0 22.41 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 129μs 673ns 3.3μs 0.255 0 0 22.36 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 163μs 112ns 432ns 3.54 0.157 0 22.7 KB
master RunWaf(args=NestedMap (100)) net6.0 110μs 53.3ns 200ns 0.43 0 0 32.76 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 135μs 66.9ns 232ns 0.443 0 0 33.33 KB
master RunWaf(args=NestedMap (100)) net472 189μs 709ns 2.75μs 5.33 0.374 0 33.67 KB
master RunWafTwice(args=NestedMap (100)) net6.0 103μs 555ns 3.09μs 0.449 0 0 33.3 KB
master RunWafTwice(args=NestedMap (100)) netcoreapp3.1 142μs 478ns 1.85μs 0.424 0 0 33.86 KB
master RunWafTwice(args=NestedMap (100)) net472 201μs 61.3ns 237ns 5.35 0.389 0 34.23 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 172μs 105ns 405ns 0.551 0 0 39.1 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 198μs 761ns 2.95μs 0.486 0 0 39.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 253μs 159ns 614ns 6.36 0.509 0 40.23 KB
master RunWaf(args=NestedMap (20)) net6.0 99.6μs 43.3ns 189ns 0.43 0 0 32.18 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 134μs 753ns 4.82μs 0.441 0 0 32.3 KB
master RunWaf(args=NestedMap (20)) net472 183μs 72.3ns 271ns 5.1 0.364 0 32.63 KB
master RunWafTwice(args=NestedMap (20)) net6.0 103μs 453ns 1.75μs 0.469 0 0 32.72 KB
master RunWafTwice(args=NestedMap (20)) netcoreapp3.1 139μs 749ns 4.3μs 0.427 0 0 32.82 KB
master RunWafTwice(args=NestedMap (20)) net472 197μs 729ns 2.82μs 5.21 0.386 0 33.19 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 166μs 94.7ns 367ns 0.557 0 0 38.53 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 197μs 90ns 349ns 0.491 0 0 38.6 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 251μs 114ns 428ns 6.16 0.503 0 39.2 KB
#5087 RunWaf(args=NestedMap (10)) net6.0 50.6μs 18ns 67.5ns 0.232 0 0 16.06 KB
#5087 RunWaf(args=NestedMap (10)) netcoreapp3.1 70.1μs 367ns 1.8μs 0.199 0 0 16.06 KB
#5087 RunWaf(args=NestedMap (10)) net472 96.3μs 445ns 1.72μs 2.56 0.0949 0 16.14 KB
#5087 RunWafTwice(args=NestedMap (10)) net6.0 56μs 13.8ns 51.7ns 0.224 0 0 16.6 KB
#5087 RunWafTwice(args=NestedMap (10)) netcoreapp3.1 70.8μs 391ns 2.35μs 0.205 0 0 16.58 KB
#5087 RunWafTwice(args=NestedMap (10)) net472 104μs 95.6ns 370ns 2.63 0.103 0 16.69 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 112μs 352ns 1.36μs 0.284 0 0 22.41 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 129μs 213ns 825ns 0.262 0 0 22.36 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [22]) net472 158μs 76ns 294ns 3.56 0.158 0 22.7 KB
#5087 RunWaf(args=NestedMap (100)) net6.0 110μs 180ns 697ns 0.434 0 0 32.76 KB
#5087 RunWaf(args=NestedMap (100)) netcoreapp3.1 133μs 548ns 2.12μs 0.441 0 0 33.33 KB
#5087 RunWaf(args=NestedMap (100)) net472 186μs 122ns 423ns 5.28 0.37 0 33.67 KB
#5087 RunWafTwice(args=NestedMap (100)) net6.0 113μs 39.6ns 148ns 0.448 0 0 33.3 KB
#5087 RunWafTwice(args=NestedMap (100)) netcoreapp3.1 140μs 612ns 2.29μs 0.394 0 0 33.86 KB
#5087 RunWafTwice(args=NestedMap (100)) net472 201μs 737ns 2.85μs 5.41 0.386 0 34.23 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 173μs 118ns 456ns 0.511 0 0 39.1 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 202μs 984ns 4.29μs 0.508 0 0 39.63 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [23]) net472 253μs 111ns 416ns 6.34 0.507 0 40.23 KB
#5087 RunWaf(args=NestedMap (20)) net6.0 110μs 33.5ns 130ns 0.437 0 0 32.18 KB
#5087 RunWaf(args=NestedMap (20)) netcoreapp3.1 134μs 763ns 5.66μs 0.442 0 0 32.3 KB
#5087 RunWaf(args=NestedMap (20)) net472 184μs 117ns 452ns 5.15 0.368 0 32.63 KB
#5087 RunWafTwice(args=NestedMap (20)) net6.0 99.4μs 35.7ns 133ns 0.442 0 0 32.72 KB
#5087 RunWafTwice(args=NestedMap (20)) netcoreapp3.1 142μs 664ns 2.66μs 0.418 0 0 32.82 KB
#5087 RunWafTwice(args=NestedMap (20)) net472 190μs 92.4ns 358ns 5.24 0.381 0 33.19 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 157μs 80ns 310ns 0.497 0 0 38.53 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 200μs 694ns 2.69μs 0.496 0 0 38.6 KB
#5087 RunWafWithAttack(args=Neste(...)tack) [22]) net472 259μs 358ns 1.39μs 6.14 0.501 0 39.2 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 175μs 153ns 594ns 0.174 0 0 18.25 KB
master SendRequest netcoreapp3.1 195μs 302ns 1.17μs 0.196 0 0 20.41 KB
master SendRequest net472 0.000187ns 0.000166ns 0.000621ns 0 0 0 0 b
#5087 SendRequest net6.0 173μs 148ns 575ns 0.257 0 0 18.25 KB
#5087 SendRequest netcoreapp3.1 196μs 387ns 1.5μs 0.193 0 0 20.41 KB
#5087 SendRequest net472 0.000991ns 0.000367ns 0.00142ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5087

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.45 KB 41.7 KB 245 B 0.59%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 543μs 2.33μs 9.04μs 0.558 0 0 41.45 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 516ns 2μs 0.321 0 0 41.85 KB
master WriteAndFlushEnrichedTraces net472 865μs 4.46μs 20.9μs 8.45 2.53 0.422 53.24 KB
#5087 WriteAndFlushEnrichedTraces net6.0 555μs 1.08μs 4.19μs 0.541 0 0 41.7 KB
#5087 WriteAndFlushEnrichedTraces netcoreapp3.1 661μs 282ns 1.02μs 0.334 0 0 41.72 KB
#5087 WriteAndFlushEnrichedTraces net472 838μs 3.1μs 12μs 8.41 2.4 0.401 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.22μs 0.642ns 2.49ns 0.0109 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.46μs 0.797ns 3.09ns 0.0104 0 0 768 B
master ExecuteNonQuery net472 1.81μs 1.42ns 5.1ns 0.116 0 0 730 B
#5087 ExecuteNonQuery net6.0 1.11μs 0.681ns 2.64ns 0.0106 0 0 768 B
#5087 ExecuteNonQuery netcoreapp3.1 1.51μs 0.69ns 2.67ns 0.0106 0 0 768 B
#5087 ExecuteNonQuery net472 1.87μs 4.4ns 17ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.96ns 3.72ns 0.0133 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.727ns 2.82ns 0.0121 0 0 936 B
master CallElasticsearch net472 2.61μs 1.72ns 6.68ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.28μs 0.439ns 1.64ns 0.0125 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.56μs 0.658ns 2.46ns 0.0133 0 0 984 B
master CallElasticsearchAsync net472 2.6μs 1.04ns 4.05ns 0.16 0 0 1.01 KB
#5087 CallElasticsearch net6.0 1.17μs 1.15ns 4.45ns 0.0129 0 0 936 B
#5087 CallElasticsearch netcoreapp3.1 1.54μs 1.12ns 4.19ns 0.0123 0 0 936 B
#5087 CallElasticsearch net472 2.44μs 0.929ns 3.6ns 0.151 0 0 955 B
#5087 CallElasticsearchAsync net6.0 1.35μs 0.818ns 3.17ns 0.0128 0 0 912 B
#5087 CallElasticsearchAsync netcoreapp3.1 1.54μs 1.39ns 5.4ns 0.013 0 0 984 B
#5087 CallElasticsearchAsync net472 2.6μs 1.31ns 5.08ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.29μs 0.89ns 3.45ns 0.0131 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.67μs 1.56ns 6.03ns 0.0126 0 0 912 B
master ExecuteAsync net472 1.78μs 1.12ns 4.19ns 0.139 0 0 875 B
#5087 ExecuteAsync net6.0 1.32μs 0.792ns 2.97ns 0.0125 0 0 912 B
#5087 ExecuteAsync netcoreapp3.1 1.64μs 2.63ns 9.82ns 0.0116 0 0 912 B
#5087 ExecuteAsync net472 1.94μs 1.21ns 4.51ns 0.139 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.93μs 3.21ns 12.4ns 0.0293 0 0 2.1 KB
master SendAsync netcoreapp3.1 4.94μs 23.2ns 125ns 0.0341 0 0 2.63 KB
master SendAsync net472 7.8μs 8.05ns 31.2ns 0.524 0 0 3.31 KB
#5087 SendAsync net6.0 4.02μs 2.13ns 7.67ns 0.0297 0 0 2.1 KB
#5087 SendAsync netcoreapp3.1 4.83μs 2.23ns 8.64ns 0.0339 0 0 2.63 KB
#5087 SendAsync net472 7.73μs 3.44ns 13.3ns 0.522 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5087

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 212.78 KB 335.61 KB 122.82 KB 57.72%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.67 KB 61.7 KB 4.02 KB 6.98%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 58.1μs 602ns 5.93μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.9μs 260ns 1.01μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.1μs 91.8ns 344ns 0 0 0 57.67 KB
master StringConcatAspectBenchmark net6.0 272μs 4.72μs 43.6μs 0 0 0 202.62 KB
master StringConcatAspectBenchmark netcoreapp3.1 293μs 5.49μs 50.6μs 0 0 0 212.78 KB
master StringConcatAspectBenchmark net472 245μs 4.46μs 42.3μs 0 0 0 221.18 KB
#5087 StringConcatBenchmark net6.0 55.4μs 905ns 8.86μs 0 0 0 43.44 KB
#5087 StringConcatBenchmark netcoreapp3.1 53.5μs 227ns 934ns 0 0 0 42.64 KB
#5087 StringConcatBenchmark net472 37.2μs 72.8ns 272ns 0 0 0 61.7 KB
#5087 StringConcatAspectBenchmark net6.0 264μs 1.42μs 7.24μs 0 0 0 203.14 KB
#5087 StringConcatAspectBenchmark netcoreapp3.1 288μs 3.63μs 33.5μs 0 0 0 335.61 KB
#5087 StringConcatAspectBenchmark net472 224μs 984ns 3.68μs 0 0 0 221.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.44μs 0.961ns 3.47ns 0.0223 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 2.28μs 1.73ns 6.47ns 0.0205 0 0 1.57 KB
master EnrichedLog net472 2.72μs 3.3ns 12.8ns 0.237 0 0 1.5 KB
#5087 EnrichedLog net6.0 1.49μs 0.977ns 3.66ns 0.0218 0 0 1.57 KB
#5087 EnrichedLog netcoreapp3.1 2.07μs 3.36ns 12.6ns 0.0215 0 0 1.57 KB
#5087 EnrichedLog net472 2.51μs 2.99ns 11.6ns 0.237 0 0 1.5 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 168ns 652ns 0 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 118μs 113ns 438ns 0 0 0 4.21 KB
master EnrichedLog net472 149μs 42.4ns 153ns 0.669 0.223 0 4.39 KB
#5087 EnrichedLog net6.0 113μs 105ns 408ns 0.0566 0 0 4.21 KB
#5087 EnrichedLog netcoreapp3.1 118μs 95.5ns 370ns 0 0 0 4.21 KB
#5087 EnrichedLog net472 150μs 125ns 484ns 0.672 0.224 0 4.39 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 2.17ns 8.42ns 0.0292 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 4.3μs 2.37ns 8.22ns 0.0279 0 0 2.13 KB
master EnrichedLog net472 4.76μs 1.27ns 4.57ns 0.308 0 0 1.95 KB
#5087 EnrichedLog net6.0 3.04μs 0.839ns 3.14ns 0.0295 0 0 2.13 KB
#5087 EnrichedLog netcoreapp3.1 3.98μs 2.13ns 8.23ns 0.0279 0 0 2.13 KB
#5087 EnrichedLog net472 4.93μs 1.8ns 6.97ns 0.308 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.35μs 1.69ns 6.55ns 0.0155 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.74μs 1.3ns 4.88ns 0.0148 0 0 1.1 KB
master SendReceive net472 2.18μs 2.41ns 9.34ns 0.177 0 0 1.12 KB
#5087 SendReceive net6.0 1.36μs 0.605ns 2.34ns 0.015 0 0 1.1 KB
#5087 SendReceive netcoreapp3.1 1.83μs 1.22ns 4.73ns 0.0146 0 0 1.1 KB
#5087 SendReceive net472 2.08μs 2.48ns 9.62ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.71μs 0.959ns 3.71ns 0.0216 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.11ns 4.17ns 0.0198 0 0 1.58 KB
master EnrichedLog net472 4.32μs 1.13ns 4.22ns 0.311 0 0 1.97 KB
#5087 EnrichedLog net6.0 2.82μs 0.903ns 3.5ns 0.0212 0 0 1.53 KB
#5087 EnrichedLog netcoreapp3.1 3.77μs 2.19ns 8.48ns 0.0207 0 0 1.58 KB
#5087 EnrichedLog net472 4.34μs 1.56ns 5.83ns 0.311 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5087

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.167 607.32 520.51
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.138 512.95 450.85

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 513ns 0.127ns 0.476ns 0.00738 0 0 536 B
master StartFinishSpan netcoreapp3.1 739ns 0.887ns 3.32ns 0.00731 0 0 536 B
master StartFinishSpan net472 788ns 0.314ns 1.17ns 0.0853 0 0 538 B
master StartFinishScope net6.0 608ns 0.267ns 1.03ns 0.00914 0 0 656 B
master StartFinishScope netcoreapp3.1 811ns 0.31ns 1.2ns 0.00848 0 0 656 B
master StartFinishScope net472 936ns 1.05ns 4.09ns 0.0981 0 0 618 B
#5087 StartFinishSpan net6.0 451ns 0.133ns 0.514ns 0.00761 0 0 536 B
#5087 StartFinishSpan netcoreapp3.1 726ns 0.37ns 1.43ns 0.00717 0 0 536 B
#5087 StartFinishSpan net472 769ns 1.18ns 4.56ns 0.0851 0 0 538 B
#5087 StartFinishScope net6.0 521ns 0.161ns 0.622ns 0.00922 0 0 656 B
#5087 StartFinishScope netcoreapp3.1 829ns 0.308ns 1.19ns 0.00855 0 0 656 B
#5087 StartFinishScope net472 920ns 3.36ns 13ns 0.0982 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5087

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 1.201 1,232.74 1,026.18
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.160 747.69 644.53

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 748ns 0.473ns 1.83ns 0.00935 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 863ns 2.12ns 8.2ns 0.00884 0 0 656 B
master RunOnMethodBegin net472 1.23μs 0.347ns 1.34ns 0.0978 0 0 618 B
#5087 RunOnMethodBegin net6.0 645ns 0.938ns 3.25ns 0.00917 0 0 656 B
#5087 RunOnMethodBegin netcoreapp3.1 912ns 0.425ns 1.65ns 0.0087 0 0 656 B
#5087 RunOnMethodBegin net472 1.03μs 0.667ns 2.58ns 0.0978 0 0 618 B

@andrewlock andrewlock force-pushed the adnrew/ci/bump-fluent-assertion branch from b6d5a42 to 13a1e40 Compare January 9, 2025 08:08
@andrewlock andrewlock requested a review from a team as a code owner January 9, 2025 08:08
@andrewlock andrewlock force-pushed the adnrew/ci/bump-fluent-assertion branch from 13a1e40 to 85a24ca Compare January 9, 2025 08:09
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 9, 2025 •
edited
Loading

Datadog Report

Branch report: adnrew/ci/bump-fluent-assertion
Commit report: 56b405a
Test service: dd-trace-dotnet

✅ 0 Failed, 239664 Passed, 2128 Skipped, 19h 36m 26.88s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • EarlyFlakeDetection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.MsTestV2EvpTests - Last Failure

    Expand for error 
     The sample did not exit in 600000ms. Memory dump taken: True. Killing process.

@andrewlock
Copy link
Member Author

andrewlock commented Jan 9, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #5087 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.115
  • 1 benchmarks are slower, with geometric mean 1.114
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.01μs 43.3ns 256ns 0.0163 0.00817 0 5.6 KB
master StartStopWithChild netcoreapp3.1 10.4μs 51ns 210ns 0.0152 0.00506 0 5.8 KB
master StartStopWithChild net472 16.3μs 45ns 174ns 1.04 0.32 0.0984 6.22 KB
#5087 StartStopWithChild net6.0 8.12μs 41.5ns 272ns 0.016 0.00801 0 5.61 KB
#5087 StartStopWithChild netcoreapp3.1 10.1μs 52.4ns 296ns 0.0208 0.00519 0 5.81 KB
#5087 StartStopWithChild net472 16.4μs 57.3ns 222ns 1.03 0.305 0.0907 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 507μs 851ns 3.18μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 398ns 1.54μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 847μs 467ns 1.81μs 0.422 0 0 3.3 KB
#5087 WriteAndFlushEnrichedTraces net6.0 494μs 444ns 1.72μs 0 0 0 2.7 KB
#5087 WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 467ns 1.81μs 0 0 0 2.7 KB
#5087 WriteAndFlushEnrichedTraces net472 856μs 352ns 1.32μs 0.428 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 149μs 876ns 8.22μs 0.142 0 0 14.47 KB
master SendRequest netcoreapp3.1 169μs 978ns 8.18μs 0.16 0 0 17.27 KB
master SendRequest net472 0.00138ns 0.000661ns 0.00256ns 0 0 0 0 b
#5087 SendRequest net6.0 146μs 708ns 2.92μs 0.146 0 0 14.47 KB
#5087 SendRequest netcoreapp3.1 178μs 1.22μs 12μs 0.173 0 0 17.27 KB
#5087 SendRequest net472 0.00103ns 0.000777ns 0.0028ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 565μs 2.79μs 12.5μs 0.561 0 0 41.64 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.73μs 21.1μs 0.345 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 858μs 4.03μs 15.6μs 8.33 2.5 0.417 53.34 KB
#5087 WriteAndFlushEnrichedTraces net6.0 592μs 3.43μs 31.3μs 0.546 0 0 41.67 KB
#5087 WriteAndFlushEnrichedTraces netcoreapp3.1 716μs 4.06μs 27.9μs 0.393 0 0 41.69 KB
#5087 WriteAndFlushEnrichedTraces net472 859μs 4.13μs 16μs 8.33 2.5 0.417 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.38μs 1.21ns 4.37ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.86μs 2.05ns 7.94ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery net472 2.13μs 1.66ns 6.42ns 0.156 0.00106 0 987 B
#5087 ExecuteNonQuery net6.0 1.24μs 0.921ns 3.57ns 0.0143 0 0 1.02 KB
#5087 ExecuteNonQuery netcoreapp3.1 1.8μs 1.18ns 4.4ns 0.0137 0 0 1.02 KB
#5087 ExecuteNonQuery net472 2.05μs 2.35ns 9.11ns 0.157 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5087

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.115 1,323.99 1,187.82

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 0.636ns 2.46ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.51ns 1.91ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.58μs 1.63ns 6.3ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.26μs 0.619ns 2.32ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 0.82ns 3.18ns 0.0131 0 0 1.02 KB
master CallElasticsearchAsync net472 2.53μs 0.988ns 3.7ns 0.167 0 0 1.05 KB
#5087 CallElasticsearch net6.0 1.19μs 0.405ns 1.46ns 0.0137 0 0 976 B
#5087 CallElasticsearch netcoreapp3.1 1.48μs 0.613ns 2.29ns 0.0126 0 0 976 B
#5087 CallElasticsearch net472 2.59μs 1.64ns 6.13ns 0.157 0 0 995 B
#5087 CallElasticsearchAsync net6.0 1.34μs 2.26ns 8.74ns 0.0128 0 0 952 B
#5087 CallElasticsearchAsync netcoreapp3.1 1.66μs 1.09ns 4.22ns 0.0132 0 0 1.02 KB
#5087 CallElasticsearchAsync net472 2.6μs 0.846ns 3.05ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 1.09ns 4.09ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.63μs 1.29ns 4.83ns 0.0122 0 0 952 B
master ExecuteAsync net472 1.82μs 0.782ns 3.03ns 0.145 0 0 915 B
#5087 ExecuteAsync net6.0 1.29μs 1.18ns 4.41ns 0.0136 0 0 952 B
#5087 ExecuteAsync netcoreapp3.1 1.68μs 1.02ns 3.82ns 0.0126 0 0 952 B
#5087 ExecuteAsync net472 1.84μs 0.296ns 1.11ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.52μs 4.21ns 16.3ns 0.0312 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.48μs 3ns 11.2ns 0.0382 0 0 2.85 KB
master SendAsync net472 7.44μs 2.27ns 8.79ns 0.493 0 0 3.12 KB
#5087 SendAsync net6.0 4.34μs 1.68ns 6.5ns 0.0326 0 0 2.31 KB
#5087 SendAsync netcoreapp3.1 5.41μs 2.25ns 8.42ns 0.0379 0 0 2.85 KB
#5087 SendAsync net472 7.36μs 1.54ns 5.75ns 0.492 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.51μs 0.682ns 2.64ns 0.0234 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.12μs 0.913ns 3.54ns 0.0227 0 0 1.64 KB
master EnrichedLog net472 2.75μs 2.02ns 7.82ns 0.249 0 0 1.57 KB
#5087 EnrichedLog net6.0 1.54μs 0.778ns 2.91ns 0.0233 0 0 1.64 KB
#5087 EnrichedLog netcoreapp3.1 2.21μs 1.06ns 3.97ns 0.0222 0 0 1.64 KB
#5087 EnrichedLog net472 2.71μs 3.05ns 11.4ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 214ns 828ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 293ns 1.13μs 0 0 0 4.28 KB
master EnrichedLog net472 151μs 299ns 1.16μs 0.67 0.223 0 4.46 KB
#5087 EnrichedLog net6.0 117μs 250ns 966ns 0.0577 0 0 4.28 KB
#5087 EnrichedLog netcoreapp3.1 123μs 199ns 770ns 0.0607 0 0 4.28 KB
#5087 EnrichedLog net472 152μs 243ns 942ns 0.679 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.01μs 1.12ns 4.02ns 0.0314 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.7ns 6.58ns 0.0297 0 0 2.2 KB
master EnrichedLog net472 5.02μs 1.84ns 7.13ns 0.32 0 0 2.02 KB
#5087 EnrichedLog net6.0 3.12μs 3.43ns 13.3ns 0.0297 0 0 2.2 KB
#5087 EnrichedLog netcoreapp3.1 4.28μs 1.52ns 5.9ns 0.028 0 0 2.2 KB
#5087 EnrichedLog net472 4.84μs 1.17ns 4.39ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.44μs 0.707ns 2.74ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 1.01ns 3.66ns 0.0149 0 0 1.14 KB
master SendReceive net472 2.08μs 1.09ns 4.07ns 0.183 0 0 1.16 KB
#5087 SendReceive net6.0 1.31μs 1.02ns 3.97ns 0.0164 0 0 1.14 KB
#5087 SendReceive netcoreapp3.1 1.81μs 2.11ns 8.19ns 0.0155 0 0 1.14 KB
#5087 SendReceive net472 2.15μs 1.65ns 6.38ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 0.624ns 2.25ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.93μs 2.9ns 10.5ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.34μs 2.6ns 10.1ns 0.322 0 0 2.04 KB
#5087 EnrichedLog net6.0 2.84μs 6.97ns 27ns 0.0225 0 0 1.6 KB
#5087 EnrichedLog netcoreapp3.1 3.81μs 1.89ns 7.08ns 0.021 0 0 1.65 KB
#5087 EnrichedLog net472 4.38μs 2.61ns 10.1ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5087

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.114 501.65 559.02

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 408ns 0.287ns 1.11ns 0.00812 0 0 576 B
master StartFinishSpan netcoreapp3.1 611ns 0.372ns 1.39ns 0.00763 0 0 576 B
master StartFinishSpan net472 682ns 0.331ns 1.28ns 0.0916 0 0 578 B
master StartFinishScope net6.0 501ns 0.351ns 1.36ns 0.00975 0 0 696 B
master StartFinishScope netcoreapp3.1 729ns 0.469ns 1.82ns 0.00952 0 0 696 B
master StartFinishScope net472 781ns 0.979ns 3.79ns 0.104 0 0 658 B
#5087 StartFinishSpan net6.0 418ns 1.19ns 4.59ns 0.008 0 0 576 B
#5087 StartFinishSpan netcoreapp3.1 596ns 0.581ns 2.25ns 0.00773 0 0 576 B
#5087 StartFinishSpan net472 682ns 0.125ns 0.469ns 0.0916 0 0 578 B
#5087 StartFinishScope net6.0 559ns 0.333ns 1.29ns 0.0098 0 0 696 B
#5087 StartFinishScope netcoreapp3.1 788ns 0.51ns 1.97ns 0.00936 0 0 696 B
#5087 StartFinishScope net472 844ns 0.473ns 1.83ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 592ns 0.328ns 1.23ns 0.00987 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.01μs 0.769ns 2.98ns 0.00913 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.563ns 2.18ns 0.104 0 0 658 B
#5087 RunOnMethodBegin net6.0 611ns 0.315ns 1.22ns 0.00965 0 0 696 B
#5087 RunOnMethodBegin netcoreapp3.1 971ns 1.14ns 4.41ns 0.00936 0 0 696 B
#5087 RunOnMethodBegin net472 1.1μs 0.415ns 1.61ns 0.104 0 0 658 B

@andrewlock andrewlock force-pushed the adnrew/ci/bump-fluent-assertion branch from 69e4166 to 56b405a Compare January 9, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevingosse kevingosse kevingosse approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @kevingosse