bump dotnet version for protobuf and eShopOnWeb exploration tests #6475

vandonr · 2024-12-20T14:12:20Z

Summary of changes

change the version of the dotnet framework used to run 2 exploration tests from netcore 2.1 to a more recent one
also change the version of those libraries used to have one that's compatible with more recent dotnet versions

Reason for change

those tests were using netcore 2.1 which we don't actively support anymore, so it makes sense to test them with a supported version.

andrewlock

Thanks, LGTM as long as they definitely run and pass for all the components! 🙂

(I'm not sure they will run automatically for debugger and tracer and profiler) without doing a manual run

vandonr · 2024-12-20T14:15:57Z

(I'm not sure they will run automatically for debugger and tracer and profiler) without doing a manual run

ah, right, I was just thinking we could wait for a green CI and be good to go, but it looks like they only run for the debugger

datadog-ddstaging · 2024-12-20T14:33:49Z

Datadog Report

Branch report: vandonr/explo
Commit report: b13fc5a
Test service: dd-trace-dotnet

✅ 0 Failed, 243237 Passed, 2939 Skipped, 32h 8m 37.87s Total Time

andrewlock · 2024-12-20T14:49:25Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6475) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6475) - mean (983ms)  : 960, 1005
     .   : milestone, 983,
    master - mean (977ms)  : 958, 996
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6475) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6475) - mean (679ms)  : 658, 699
     .   : milestone, 679,
    master - mean (679ms)  : 662, 695
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6475) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 88, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6475) - mean (631ms)  : 614, 648
     .   : milestone, 631,
    master - mean (638ms)  : 619, 656
     .   : milestone, 638,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6475) - mean (194ms)  : 189, 199
     .   : milestone, 194,
    master - mean (194ms)  : 189, 199
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6475) - mean (1,106ms)  : 1073, 1140
     .   : milestone, 1106,
    master - mean (1,102ms)  : 1068, 1135
     .   : milestone, 1102,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6475) - mean (282ms)  : 275, 288
     .   : milestone, 282,
    master - mean (279ms)  : 274, 284
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6475) - mean (870ms)  : 839, 901
     .   : milestone, 870,
    master - mean (873ms)  : 846, 900
     .   : milestone, 873,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6475) - mean (268ms)  : 264, 272
     .   : milestone, 268,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6475) - mean (848ms)  : 813, 883
     .   : milestone, 848,
    master - mean (850ms)  : 814, 886
     .   : milestone, 850,

vandonr · 2024-12-20T17:03:39Z

tracer/build/_build/Build.ExplorationTests.cs

@@ -599,20 +599,20 @@ public static ExplorationTestDescription GetExplorationTestDescription(Explorati
            {
                Name = ExplorationTestName.eShopOnWeb,
                GitRepositoryUrl = "https://github.com/dotnet-architecture/eShopOnWeb.git",
-                GitRepositoryTag = "netcore2.1",
+                GitRepositoryTag = "main",


I know we want to target a specific tag/version to make sure there is no variability in the CI from distant changes, but here the repo has been archived since 6+ months, so I think we're pretty safe pulling main, it shouldn't change any time soon.

Even so, it probably makes sense to specify the specific commit?

Suggested change

GitRepositoryTag = "main",

GitRepositoryTag = "2414014bfa0f4d2021b5bc9061429a98d232f440",

thanks, I didn't know we could specify a commit hash here

actually we can't, this breaks the command used for cloning. Also, it's not even a feature that's readily available with git, it depends on server side config (see https://stackoverflow.com/a/3489576/787883).
I implemented it using a second command to git reset --hard to a provided sha.

andrewlock · 2024-12-20T18:13:09Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6475) (11.139M)   : 0, 11139488
    master (11.166M)   : 0, 11165619
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6475) (7.282M)   : 0, 7282383
    master (7.232M)   : 0, 7232435
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.555M)   : 0, 7555239

    section Manual
    master (11.218M)   : 0, 11218357

    section Manual + Automatic
    This PR (6475) (6.707M)   : 0, 6706823
    master (6.695M)   : 0, 6694720

    section DD_TRACE_ENABLED=0
    master (10.195M)   : 0, 10194994

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6475) (9.626M)   : 0, 9625630
    master (9.350M)   : 0, 9350086
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6475) (6.356M)   : 0, 6355828
    master (6.223M)   : 0, 6222880

    section Trace stats
    master (6.644M)   : 0, 6644302

    section Manual
    master (9.490M)   : 0, 9490052

    section Manual + Automatic
    This PR (6475) (5.939M)   : 0, 5938564
    master (5.826M)   : 0, 5826117

    section DD_TRACE_ENABLED=0
    master (8.806M)   : 0, 8806093

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6475) (9.734M)   : 0, 9733803
    master (10.038M)   : 0, 10038108
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6475) (5.955M)   : crit ,0, 5955291
    master (6.759M)   : 0, 6759031
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.327M)   : 0, 7327150

    section Manual
    master (10.148M)   : 0, 10147695

    section Manual + Automatic
    This PR (6475) (5.705M)   : crit ,0, 5705230
    master (6.270M)   : 0, 6270298

    section DD_TRACE_ENABLED=0
    master (9.572M)   : 0, 9571995

andrewlock · 2024-12-21T09:10:49Z

Benchmarks Report for tracer 🐌

Benchmarks for #6475 compared to master:

3 benchmarks are faster, with geometric mean 1.168
1 benchmarks are slower, with geometric mean 1.133
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.11μs	45.9ns	328ns	0.0149	0.00372	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	56.8ns	364ns	0.0198	0.00495	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	55.2ns	214ns	1.03	0.296	0.0985	6.21 KB
#6475	`StartStopWithChild`	net6.0	8.08μs	30.7ns	106ns	0.0155	0.00773	0	5.61 KB
#6475	`StartStopWithChild`	netcoreapp3.1	10μs	47.3ns	201ns	0.0197	0.00986	0	5.8 KB
#6475	`StartStopWithChild`	net472	16.4μs	59.1ns	229ns	1.05	0.32	0.104	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	488μs	593ns	2.3μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	463ns	1.79μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	855μs	879ns	3.4μs	0.428	3.3 KB
#6475	`WriteAndFlushEnrichedTraces`	net6.0	502μs	245ns	916ns	0	2.7 KB
#6475	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	482ns	1.8μs	0	2.7 KB
#6475	`WriteAndFlushEnrichedTraces`	net472	862μs	491ns	1.84μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	156μs	1.03μs	10.1μs	0.15	14.47 KB
master	`SendRequest`	netcoreapp3.1	172μs	992ns	8.36μs	0.225	17.27 KB
master	`SendRequest`	net472	0.0206ns	0.00503ns	0.0195ns	0	0 b
#6475	`SendRequest`	net6.0	155μs	980ns	9.55μs	0.17	14.47 KB
#6475	`SendRequest`	netcoreapp3.1	175μs	1.07μs	10.6μs	0.175	17.27 KB
#6475	`SendRequest`	net472	0.00409ns	0.00181ns	0.00702ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	580μs	3.31μs	24.1μs	0.543	0	0	41.67 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	3.49μs	18.2μs	0.322	0	0	41.78 KB
master	`WriteAndFlushEnrichedTraces`	net472	847μs	2.74μs	10.3μs	8.13	2.57	0.428	53.27 KB
#6475	`WriteAndFlushEnrichedTraces`	net6.0	580μs	2.49μs	9.95μs	0.579	0	0	41.68 KB
#6475	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	2.89μs	10.4μs	0.336	0	0	41.74 KB
#6475	`WriteAndFlushEnrichedTraces`	net472	880μs	4.24μs	17μs	8.19	2.59	0.431	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.2μs	1.46ns	5.65ns	0.014	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.72ns	6.44ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.14μs	2.73ns	10.6ns	0.156	0.00106	987 B
#6475	`ExecuteNonQuery`	net6.0	1.24μs	1.29ns	4.98ns	0.0141	0	1.02 KB
#6475	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.95ns	7.56ns	0.0134	0	1.02 KB
#6475	`ExecuteNonQuery`	net472	2.16μs	2.01ns	7.8ns	0.157	0.00107	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6475

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.133	1,141.28	1,292.55

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.29μs	0.623ns	2.33ns	0.0136	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.59μs	1.68ns	6.3ns	0.0134	976 B
master	`CallElasticsearch`	net472	2.52μs	1.52ns	5.88ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.14μs	0.621ns	2.32ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.57μs	0.602ns	2.25ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.54μs	0.953ns	3.57ns	0.167	1.05 KB
#6475	`CallElasticsearch`	net6.0	1.19μs	0.712ns	2.66ns	0.0137	976 B
#6475	`CallElasticsearch`	netcoreapp3.1	1.55μs	2.58ns	9.64ns	0.0131	976 B
#6475	`CallElasticsearch`	net472	2.6μs	1.43ns	5.55ns	0.157	995 B
#6475	`CallElasticsearchAsync`	net6.0	1.29μs	1.21ns	4.69ns	0.0135	952 B
#6475	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	0.811ns	3.14ns	0.0135	1.02 KB
#6475	`CallElasticsearchAsync`	net472	2.68μs	1.27ns	4.74ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.28μs	0.284ns	0.985ns	0.0131	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.72μs	0.614ns	2.3ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.86μs	0.799ns	2.99ns	0.145	915 B
#6475	`ExecuteAsync`	net6.0	1.29μs	0.903ns	3.5ns	0.0135	952 B
#6475	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.73ns	2.83ns	0.0132	952 B
#6475	`ExecuteAsync`	net472	1.82μs	0.479ns	1.85ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.45μs	1.55ns	5.81ns	0.0312	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.37μs	4.55ns	17.6ns	0.0376	2.85 KB
master	`SendAsync`	net472	7.35μs	2.24ns	8.67ns	0.493	3.12 KB
#6475	`SendAsync`	net6.0	4.4μs	1.79ns	6.69ns	0.0329	2.31 KB
#6475	`SendAsync`	netcoreapp3.1	5.19μs	2.09ns	8.1ns	0.0391	2.85 KB
#6475	`SendAsync`	net472	7.41μs	1.5ns	5.62ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.62μs	0.575ns	2.15ns	0.0234	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.1μs	0.775ns	3ns	0.0211	1.64 KB
master	`EnrichedLog`	net472	2.74μs	2.3ns	8.92ns	0.25	1.57 KB
#6475	`EnrichedLog`	net6.0	1.48μs	0.964ns	3.74ns	0.0228	1.64 KB
#6475	`EnrichedLog`	netcoreapp3.1	2.27μs	1.17ns	4.39ns	0.0226	1.64 KB
#6475	`EnrichedLog`	net472	2.7μs	1.86ns	7.22ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	139ns	502ns	0.0598	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	150ns	582ns	0	0	4.28 KB
master	`EnrichedLog`	net472	153μs	138ns	517ns	0.687	0.229	4.46 KB
#6475	`EnrichedLog`	net6.0	119μs	298ns	1.15μs	0.0592	0	4.28 KB
#6475	`EnrichedLog`	netcoreapp3.1	123μs	140ns	505ns	0	0	4.28 KB
#6475	`EnrichedLog`	net472	153μs	143ns	553ns	0.684	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.09μs	0.859ns	3.33ns	0.0311	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.12μs	1.65ns	6.37ns	0.0288	2.2 KB
master	`EnrichedLog`	net472	4.86μs	1.86ns	7.22ns	0.32	2.02 KB
#6475	`EnrichedLog`	net6.0	2.85μs	1.36ns	5.11ns	0.0313	2.2 KB
#6475	`EnrichedLog`	netcoreapp3.1	4.09μs	2.05ns	7.94ns	0.0288	2.2 KB
#6475	`EnrichedLog`	net472	4.89μs	1.2ns	4.66ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.43μs	0.861ns	3.34ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.85μs	0.812ns	3.14ns	0.0157	1.14 KB
master	`SendReceive`	net472	2.1μs	1.31ns	4.53ns	0.184	1.16 KB
#6475	`SendReceive`	net6.0	1.39μs	0.702ns	2.72ns	0.016	1.14 KB
#6475	`SendReceive`	netcoreapp3.1	1.74μs	1.52ns	5.88ns	0.0156	1.14 KB
#6475	`SendReceive`	net472	2.13μs	1.18ns	4.42ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.65μs	1.11ns	4.16ns	0.0227	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.77μs	1.9ns	7.37ns	0.0207	1.65 KB
master	`EnrichedLog`	net472	4.44μs	2.99ns	11.6ns	0.323	2.04 KB
#6475	`EnrichedLog`	net6.0	2.88μs	0.938ns	3.38ns	0.023	1.6 KB
#6475	`EnrichedLog`	netcoreapp3.1	3.9μs	2.66ns	10.3ns	0.0216	1.65 KB
#6475	`EnrichedLog`	net472	4.38μs	1.84ns	6.9ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6475

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.222	674.41	551.93
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.163	558.69	480.30
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.121	451.29	402.61

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	451ns	0.319ns	1.23ns	0.00818	576 B
master	`StartFinishSpan`	netcoreapp3.1	675ns	0.459ns	1.78ns	0.00766	576 B
master	`StartFinishSpan`	net472	637ns	0.307ns	1.19ns	0.0916	578 B
master	`StartFinishScope`	net6.0	558ns	0.334ns	1.29ns	0.00985	696 B
master	`StartFinishScope`	netcoreapp3.1	746ns	0.827ns	3.2ns	0.00937	696 B
master	`StartFinishScope`	net472	859ns	0.371ns	1.44ns	0.104	658 B
#6475	`StartFinishSpan`	net6.0	402ns	0.19ns	0.709ns	0.0081	576 B
#6475	`StartFinishSpan`	netcoreapp3.1	552ns	0.213ns	0.826ns	0.00775	576 B
#6475	`StartFinishSpan`	net472	691ns	0.468ns	1.75ns	0.0915	578 B
#6475	`StartFinishScope`	net6.0	480ns	0.348ns	1.35ns	0.00965	696 B
#6475	`StartFinishScope`	netcoreapp3.1	702ns	0.513ns	1.92ns	0.00922	696 B
#6475	`StartFinishScope`	net472	925ns	0.404ns	1.56ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	664ns	0.266ns	1.03ns	0.00965	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	915ns	1.22ns	4.74ns	0.00948	696 B
master	`RunOnMethodBegin`	net472	1.15μs	0.536ns	2.08ns	0.104	658 B
#6475	`RunOnMethodBegin`	net6.0	614ns	0.345ns	1.34ns	0.00995	696 B
#6475	`RunOnMethodBegin`	netcoreapp3.1	970ns	0.647ns	2.33ns	0.00918	696 B
#6475	`RunOnMethodBegin`	net472	1.09μs	0.989ns	3.83ns	0.104	658 B

andrewlock

Thanks, makes sense I think 👍

andrewlock · 2024-12-23T17:33:45Z

tracer/build/_build/Build.ExplorationTests.cs

@@ -599,20 +599,20 @@ public static ExplorationTestDescription GetExplorationTestDescription(Explorati
            {
                Name = ExplorationTestName.eShopOnWeb,
                GitRepositoryUrl = "https://github.com/dotnet-architecture/eShopOnWeb.git",
-                GitRepositoryTag = "netcore2.1",
+                GitRepositoryTag = "main",


Even so, it probably makes sense to specify the specific commit?

Suggested change

GitRepositoryTag = "main",

GitRepositoryTag = "2414014bfa0f4d2021b5bc9061429a98d232f440",

Co-authored-by: Andrew Lock <[email protected]>

vandonr · 2024-12-24T15:00:01Z

there is still an issue on windows with protobuf tests, we have the following error:
System.BadImageFormatException: Bad IL format. The format of the file '...\Google.Protobuf.Test\bin\Release\net6.0\testhost.exe' is invalid.
not too sure what's causing it 🤔

andrewlock · 2024-12-24T15:34:12Z

there is still an issue on windows with protobuf tests, we have the following error: System.BadImageFormatException: Bad IL format. The format of the file '...\Google.Protobuf.Test\bin\Release\net6.0\testhost.exe' is invalid. not too sure what's causing it 🤔

Yikes, that sounds bad. We instrument the testhost, and BadImageFormatException can be created from a bad instrumentation, so if that's the case, this is Not Good™

vandonr · 2024-12-24T15:39:36Z

it works on Linux though 🙃

…ests

bump dotnet version for protobuf and eShopOnWeb exploration tests

9017251

vandonr requested a review from a team as a code owner December 20, 2024 14:12

github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 20, 2024

andrewlock approved these changes Dec 20, 2024

View reviewed changes

vandonr added 4 commits December 20, 2024 16:04

remove tag pinning us in the past on eShopOnWeb

2a8a42f

bump proto version used to have one that targets net6

7773d15

add git tag as it's required

305cc70

actually use net8 as mentionned in their readme

8b7f682

vandonr commented Dec 20, 2024

View reviewed changes

andrewlock approved these changes Dec 23, 2024

View reviewed changes

pin eShopOnWeb's version to a specific commit

cadc39a

Co-authored-by: Andrew Lock <[email protected]>

vandonr added 5 commits January 6, 2025 11:15

use netcoreapp 3.1 for protobuf to see if it helps

07fbe72

Merge remote-tracking branch 'origin/master' into vandonr/explo

463cbd0

add ability to target a specific commit rather than a tag for explo t…

fad775b

…ests

fix git command to reset

53dd729

revert change to netcore31 for proto

b13fc5a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump dotnet version for protobuf and eShopOnWeb exploration tests #6475

bump dotnet version for protobuf and eShopOnWeb exploration tests #6475

vandonr commented Dec 20, 2024 •

edited

Loading

andrewlock left a comment

vandonr commented Dec 20, 2024

datadog-ddstaging bot commented Dec 20, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024 •

edited

Loading

vandonr Dec 20, 2024

andrewlock Dec 23, 2024

vandonr Dec 24, 2024

vandonr Jan 6, 2025

andrewlock commented Dec 20, 2024

andrewlock commented Dec 21, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6475

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6475

Raw results

Raw results

andrewlock left a comment

andrewlock Dec 23, 2024

vandonr commented Dec 24, 2024

andrewlock commented Dec 24, 2024

vandonr commented Dec 24, 2024

	GitRepositoryTag = "main",
	GitRepositoryTag = "2414014bfa0f4d2021b5bc9061429a98d232f440",

bump dotnet version for protobuf and eShopOnWeb exploration tests #6475

Are you sure you want to change the base?

bump dotnet version for protobuf and eShopOnWeb exploration tests #6475

Conversation

vandonr commented Dec 20, 2024 • edited Loading

Summary of changes

Reason for change

andrewlock left a comment

Choose a reason for hiding this comment

vandonr commented Dec 20, 2024

datadog-ddstaging bot commented Dec 20, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 20, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

vandonr Dec 20, 2024

Choose a reason for hiding this comment

andrewlock Dec 23, 2024

Choose a reason for hiding this comment

vandonr Dec 24, 2024

Choose a reason for hiding this comment

vandonr Jan 6, 2025

Choose a reason for hiding this comment

andrewlock commented Dec 20, 2024

Throughput/Crank Report ⚡

andrewlock commented Dec 21, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6475

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6475

Raw results

Raw results

andrewlock left a comment

Choose a reason for hiding this comment

andrewlock Dec 23, 2024

Choose a reason for hiding this comment

vandonr commented Dec 24, 2024

andrewlock commented Dec 24, 2024

vandonr commented Dec 24, 2024

vandonr commented Dec 20, 2024 •

edited

Loading

datadog-ddstaging bot commented Dec 20, 2024 •

edited

Loading

andrewlock commented Dec 20, 2024 •

edited

Loading

andrewlock commented Dec 21, 2024 •

edited

Loading