Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issues on aspects on net5.0 #6500

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix build issues on aspects on net5.0 #6500

merged 2 commits into from
Jan 6, 2025

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Jan 6, 2025

Summary of changes

Forgot to change some tests in the Analyzer.

Other details

Related PR #6495

@e-n-0 e-n-0 requested review from a team as code owners January 6, 2025 09:39
@andrewlock
Copy link
Member

andrewlock commented Jan 6, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6500) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6500) - mean (971ms)  : 942, 999
     .   : milestone, 971,
    master - mean (973ms)  : 948, 998
     .   : milestone, 973,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6500) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 104, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6500) - mean (676ms)  : 662, 690
     .   : milestone, 676,
    master - mean (678ms)  : 664, 691
     .   : milestone, 678,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6500) - mean (91ms)  : 88, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6500) - mean (630ms)  : 614, 646
     .   : milestone, 630,
    master - mean (631ms)  : 616, 645
     .   : milestone, 631,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6500) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (195ms)  : 190, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (6500) - mean (1,099ms)  : 1075, 1123
     .   : milestone, 1099,
    master - mean (1,099ms)  : 1063, 1135
     .   : milestone, 1099,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6500) - mean (279ms)  : 273, 284
     .   : milestone, 279,
    master - mean (277ms)  : 273, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6500) - mean (873ms)  : 845, 902
     .   : milestone, 873,
    master - mean (873ms)  : 842, 903
     .   : milestone, 873,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6500) - mean (266ms)  : 262, 271
     .   : milestone, 266,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6500) - mean (853ms)  : 817, 890
     .   : milestone, 853,
    master - mean (851ms)  : 814, 888
     .   : milestone, 851,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 6, 2025 •
edited
Loading

Datadog Report

Branch report: flavien/asm/fix-master-aspects
Commit report: 5f638fc
Test service: dd-trace-dotnet

✅ 0 Failed, 572187 Passed, 4098 Skipped, 52h 36m 19.88s Total Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

  • ObjectExtractorSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark 175ns (+11ns, +7%) - Details

@andrewlock
Copy link
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6500 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 204μs 123ns 460ns 2.65 0 0 188.76 KB
master AllCycleSimpleBody netcoreapp3.1 305μs 135ns 505ns 2.6 0 0 196.09 KB
master AllCycleSimpleBody net472 267μs 299ns 1.16μs 35.8 2 0 225.79 KB
master AllCycleMoreComplexBody net6.0 213μs 90.9ns 340ns 2.67 0 0 192.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 317μs 170ns 637ns 2.69 0 0 199.5 KB
master AllCycleMoreComplexBody net472 278μs 143ns 533ns 36.3 2.09 0 229.3 KB
master ObjectExtractorSimpleBody net6.0 139ns 0.0944ns 0.353ns 0.00395 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 192ns 0.137ns 0.493ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 165ns 0.16ns 0.597ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.93μs 1.32ns 4.76ns 0.0528 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.87μs 1.76ns 6.34ns 0.0504 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.6μs 3.3ns 12.3ns 0.602 0.00539 0 3.8 KB
#6500 AllCycleSimpleBody net6.0 203μs 91.1ns 329ns 2.65 0 0 188.76 KB
#6500 AllCycleSimpleBody netcoreapp3.1 307μs 75.3ns 282ns 2.76 0 0 196.09 KB
#6500 AllCycleSimpleBody net472 269μs 136ns 509ns 35.9 2.04 0 225.79 KB
#6500 AllCycleMoreComplexBody net6.0 211μs 54.6ns 204ns 2.74 0 0 192.26 KB
#6500 AllCycleMoreComplexBody netcoreapp3.1 320μs 91.5ns 343ns 2.72 0 0 199.51 KB
#6500 AllCycleMoreComplexBody net472 281μs 164ns 615ns 36.4 2.1 0 229.3 KB
#6500 ObjectExtractorSimpleBody net6.0 139ns 0.0963ns 0.373ns 0.00394 0 0 280 B
#6500 ObjectExtractorSimpleBody netcoreapp3.1 186ns 0.135ns 0.522ns 0.00366 0 0 272 B
#6500 ObjectExtractorSimpleBody net472 176ns 0.129ns 0.5ns 0.0446 0 0 281 B
#6500 ObjectExtractorMoreComplexBody net6.0 2.85μs 2.21ns 8.26ns 0.0528 0 0 3.78 KB
#6500 ObjectExtractorMoreComplexBody netcoreapp3.1 3.81μs 4.56ns 17ns 0.0496 0 0 3.69 KB
#6500 ObjectExtractorMoreComplexBody net472 3.63μs 2.88ns 11.2ns 0.603 0.00548 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37μs 25.7ns 99.7ns 0.458 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54μs 16.6ns 62ns 0.429 0 0 32.4 KB
master EncodeArgs net472 65.7μs 43.1ns 161ns 5.16 0.0658 0 32.5 KB
master EncodeLegacyArgs net6.0 73.5μs 55.3ns 199ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 108μs 62.3ns 241ns 0 0 0 2.15 KB
master EncodeLegacyArgs net472 156μs 84.2ns 326ns 0.311 0 0 2.15 KB
#6500 EncodeArgs net6.0 37.6μs 41.5ns 155ns 0.461 0 0 32.4 KB
#6500 EncodeArgs netcoreapp3.1 53.8μs 27.2ns 98.1ns 0.43 0 0 32.4 KB
#6500 EncodeArgs net472 67.1μs 159ns 618ns 5.16 0.0661 0 32.5 KB
#6500 EncodeLegacyArgs net6.0 76.1μs 44.6ns 173ns 0 0 0 2.14 KB
#6500 EncodeLegacyArgs netcoreapp3.1 105μs 47.2ns 183ns 0 0 0 2.14 KB
#6500 EncodeLegacyArgs net472 154μs 148ns 574ns 0.31 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 176μs 85.3ns 296ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 186μs 292ns 1.13μs 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 199μs 74.4ns 278ns 0.296 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 116μs 51.5ns 199ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 123μs 86.8ns 336ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 132μs 37.9ns 142ns 0.197 0 0 1.49 KB
#6500 RunWafRealisticBenchmark net6.0 173μs 182ns 703ns 0 0 0 2.44 KB
#6500 RunWafRealisticBenchmark netcoreapp3.1 188μs 233ns 904ns 0 0 0 2.39 KB
#6500 RunWafRealisticBenchmark net472 200μs 57.6ns 223ns 0.299 0 0 2.46 KB
#6500 RunWafRealisticBenchmarkWithAttack net6.0 116μs 203ns 785ns 0 0 0 1.47 KB
#6500 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 123μs 148ns 573ns 0 0 0 1.46 KB
#6500 RunWafRealisticBenchmarkWithAttack net472 132μs 34.1ns 128ns 0.198 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6500

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 61.66 KB 57.26 KB -4.41 KB -7.15%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 51.5μs 260ns 1.13μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 61.9μs 869ns 8.52μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 36.8μs 118ns 427ns 0 0 0 61.66 KB
master StringConcatAspectBenchmark net6.0 292μs 5.87μs 57.2μs 0 0 0 254.43 KB
master StringConcatAspectBenchmark netcoreapp3.1 350μs 1.74μs 7.37μs 0 0 0 254.65 KB
master StringConcatAspectBenchmark net472 294μs 6.59μs 64.6μs 0 0 0 278.53 KB
#6500 StringConcatBenchmark net6.0 51.2μs 243ns 941ns 0 0 0 43.44 KB
#6500 StringConcatBenchmark netcoreapp3.1 58.1μs 772ns 7.6μs 0 0 0 42.64 KB
#6500 StringConcatBenchmark net472 37.6μs 172ns 645ns 0 0 0 57.26 KB
#6500 StringConcatAspectBenchmark net6.0 301μs 1.57μs 7.98μs 0 0 0 254.35 KB
#6500 StringConcatAspectBenchmark netcoreapp3.1 344μs 1.57μs 6.27μs 0 0 0 254.34 KB
#6500 StringConcatAspectBenchmark net472 281μs 6.02μs 58.3μs 0 0 0 278.53 KB

andrewlock
andrewlock approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

daniel-romano-DD
daniel-romano-DD approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6500 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.149
  • 1 benchmarks are slower, with geometric mean 1.162
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.02μs 44.8ns 297ns 0.0158 0.00395 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.3μs 51.5ns 305ns 0.02 0.01 0 5.8 KB
master StartStopWithChild net472 16.6μs 67.8ns 263ns 1.04 0.306 0.0886 6.22 KB
#6500 StartStopWithChild net6.0 8.34μs 47.4ns 321ns 0.0171 0.00853 0 5.61 KB
#6500 StartStopWithChild netcoreapp3.1 9.94μs 52ns 320ns 0.02 0.00999 0 5.79 KB
#6500 StartStopWithChild net472 16.5μs 36.5ns 141ns 1.04 0.307 0.0971 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 484μs 317ns 1.18μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 665μs 276ns 1.07μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 859μs 491ns 1.9μs 0.425 0 0 3.3 KB
#6500 WriteAndFlushEnrichedTraces net6.0 479μs 421ns 1.63μs 0 0 0 2.7 KB
#6500 WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 283ns 1.06μs 0 0 0 2.7 KB
#6500 WriteAndFlushEnrichedTraces net472 850μs 573ns 2.15μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 158μs 929ns 9.01μs 0.151 0 0 14.47 KB
master SendRequest netcoreapp3.1 173μs 996ns 8.51μs 0.16 0 0 17.27 KB
master SendRequest net472 0.000458ns 0.000314ns 0.00113ns 0 0 0 0 b
#6500 SendRequest net6.0 155μs 1μs 9.75μs 0.164 0 0 14.47 KB
#6500 SendRequest netcoreapp3.1 174μs 1.01μs 8.64μs 0.16 0 0 17.27 KB
#6500 SendRequest net472 0.00118ns 0.000551ns 0.00214ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6500

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.48 KB 41.77 KB 295 B 0.71%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 570μs 1.51μs 5.23μs 0.291 0 0 41.48 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 675μs 3.7μs 26.2μs 0.34 0 0 41.84 KB
master WriteAndFlushEnrichedTraces net472 852μs 3.68μs 14.3μs 8.39 2.52 0.419 53.28 KB
#6500 WriteAndFlushEnrichedTraces net6.0 598μs 3.31μs 19.3μs 0.561 0 0 41.77 KB
#6500 WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.68μs 20.2μs 0.331 0 0 41.7 KB
#6500 WriteAndFlushEnrichedTraces net472 865μs 3.75μs 15μs 8.42 2.66 0.443 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.36μs 0.82ns 3.18ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 5.35ns 20.7ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 1.95μs 1.27ns 4.77ns 0.156 0.000969 0 987 B
#6500 ExecuteNonQuery net6.0 1.32μs 1.62ns 6.27ns 0.014 0 0 1.02 KB
#6500 ExecuteNonQuery netcoreapp3.1 1.74μs 0.973ns 3.37ns 0.0136 0 0 1.02 KB
#6500 ExecuteNonQuery net472 2.07μs 2.34ns 8.77ns 0.157 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6500

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.131 1,317.75 1,164.68

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 0.38ns 1.42ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.52μs 0.833ns 3.12ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.49μs 2.22ns 8.6ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.22μs 0.378ns 1.31ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.6μs 1.14ns 4.42ns 0.0136 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 1.89ns 7.32ns 0.167 0 0 1.05 KB
#6500 CallElasticsearch net6.0 1.16μs 1.59ns 5.53ns 0.0139 0 0 976 B
#6500 CallElasticsearch netcoreapp3.1 1.62μs 0.78ns 2.92ns 0.013 0 0 976 B
#6500 CallElasticsearch net472 2.61μs 2.13ns 7.95ns 0.158 0 0 995 B
#6500 CallElasticsearchAsync net6.0 1.34μs 1.06ns 4.12ns 0.0134 0 0 952 B
#6500 CallElasticsearchAsync netcoreapp3.1 1.72μs 1.18ns 4.43ns 0.0137 0 0 1.02 KB
#6500 CallElasticsearchAsync net472 2.65μs 1.99ns 7.44ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.32μs 0.495ns 1.85ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.59μs 2.53ns 9.8ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.86μs 0.397ns 1.49ns 0.145 0 0 915 B
#6500 ExecuteAsync net6.0 1.36μs 0.977ns 3.66ns 0.0133 0 0 952 B
#6500 ExecuteAsync netcoreapp3.1 1.64μs 1.63ns 6.3ns 0.0131 0 0 952 B
#6500 ExecuteAsync net472 1.84μs 0.279ns 1ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.56μs 1.42ns 5.33ns 0.032 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.25μs 1.92ns 7.43ns 0.0367 0 0 2.85 KB
master SendAsync net472 7.35μs 2.47ns 9.57ns 0.496 0 0 3.12 KB
#6500 SendAsync net6.0 4.23μs 1.44ns 5.4ns 0.0318 0 0 2.31 KB
#6500 SendAsync netcoreapp3.1 5.32μs 2.05ns 7.92ns 0.0374 0 0 2.85 KB
#6500 SendAsync net472 7.33μs 1.12ns 4.17ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.46μs 0.495ns 1.85ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.19μs 0.96ns 3.59ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.61μs 1.9ns 7.12ns 0.249 0 0 1.57 KB
#6500 EnrichedLog net6.0 1.45μs 1.03ns 3.86ns 0.0234 0 0 1.64 KB
#6500 EnrichedLog netcoreapp3.1 2.3μs 2.37ns 8.88ns 0.0216 0 0 1.64 KB
#6500 EnrichedLog net472 2.67μs 1.71ns 6.63ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 184ns 711ns 0.0587 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 281ns 1.09μs 0.0611 0 0 4.28 KB
master EnrichedLog net472 149μs 127ns 476ns 0.674 0.225 0 4.46 KB
#6500 EnrichedLog net6.0 118μs 159ns 617ns 0.0584 0 0 4.28 KB
#6500 EnrichedLog netcoreapp3.1 122μs 477ns 1.85μs 0 0 0 4.28 KB
#6500 EnrichedLog net472 150μs 77ns 298ns 0.672 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.14μs 0.931ns 3.48ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.38μs 2.55ns 9.55ns 0.0284 0 0 2.2 KB
master EnrichedLog net472 4.9μs 1.08ns 4.18ns 0.319 0 0 2.02 KB
#6500 EnrichedLog net6.0 2.91μs 1.29ns 5.01ns 0.0302 0 0 2.2 KB
#6500 EnrichedLog netcoreapp3.1 4.37μs 1.65ns 6.39ns 0.0293 0 0 2.2 KB
#6500 EnrichedLog net472 5.07μs 17ns 107ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.45μs 7.44ns 35.7ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 0.876ns 3.39ns 0.015 0 0 1.14 KB
master SendReceive net472 2.16μs 1.75ns 6.76ns 0.184 0 0 1.16 KB
#6500 SendReceive net6.0 1.44μs 0.698ns 2.7ns 0.0165 0 0 1.14 KB
#6500 SendReceive netcoreapp3.1 1.77μs 0.941ns 3.65ns 0.015 0 0 1.14 KB
#6500 SendReceive net472 2.14μs 1.68ns 6.5ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.75μs 1.1ns 4.1ns 0.0221 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.8μs 2.98ns 11.6ns 0.0209 0 0 1.65 KB
master EnrichedLog net472 4.37μs 3.08ns 11.9ns 0.322 0 0 2.04 KB
#6500 EnrichedLog net6.0 2.71μs 1.29ns 5ns 0.0215 0 0 1.6 KB
#6500 EnrichedLog netcoreapp3.1 3.99μs 1.22ns 4.73ns 0.0219 0 0 1.65 KB
#6500 EnrichedLog net472 4.44μs 3.55ns 13.7ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6500

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.162 477.14 554.48

Faster 🎉 in #6500

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.179 650.28 551.50
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.136 448.46 394.60

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 448ns 0.197ns 0.763ns 0.0081 0 0 576 B
master StartFinishSpan netcoreapp3.1 650ns 0.527ns 2.04ns 0.00796 0 0 576 B
master StartFinishSpan net472 650ns 0.353ns 1.37ns 0.0916 0 0 578 B
master StartFinishScope net6.0 477ns 0.196ns 0.761ns 0.00984 0 0 696 B
master StartFinishScope netcoreapp3.1 726ns 0.731ns 2.83ns 0.00942 0 0 696 B
master StartFinishScope net472 872ns 0.571ns 2.21ns 0.104 0 0 658 B
#6500 StartFinishSpan net6.0 395ns 0.288ns 1.11ns 0.00808 0 0 576 B
#6500 StartFinishSpan netcoreapp3.1 552ns 0.296ns 1.15ns 0.00775 0 0 576 B
#6500 StartFinishSpan net472 650ns 0.356ns 1.33ns 0.0915 0 0 578 B
#6500 StartFinishScope net6.0 554ns 0.278ns 1.08ns 0.00974 0 0 696 B
#6500 StartFinishScope netcoreapp3.1 731ns 0.663ns 2.48ns 0.00936 0 0 696 B
#6500 StartFinishScope net472 897ns 0.678ns 2.62ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 593ns 0.413ns 1.6ns 0.00985 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 911ns 0.47ns 1.82ns 0.00941 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.523ns 2.03ns 0.105 0 0 658 B
#6500 RunOnMethodBegin net6.0 587ns 0.417ns 1.62ns 0.00964 0 0 696 B
#6500 RunOnMethodBegin netcoreapp3.1 972ns 0.442ns 1.71ns 0.00931 0 0 696 B
#6500 RunOnMethodBegin net472 1.11μs 0.726ns 2.81ns 0.104 0 0 658 B

@e-n-0 e-n-0 merged commit af2669f into master Jan 6, 2025
101 of 103 checks passed
@e-n-0 e-n-0 deleted the flavien/asm/fix-master-aspects branch January 6, 2025 12:21
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 6, 2025
@andrewlock andrewlock mentioned this pull request Jan 6, 2025
Merged
andrewlock added a commit that referenced this pull request Jan 7, 2025
@andrewlock
Ensure analyzer tests run against all TFMs (#6502)
aa9cacd 
## Summary of changes

Removes the restriction to only running on .NET 5

## Reason for change

There's no good reason for it to be this, it's almost certainly copy
pasta

## Implementation details

Remove the restricting target

## Test coverage

The CI should reveal all...

## Other details

Revealed by
- #6500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

@andrewlock andrewlock andrewlock approved these changes

@robertpi robertpi robertpi approved these changes

Assignees
No one assigned
Labels
area:asm type:refactor
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@e-n-0 @andrewlock @robertpi @daniel-romano-DD