Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kevin/randomize tests 2 #6508

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Kevin/randomize tests 2 #6508

wants to merge 7 commits into from

Conversation

kevingosse
Copy link
Collaborator

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@andrewlock
Copy link
Member

andrewlock commented Jan 7, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6508) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6508) - mean (981ms)  : 958, 1004
     .   : milestone, 981,
    master - mean (980ms)  : 949, 1011
     .   : milestone, 980,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6508) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6508) - mean (675ms)  : 662, 689
     .   : milestone, 675,
    master - mean (681ms)  : 665, 697
     .   : milestone, 681,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6508) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6508) - mean (630ms)  : 610, 650
     .   : milestone, 630,
    master - mean (636ms)  : 618, 654
     .   : milestone, 636,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6508) - mean (194ms)  : 189, 198
     .   : milestone, 194,
    master - mean (195ms)  : 189, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (6508) - mean (1,101ms)  : 1078, 1124
     .   : milestone, 1101,
    master - mean (1,105ms)  : 1078, 1131
     .   : milestone, 1105,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6508) - mean (279ms)  : 275, 283
     .   : milestone, 279,
    master - mean (279ms)  : 275, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6508) - mean (872ms)  : 845, 900
     .   : milestone, 872,
    master - mean (875ms)  : 850, 900
     .   : milestone, 875,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6508) - mean (267ms)  : 264, 271
     .   : milestone, 267,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6508) - mean (846ms)  : 815, 877
     .   : milestone, 846,
    master - mean (853ms)  : 824, 881
     .   : milestone, 853,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 7, 2025 •
edited
Loading

Datadog Report

Branch report: kevin/randomize_tests_2
Commit report: 4190682
Test service: dd-trace-dotnet

❌ 2 Failed (0 Known Flaky), 584737 Passed, 4096 Skipped, 36h 18m 12.35s Total Time
❄️ 1 New Flaky

❌ Failed Tests (2)

  • EarlyFlakeDetection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.MsTestV2EvpTests - Details

    Expand for error 
     The sample did not exit in 600000ms. Memory dump taken: True. Killing process.

  • NoExceptions - Datadog.Trace.ClrProfiler.IntegrationTests.SmokeTests.AssemblyResolveMscorlibResourcesInfiniteRecursionCrashSmokeTest - Details

    Expand for error 
     Expected no errors in smoke test: ptrace(PTRACE_GETREGSET, 15754, NT_PRSTATUS) FAILED 3 (No such process)
 
 Expected: True
 Actual:   False

New Flaky Tests (1)

  • HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Last Failure

    Expand for error 
     
 Actual:   Falseave no remaining tags, but the following tags were found: ["http-client-handler-type"="Samples.HttpMessageHandler.CustomHandler"]essageHandler-http-client}

@andrewlock
Copy link
Member

andrewlock commented Jan 7, 2025 •
edited
Loading

Benchmarks Report for appsec 🐌

Benchmarks for #6508 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.256
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6508

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.256 200.12 251.45

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 205μs 125ns 468ns 2.65 0 0 188.76 KB
master AllCycleSimpleBody netcoreapp3.1 312μs 150ns 582ns 2.65 0 0 196.09 KB
master AllCycleSimpleBody net472 270μs 553ns 2.14μs 35.9 2.04 0 225.78 KB
master AllCycleMoreComplexBody net6.0 207μs 150ns 559ns 2.69 0 0 192.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 321μs 173ns 669ns 2.73 0 0 199.5 KB
master AllCycleMoreComplexBody net472 273μs 165ns 596ns 36.4 2.05 0 229.3 KB
master ObjectExtractorSimpleBody net6.0 140ns 0.167ns 0.647ns 0.00392 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 200ns 0.134ns 0.5ns 0.00375 0 0 272 B
master ObjectExtractorSimpleBody net472 166ns 0.132ns 0.511ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.89μs 1.68ns 6.3ns 0.0535 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.84μs 2.01ns 7.51ns 0.0504 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.62μs 5.1ns 19.8ns 0.603 0.00541 0 3.8 KB
#6508 AllCycleSimpleBody net6.0 205μs 73.2ns 264ns 2.66 0 0 188.76 KB
#6508 AllCycleSimpleBody netcoreapp3.1 308μs 107ns 387ns 2.61 0 0 196.09 KB
#6508 AllCycleSimpleBody net472 275μs 296ns 1.15μs 35.9 2.06 0 225.79 KB
#6508 AllCycleMoreComplexBody net6.0 212μs 120ns 466ns 2.64 0 0 192.26 KB
#6508 AllCycleMoreComplexBody netcoreapp3.1 318μs 58.9ns 220ns 2.7 0 0 199.51 KB
#6508 AllCycleMoreComplexBody net472 276μs 177ns 613ns 36.3 2.08 0 229.3 KB
#6508 ObjectExtractorSimpleBody net6.0 143ns 0.0916ns 0.33ns 0.00392 0 0 280 B
#6508 ObjectExtractorSimpleBody netcoreapp3.1 251ns 0.133ns 0.514ns 0.00373 0 0 272 B
#6508 ObjectExtractorSimpleBody net472 180ns 0.301ns 1.13ns 0.0446 0 0 281 B
#6508 ObjectExtractorMoreComplexBody net6.0 2.83μs 2.94ns 11.4ns 0.0534 0 0 3.78 KB
#6508 ObjectExtractorMoreComplexBody netcoreapp3.1 3.8μs 1.81ns 7.01ns 0.0492 0 0 3.69 KB
#6508 ObjectExtractorMoreComplexBody net472 3.69μs 5.76ns 22.3ns 0.603 0.00553 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37.9μs 30.9ns 120ns 0.457 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 54.4μs 38.1ns 147ns 0.433 0 0 32.4 KB
master EncodeArgs net472 67.5μs 55.1ns 199ns 5.14 0.0671 0 32.5 KB
master EncodeLegacyArgs net6.0 73.9μs 73.2ns 274ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 104μs 68.8ns 266ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 156μs 55ns 213ns 0.311 0 0 2.15 KB
#6508 EncodeArgs net6.0 36.6μs 31.1ns 112ns 0.459 0 0 32.4 KB
#6508 EncodeArgs netcoreapp3.1 53.8μs 33.2ns 124ns 0.428 0 0 32.4 KB
#6508 EncodeArgs net472 65.9μs 65.8ns 246ns 5.16 0.0658 0 32.5 KB
#6508 EncodeLegacyArgs net6.0 77μs 218ns 846ns 0 0 0 2.14 KB
#6508 EncodeLegacyArgs netcoreapp3.1 106μs 104ns 405ns 0 0 0 2.14 KB
#6508 EncodeLegacyArgs net472 154μs 85.1ns 318ns 0.308 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 175μs 119ns 462ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 189μs 146ns 567ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 202μs 116ns 449ns 0.302 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 117μs 42.2ns 158ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 124μs 168ns 650ns 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 133μs 60.1ns 233ns 0.199 0 0 1.49 KB
#6508 RunWafRealisticBenchmark net6.0 176μs 53.1ns 206ns 0 0 0 2.44 KB
#6508 RunWafRealisticBenchmark netcoreapp3.1 185μs 400ns 1.55μs 0 0 0 2.39 KB
#6508 RunWafRealisticBenchmark net472 200μs 74.8ns 280ns 0.3 0 0 2.46 KB
#6508 RunWafRealisticBenchmarkWithAttack net6.0 115μs 56.9ns 213ns 0 0 0 1.47 KB
#6508 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 124μs 63.4ns 237ns 0 0 0 1.46 KB
#6508 RunWafRealisticBenchmarkWithAttack net472 133μs 45.1ns 169ns 0.199 0 0 1.49 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6508

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 255.81 KB 258.33 KB 2.52 KB 0.99%

Fewer allocations 🎉 in #6508

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 282.36 KB 278.53 KB -3.83 KB -1.36%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 57.9μs 793ns 7.85μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.7μs 258ns 1.06μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.2μs 174ns 673ns 0 0 0 59.18 KB
master StringConcatAspectBenchmark net6.0 309μs 1.59μs 8.42μs 0 0 0 255.81 KB
master StringConcatAspectBenchmark netcoreapp3.1 360μs 1.98μs 14.6μs 0 0 0 262.71 KB
master StringConcatAspectBenchmark net472 244μs 1.24μs 5.68μs 0 0 0 282.36 KB
#6508 StringConcatBenchmark net6.0 59μs 658ns 6.51μs 0 0 0 43.44 KB
#6508 StringConcatBenchmark netcoreapp3.1 59.2μs 834ns 8.26μs 0 0 0 42.64 KB
#6508 StringConcatBenchmark net472 37.8μs 72.3ns 271ns 0 0 0 59.26 KB
#6508 StringConcatAspectBenchmark net6.0 300μs 6.22μs 61.6μs 0 0 0 258.33 KB
#6508 StringConcatAspectBenchmark netcoreapp3.1 350μs 2.01μs 16.4μs 0 0 0 261.46 KB
#6508 StringConcatAspectBenchmark net472 280μs 6.22μs 60μs 0 0 0 278.53 KB

@andrewlock
Copy link
Member

andrewlock commented Jan 7, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6508 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.128
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.11μs 46.2ns 349ns 0.0164 0.00822 0 5.61 KB
master StartStopWithChild netcoreapp3.1 9.96μs 50.5ns 237ns 0.0148 0.00495 0 5.8 KB
master StartStopWithChild net472 16.3μs 55.5ns 208ns 1.05 0.322 0.105 6.21 KB
#6508 StartStopWithChild net6.0 7.82μs 44.3ns 319ns 0.0113 0.00376 0 5.61 KB
#6508 StartStopWithChild netcoreapp3.1 10.2μs 55.6ns 329ns 0.0201 0.01 0 5.8 KB
#6508 StartStopWithChild net472 16.4μs 41.1ns 148ns 1.06 0.33 0.105 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 487μs 241ns 935ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 332ns 1.24μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 853μs 601ns 2.33μs 0.425 0 0 3.3 KB
#6508 WriteAndFlushEnrichedTraces net6.0 477μs 297ns 1.11μs 0 0 0 2.7 KB
#6508 WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 558ns 2.09μs 0 0 0 2.7 KB
#6508 WriteAndFlushEnrichedTraces net472 863μs 842ns 3.15μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 153μs 895ns 8.34μs 0.16 0 0 14.47 KB
master SendRequest netcoreapp3.1 178μs 1.04μs 10μs 0.162 0 0 17.27 KB
master SendRequest net472 0.000262ns 0.000262ns 0.00101ns 0 0 0 0 b
#6508 SendRequest net6.0 154μs 909ns 8.76μs 0.144 0 0 14.47 KB
#6508 SendRequest netcoreapp3.1 177μs 1.14μs 11.2μs 0.178 0 0 17.27 KB
#6508 SendRequest net472 0.00272ns 0.00098ns 0.0038ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 559μs 2.9μs 13.9μs 0.541 0 0 41.69 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 694μs 3.1μs 12μs 0.342 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 856μs 4.63μs 24.9μs 8.39 2.52 0.419 53.27 KB
#6508 WriteAndFlushEnrichedTraces net6.0 569μs 2.98μs 14μs 0.551 0 0 41.62 KB
#6508 WriteAndFlushEnrichedTraces netcoreapp3.1 669μs 3.73μs 22.4μs 0.334 0 0 41.81 KB
#6508 WriteAndFlushEnrichedTraces net472 825μs 3.47μs 13.5μs 8.45 2.53 0.422 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.34μs 0.919ns 3.56ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.59ns 6.16ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 1.96μs 2.56ns 9.92ns 0.156 0.000971 0 987 B
#6508 ExecuteNonQuery net6.0 1.35μs 1.57ns 6.07ns 0.0142 0 0 1.02 KB
#6508 ExecuteNonQuery netcoreapp3.1 1.79μs 2.11ns 8.17ns 0.0134 0 0 1.02 KB
#6508 ExecuteNonQuery net472 2.06μs 3.31ns 12.8ns 0.156 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 1.07ns 4.13ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.48μs 0.676ns 2.44ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.51μs 1.09ns 3.92ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.497ns 1.92ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.86μs 0.538ns 2.01ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 0.554ns 1.92ns 0.167 0 0 1.05 KB
#6508 CallElasticsearch net6.0 1.26μs 0.797ns 2.98ns 0.0133 0 0 976 B
#6508 CallElasticsearch netcoreapp3.1 1.55μs 0.714ns 2.77ns 0.0133 0 0 976 B
#6508 CallElasticsearch net472 2.59μs 2.38ns 9.21ns 0.157 0 0 995 B
#6508 CallElasticsearchAsync net6.0 1.28μs 1.42ns 5.49ns 0.0134 0 0 952 B
#6508 CallElasticsearchAsync netcoreapp3.1 1.7μs 0.355ns 1.33ns 0.0139 0 0 1.02 KB
#6508 CallElasticsearchAsync net472 2.68μs 0.792ns 2.97ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.564ns 2.19ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 0.656ns 2.54ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.77μs 0.614ns 2.3ns 0.145 0 0 915 B
#6508 ExecuteAsync net6.0 1.21μs 0.546ns 2.04ns 0.0133 0 0 952 B
#6508 ExecuteAsync netcoreapp3.1 1.63μs 1.16ns 4.32ns 0.013 0 0 952 B
#6508 ExecuteAsync net472 1.8μs 2.06ns 7.43ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.47μs 1.29ns 4.82ns 0.0333 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.33μs 1.63ns 5.87ns 0.0375 0 0 2.85 KB
master SendAsync net472 7.5μs 2.31ns 8.94ns 0.495 0 0 3.12 KB
#6508 SendAsync net6.0 4.38μs 2.15ns 8.03ns 0.0327 0 0 2.31 KB
#6508 SendAsync netcoreapp3.1 5.46μs 2.36ns 8.84ns 0.0381 0 0 2.85 KB
#6508 SendAsync net472 7.42μs 2.54ns 9.83ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.83ns 3.1ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.2μs 1.65ns 6.4ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.83μs 1.81ns 6.77ns 0.249 0 0 1.57 KB
#6508 EnrichedLog net6.0 1.47μs 0.448ns 1.68ns 0.0229 0 0 1.64 KB
#6508 EnrichedLog netcoreapp3.1 2.12μs 3.45ns 12.9ns 0.0221 0 0 1.64 KB
#6508 EnrichedLog net472 2.74μs 1.1ns 4.24ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 275ns 1.06μs 0.0588 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 128ns 497ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 186ns 720ns 0.684 0.228 0 4.46 KB
#6508 EnrichedLog net6.0 116μs 156ns 584ns 0.0582 0 0 4.28 KB
#6508 EnrichedLog netcoreapp3.1 123μs 345ns 1.34μs 0.0605 0 0 4.28 KB
#6508 EnrichedLog net472 151μs 195ns 729ns 0.675 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 0.845ns 3.27ns 0.0306 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.38μs 1.53ns 5.91ns 0.0286 0 0 2.2 KB
master EnrichedLog net472 4.9μs 1.53ns 5.92ns 0.319 0 0 2.02 KB
#6508 EnrichedLog net6.0 3.05μs 1.87ns 7.23ns 0.0301 0 0 2.2 KB
#6508 EnrichedLog netcoreapp3.1 4.25μs 1.46ns 5.45ns 0.0298 0 0 2.2 KB
#6508 EnrichedLog net472 5.01μs 1.72ns 6.67ns 0.318 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 0.866ns 3.35ns 0.0165 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.82μs 0.588ns 2.28ns 0.0154 0 0 1.14 KB
master SendReceive net472 2.13μs 1.61ns 6.22ns 0.183 0 0 1.16 KB
#6508 SendReceive net6.0 1.4μs 0.814ns 2.93ns 0.016 0 0 1.14 KB
#6508 SendReceive netcoreapp3.1 1.79μs 1.02ns 3.69ns 0.0151 0 0 1.14 KB
#6508 SendReceive net472 2.12μs 1.27ns 4.94ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 1.05ns 4.05ns 0.0222 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.68μs 5.19ns 20.1ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.34μs 2.8ns 10.9ns 0.323 0 0 2.04 KB
#6508 EnrichedLog net6.0 2.58μs 0.699ns 2.71ns 0.022 0 0 1.6 KB
#6508 EnrichedLog netcoreapp3.1 3.84μs 2.63ns 10.2ns 0.0229 0 0 1.65 KB
#6508 EnrichedLog net472 4.47μs 1.8ns 6.5ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6508

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.128 402.73 454.27

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 403ns 0.158ns 0.612ns 0.00809 0 0 576 B
master StartFinishSpan netcoreapp3.1 596ns 0.347ns 1.34ns 0.0077 0 0 576 B
master StartFinishSpan net472 708ns 0.276ns 1.07ns 0.0917 0 0 578 B
master StartFinishScope net6.0 544ns 0.208ns 0.778ns 0.00982 0 0 696 B
master StartFinishScope netcoreapp3.1 716ns 1.64ns 6.34ns 0.00925 0 0 696 B
master StartFinishScope net472 791ns 0.258ns 0.967ns 0.104 0 0 658 B
#6508 StartFinishSpan net6.0 455ns 0.212ns 0.819ns 0.00799 0 0 576 B
#6508 StartFinishSpan netcoreapp3.1 563ns 0.342ns 1.32ns 0.00783 0 0 576 B
#6508 StartFinishSpan net472 650ns 0.34ns 1.27ns 0.0917 0 0 578 B
#6508 StartFinishScope net6.0 513ns 0.179ns 0.647ns 0.00984 0 0 696 B
#6508 StartFinishScope netcoreapp3.1 728ns 0.248ns 0.959ns 0.00961 0 0 696 B
#6508 StartFinishScope net472 869ns 0.502ns 1.95ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 673ns 0.413ns 1.6ns 0.0098 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 896ns 0.569ns 2.13ns 0.00951 0 0 696 B
master RunOnMethodBegin net472 1.11μs 0.346ns 1.34ns 0.104 0 0 658 B
#6508 RunOnMethodBegin net6.0 690ns 0.321ns 1.24ns 0.00971 0 0 696 B
#6508 RunOnMethodBegin netcoreapp3.1 847ns 0.823ns 3.08ns 0.00924 0 0 696 B
#6508 RunOnMethodBegin net472 1.14μs 0.213ns 0.824ns 0.104 0 0 658 B

@kevingosse kevingosse force-pushed the kevin/randomize_tests_2 branch from 16a32e6 to ea37a8e Compare January 8, 2025 13:12
@kevingosse kevingosse force-pushed the kevin/randomize_tests_2 branch from ea37a8e to aa88b9f Compare January 8, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevingosse @andrewlock