Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] Restore SqlConnection _dbConnectionSystemDataSqlClient #6515

Closed
wants to merge 1 commit into from
Closed

[ASM] Restore SqlConnection _dbConnectionSystemDataSqlClient #6515

wants to merge 1 commit into from

Conversation

NachoEchevarria
Copy link
Contributor

Summary of changes

It seems that there has been some PR conflict between this PR and this one that have caused a compilation error in Samples.Security.AspNetCore5. Just restoring the missing line will fix it.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:builds project files, build scripts, pipelines, versioning, releases, packages area:docs area:tests unit tests, integration tests area:opentracing area:installers area:vendors Code from other vendors area:shared-components area:profiler Issues related to the continous-profiler area:asm area:debugger area:integrations labels Jan 8, 2025
@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6515) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6515) - mean (976ms)  : 952, 1000
     .   : milestone, 976,
    master - mean (981ms)  : 954, 1008
     .   : milestone, 981,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6515) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6515) - mean (677ms)  : 659, 696
     .   : milestone, 677,
    master - mean (678ms)  : 662, 695
     .   : milestone, 678,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6515) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6515) - mean (635ms)  : 618, 651
     .   : milestone, 635,
    master - mean (633ms)  : 616, 651
     .   : milestone, 633,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6515) - mean (194ms)  : 189, 198
     .   : milestone, 194,
    master - mean (195ms)  : 189, 202
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (6515) - mean (1,106ms)  : 1078, 1135
     .   : milestone, 1106,
    master - mean (1,104ms)  : 1076, 1132
     .   : milestone, 1104,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6515) - mean (279ms)  : 274, 283
     .   : milestone, 279,
    master - mean (278ms)  : 273, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6515) - mean (871ms)  : 844, 898
     .   : milestone, 871,
    master - mean (874ms)  : 847, 901
     .   : milestone, 874,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6515) - mean (268ms)  : 264, 273
     .   : milestone, 268,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6515) - mean (861ms)  : 826, 895
     .   : milestone, 861,
    master - mean (857ms)  : 829, 885
     .   : milestone, 857,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for appsec 🐌

Benchmarks for #6515 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.129
  • 1 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6515

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net6.0 1.129 160.62 142.23

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 202μs 169ns 655ns 2.61 0 0 188.76 KB
master AllCycleSimpleBody netcoreapp3.1 299μs 200ns 773ns 2.68 0 0 196.09 KB
master AllCycleSimpleBody net472 273μs 118ns 441ns 35.8 2.05 0 225.79 KB
master AllCycleMoreComplexBody net6.0 209μs 123ns 459ns 2.72 0 0 192.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 317μs 139ns 520ns 2.68 0 0 199.5 KB
master AllCycleMoreComplexBody net472 278μs 174ns 674ns 36.4 2.08 0 229.3 KB
master ObjectExtractorSimpleBody net6.0 161ns 0.13ns 0.486ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 195ns 0.139ns 0.52ns 0.00373 0 0 272 B
master ObjectExtractorSimpleBody net472 168ns 0.0874ns 0.338ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.91μs 1.13ns 4.07ns 0.0524 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.76μs 3.16ns 11.8ns 0.0488 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.63μs 2.34ns 8.75ns 0.603 0.00722 0 3.8 KB
#6515 AllCycleSimpleBody net6.0 204μs 123ns 460ns 2.66 0 0 188.76 KB
#6515 AllCycleSimpleBody netcoreapp3.1 303μs 312ns 1.17μs 2.72 0 0 196.09 KB
#6515 AllCycleSimpleBody net472 271μs 349ns 1.3μs 35.8 2.03 0 225.78 KB
#6515 AllCycleMoreComplexBody net6.0 212μs 108ns 404ns 2.66 0 0 192.26 KB
#6515 AllCycleMoreComplexBody netcoreapp3.1 314μs 106ns 396ns 2.67 0 0 199.51 KB
#6515 AllCycleMoreComplexBody net472 276μs 178ns 666ns 36.4 2.07 0 229.3 KB
#6515 ObjectExtractorSimpleBody net6.0 142ns 0.169ns 0.654ns 0.00397 0 0 280 B
#6515 ObjectExtractorSimpleBody netcoreapp3.1 191ns 0.155ns 0.559ns 0.00374 0 0 272 B
#6515 ObjectExtractorSimpleBody net472 167ns 0.083ns 0.299ns 0.0446 0 0 281 B
#6515 ObjectExtractorMoreComplexBody net6.0 2.89μs 2.16ns 8.36ns 0.0534 0 0 3.78 KB
#6515 ObjectExtractorMoreComplexBody netcoreapp3.1 3.78μs 2.71ns 10.1ns 0.0494 0 0 3.69 KB
#6515 ObjectExtractorMoreComplexBody net472 3.64μs 2.94ns 11ns 0.602 0.00552 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 36.7μs 26.7ns 104ns 0.457 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 55.2μs 33.8ns 131ns 0.412 0 0 32.4 KB
master EncodeArgs net472 67.9μs 47.8ns 179ns 5.15 0.0678 0 32.5 KB
master EncodeLegacyArgs net6.0 74.4μs 22.5ns 84.3ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 105μs 155ns 602ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 156μs 56.3ns 218ns 0.312 0 0 2.15 KB
#6515 EncodeArgs net6.0 37μs 21.6ns 77.8ns 0.46 0 0 32.4 KB
#6515 EncodeArgs netcoreapp3.1 54.1μs 27.1ns 105ns 0.431 0 0 32.4 KB
#6515 EncodeArgs net472 66.3μs 32.3ns 117ns 5.15 0.0664 0 32.5 KB
#6515 EncodeLegacyArgs net6.0 72.2μs 45.2ns 175ns 0 0 0 2.14 KB
#6515 EncodeLegacyArgs netcoreapp3.1 109μs 371ns 1.44μs 0 0 0 2.14 KB
#6515 EncodeLegacyArgs net472 154μs 79.4ns 307ns 0.309 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 174μs 90.3ns 338ns 0 0 0 2.44 KB
master RunWafRealisticBenchmark netcoreapp3.1 187μs 225ns 812ns 0 0 0 2.39 KB
master RunWafRealisticBenchmark net472 199μs 119ns 462ns 0.3 0 0 2.46 KB
master RunWafRealisticBenchmarkWithAttack net6.0 114μs 65.1ns 252ns 0 0 0 1.47 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 124μs 279ns 1.08μs 0 0 0 1.46 KB
master RunWafRealisticBenchmarkWithAttack net472 132μs 51.1ns 198ns 0.198 0 0 1.49 KB
#6515 RunWafRealisticBenchmark net6.0 177μs 162ns 627ns 0 0 0 2.44 KB
#6515 RunWafRealisticBenchmark netcoreapp3.1 187μs 79.3ns 307ns 0 0 0 2.39 KB
#6515 RunWafRealisticBenchmark net472 201μs 47.2ns 177ns 0.3 0 0 2.46 KB
#6515 RunWafRealisticBenchmarkWithAttack net6.0 116μs 83.4ns 323ns 0 0 0 1.47 KB
#6515 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 123μs 226ns 875ns 0 0 0 1.46 KB
#6515 RunWafRealisticBenchmarkWithAttack net472 133μs 43.4ns 168ns 0.199 0 0 1.48 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6515

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 276.42 KB 278.53 KB 2.11 KB 0.76%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 61.73 KB 62.04 KB 312 B 0.51%

Fewer allocations 🎉 in #6515

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 262.87 KB 254.5 KB -8.38 KB -3.19%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 60μs 755ns 7.55μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.2μs 243ns 1.09μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.5μs 111ns 416ns 0 0 0 61.73 KB
master StringConcatAspectBenchmark net6.0 321μs 1.8μs 11.7μs 0 0 0 255.18 KB
master StringConcatAspectBenchmark netcoreapp3.1 340μs 1.87μs 11.4μs 0 0 0 262.87 KB
master StringConcatAspectBenchmark net472 269μs 5.16μs 49.2μs 0 0 0 276.42 KB
#6515 StringConcatBenchmark net6.0 60.2μs 801ns 7.84μs 0 0 0 43.44 KB
#6515 StringConcatBenchmark netcoreapp3.1 53.8μs 290ns 1.45μs 0 0 0 42.64 KB
#6515 StringConcatBenchmark net472 37.6μs 94.8ns 355ns 0 0 0 62.04 KB
#6515 StringConcatAspectBenchmark net6.0 319μs 1.8μs 11.4μs 0 0 0 254.63 KB
#6515 StringConcatAspectBenchmark netcoreapp3.1 346μs 1.9μs 11.8μs 0 0 0 254.5 KB
#6515 StringConcatAspectBenchmark net472 275μs 5.8μs 56.2μs 0 0 0 278.53 KB

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6515 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.184
  • 2 benchmarks are slower, with geometric mean 1.123
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.83μs 42.8ns 239ns 0.0158 0.00789 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10μs 56ns 354ns 0.0147 0 0 5.81 KB
master StartStopWithChild net472 16.4μs 44.2ns 171ns 1.03 0.307 0.097 6.2 KB
#6515 StartStopWithChild net6.0 7.89μs 41.3ns 198ns 0.0149 0.00743 0 5.61 KB
#6515 StartStopWithChild netcoreapp3.1 9.93μs 49.9ns 264ns 0.0241 0.00962 0 5.8 KB
#6515 StartStopWithChild net472 16.1μs 43.5ns 168ns 1.06 0.33 0.107 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 481μs 398ns 1.49μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 686ns 2.66μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 856μs 380ns 1.37μs 0.425 0 0 3.3 KB
#6515 WriteAndFlushEnrichedTraces net6.0 475μs 441ns 1.65μs 0 0 0 2.7 KB
#6515 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 579ns 2.17μs 0 0 0 2.7 KB
#6515 WriteAndFlushEnrichedTraces net472 857μs 525ns 2.03μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 151μs 852ns 7.13μs 0.145 0 0 14.47 KB
master SendRequest netcoreapp3.1 172μs 980ns 7.4μs 0.17 0 0 17.27 KB
master SendRequest net472 0.0398ns 0.00814ns 0.0315ns 0 0 0 0 b
#6515 SendRequest net6.0 154μs 889ns 7.38μs 0.157 0 0 14.47 KB
#6515 SendRequest netcoreapp3.1 175μs 1.12μs 11.2μs 0.191 0 0 17.27 KB
#6515 SendRequest net472 0.00462ns 0.00244ns 0.00845ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 547μs 2.09μs 7.54μs 0.556 0 0 41.65 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 687μs 3.99μs 34.5μs 0.332 0 0 41.69 KB
master WriteAndFlushEnrichedTraces net472 885μs 2.2μs 7.63μs 8.13 2.57 0.428 53.31 KB
#6515 WriteAndFlushEnrichedTraces net6.0 619μs 3.61μs 32.7μs 0.59 0 0 41.47 KB
#6515 WriteAndFlushEnrichedTraces netcoreapp3.1 706μs 4.11μs 35.6μs 0.327 0 0 41.77 KB
#6515 WriteAndFlushEnrichedTraces net472 839μs 3.2μs 12μs 8.45 2.53 0.422 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.27μs 0.677ns 2.53ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.8μs 1.47ns 5.69ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 2.04μs 2.41ns 9.34ns 0.156 0.00102 0 987 B
#6515 ExecuteNonQuery net6.0 1.38μs 0.796ns 3.08ns 0.0145 0 0 1.02 KB
#6515 ExecuteNonQuery netcoreapp3.1 1.8μs 2.49ns 9.65ns 0.0136 0 0 1.02 KB
#6515 ExecuteNonQuery net472 2.1μs 1.59ns 5.96ns 0.156 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.19μs 0.339ns 1.17ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.69μs 3.35ns 12.5ns 0.0134 0 0 976 B
master CallElasticsearch net472 2.54μs 2.27ns 8.79ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 1.39ns 5.38ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.63μs 1.08ns 3.9ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 2.03ns 7.87ns 0.167 0 0 1.05 KB
#6515 CallElasticsearch net6.0 1.27μs 0.802ns 3ns 0.0134 0 0 976 B
#6515 CallElasticsearch netcoreapp3.1 1.57μs 1.56ns 5.84ns 0.0126 0 0 976 B
#6515 CallElasticsearch net472 2.55μs 4.17ns 15.6ns 0.157 0 0 995 B
#6515 CallElasticsearchAsync net6.0 1.23μs 0.639ns 2.48ns 0.0135 0 0 952 B
#6515 CallElasticsearchAsync netcoreapp3.1 1.69μs 0.89ns 3.45ns 0.0135 0 0 1.02 KB
#6515 CallElasticsearchAsync net472 2.58μs 1.52ns 5.5ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.35μs 0.648ns 2.42ns 0.0136 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.67μs 0.646ns 2.42ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.84μs 0.642ns 2.48ns 0.145 0 0 915 B
#6515 ExecuteAsync net6.0 1.38μs 0.574ns 2.15ns 0.0132 0 0 952 B
#6515 ExecuteAsync netcoreapp3.1 1.63μs 2.2ns 8.51ns 0.013 0 0 952 B
#6515 ExecuteAsync net472 1.8μs 0.707ns 2.64ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.31μs 1.98ns 7.4ns 0.0323 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.44μs 2.08ns 8.07ns 0.0382 0 0 2.85 KB
master SendAsync net472 7.38μs 1.63ns 6.32ns 0.494 0 0 3.12 KB
#6515 SendAsync net6.0 4.45μs 1.58ns 5.92ns 0.0312 0 0 2.31 KB
#6515 SendAsync netcoreapp3.1 5.32μs 1.5ns 5.19ns 0.0373 0 0 2.85 KB
#6515 SendAsync net472 7.4μs 1.44ns 5.21ns 0.496 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.53μs 1.07ns 3.99ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.36μs 1.16ns 4.35ns 0.0225 0 0 1.64 KB
master EnrichedLog net472 2.68μs 1.87ns 7.01ns 0.25 0 0 1.57 KB
#6515 EnrichedLog net6.0 1.46μs 0.439ns 1.7ns 0.0227 0 0 1.64 KB
#6515 EnrichedLog netcoreapp3.1 2.14μs 1.07ns 4.01ns 0.0214 0 0 1.64 KB
#6515 EnrichedLog net472 2.83μs 1.73ns 6.49ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 312ns 1.21μs 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 86.8ns 313ns 0 0 0 4.28 KB
master EnrichedLog net472 150μs 148ns 574ns 0.675 0.225 0 4.46 KB
#6515 EnrichedLog net6.0 119μs 206ns 772ns 0 0 0 4.28 KB
#6515 EnrichedLog netcoreapp3.1 122μs 261ns 1.01μs 0 0 0 4.28 KB
#6515 EnrichedLog net472 153μs 103ns 399ns 0.688 0.229 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.04μs 0.665ns 2.49ns 0.0304 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.38μs 1.88ns 7.27ns 0.0284 0 0 2.2 KB
master EnrichedLog net472 4.95μs 1.27ns 4.91ns 0.319 0 0 2.02 KB
#6515 EnrichedLog net6.0 2.91μs 1.12ns 4.34ns 0.0306 0 0 2.2 KB
#6515 EnrichedLog netcoreapp3.1 4.15μs 1.33ns 5.15ns 0.0291 0 0 2.2 KB
#6515 EnrichedLog net472 4.89μs 1.91ns 7.15ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.39μs 0.803ns 3.11ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.76μs 2.26ns 8.75ns 0.0157 0 0 1.14 KB
master SendReceive net472 2.11μs 1.55ns 5.99ns 0.183 0 0 1.16 KB
#6515 SendReceive net6.0 1.42μs 1.04ns 4.04ns 0.0156 0 0 1.14 KB
#6515 SendReceive netcoreapp3.1 1.77μs 0.546ns 2.11ns 0.015 0 0 1.14 KB
#6515 SendReceive net472 2.21μs 9.9ns 37.1ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 0.903ns 3.5ns 0.0214 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.98μs 1.21ns 4.37ns 0.0219 0 0 1.65 KB
master EnrichedLog net472 4.44μs 3.37ns 13ns 0.322 0 0 2.04 KB
#6515 EnrichedLog net6.0 2.72μs 3.57ns 13.8ns 0.0218 0 0 1.6 KB
#6515 EnrichedLog netcoreapp3.1 4.07μs 1.63ns 6.31ns 0.0222 0 0 1.65 KB
#6515 EnrichedLog net472 4.35μs 3.22ns 12.5ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6515

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.127 396.54 446.73
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.119 546.16 610.95

Faster 🎉 in #6515

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.184 796.60 672.92

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 397ns 0.636ns 2.46ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 546ns 0.881ns 3.41ns 0.00786 0 0 576 B
master StartFinishSpan net472 731ns 2.25ns 8.7ns 0.0917 0 0 578 B
master StartFinishScope net6.0 551ns 1.01ns 3.9ns 0.00975 0 0 696 B
master StartFinishScope netcoreapp3.1 797ns 1.39ns 5.39ns 0.0094 0 0 696 B
master StartFinishScope net472 859ns 0.867ns 3.36ns 0.104 0 0 658 B
#6515 StartFinishSpan net6.0 446ns 1.1ns 4.28ns 0.00814 0 0 576 B
#6515 StartFinishSpan netcoreapp3.1 612ns 1.18ns 4.57ns 0.00764 0 0 576 B
#6515 StartFinishSpan net472 667ns 1.25ns 4.84ns 0.0915 0 0 578 B
#6515 StartFinishScope net6.0 548ns 0.861ns 3.33ns 0.00965 0 0 696 B
#6515 StartFinishScope netcoreapp3.1 673ns 0.569ns 2.2ns 0.00936 0 0 696 B
#6515 StartFinishScope net472 861ns 0.639ns 2.48ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 644ns 1.2ns 4.66ns 0.00959 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 985ns 3.19ns 12.4ns 0.00922 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.45ns 5.62ns 0.105 0 0 658 B
#6515 RunOnMethodBegin net6.0 683ns 0.278ns 1.08ns 0.00989 0 0 696 B
#6515 RunOnMethodBegin netcoreapp3.1 930ns 0.74ns 2.87ns 0.00936 0 0 696 B
#6515 RunOnMethodBegin net472 1.18μs 0.681ns 2.64ns 0.104 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:asm area:builds project files, build scripts, pipelines, versioning, releases, packages area:debugger area:docs area:installers area:integrations area:opentracing area:profiler Issues related to the continous-profiler area:shared-components area:tests unit tests, integration tests area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:vendors Code from other vendors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEchevarria @andrewlock