Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact ##vso in CI #6525

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Redact ##vso in CI #6525

merged 1 commit into from
Jan 10, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Redact ##vso from being printed when we write test method arguments

Reason for change

When printed to the console, this signifies a "command" which confuses azdo:

##[warning]'11:09:46 [DBG] [xUnit.net 00:00:02.05] Datadog.Trace.Tools.Runner.IntegrationTests: STARTED: Datadog.Trace.Tools.Runner.IntegrationTests.ConfigureCiCommandTests.ConfigureCi(azp, ##vso\[task.setvariable variable=(?<name>[A-Z1-9_]+);\](?<value>.*), null)' contains logging command keyword '##vso', but it's not a legal command. Please see the list of accepted commands: https://go.microsoft.com/fwlink/?LinkId=817296

Implementation details

Just replace ##vso with #####

Test coverage

Meh

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 10, 2025
@andrewlock andrewlock requested a review from a team as a code owner January 10, 2025 11:32
@github-actions github-actions bot added the area:tests unit tests, integration tests label Jan 10, 2025
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 10, 2025

Datadog Report

Branch report: andrew/ci/filter-ci-args
Commit report: d82b073
Test service: dd-trace-dotnet

✅ 0 Failed, 242496 Passed, 2091 Skipped, 18h 35m 38.78s Total Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6525) - mean (69ms)  : 65, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6525) - mean (982ms)  : 952, 1011
     .   : milestone, 982,
    master - mean (980ms)  : 955, 1005
     .   : milestone, 980,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6525) - mean (107ms)  : 104, 110
     .   : milestone, 107,
    master - mean (107ms)  : 106, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6525) - mean (677ms)  : 662, 693
     .   : milestone, 677,
    master - mean (678ms)  : 662, 693
     .   : milestone, 678,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6525) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6525) - mean (634ms)  : 618, 651
     .   : milestone, 634,
    master - mean (639ms)  : 624, 655
     .   : milestone, 639,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6525) - mean (194ms)  : 189, 199
     .   : milestone, 194,
    master - mean (195ms)  : 190, 200
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (6525) - mean (1,108ms)  : 1074, 1143
     .   : milestone, 1108,
    master - mean (1,107ms)  : 1079, 1136
     .   : milestone, 1107,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6525) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (281ms)  : 276, 286
     .   : milestone, 281,

    section CallTarget+Inlining+NGEN
    This PR (6525) - mean (873ms)  : 849, 896
     .   : milestone, 873,
    master - mean (878ms)  : 850, 906
     .   : milestone, 878,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6525) - mean (267ms)  : 263, 272
     .   : milestone, 267,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6525) - mean (853ms)  : 815, 892
     .   : milestone, 853,
    master - mean (855ms)  : 820, 891
     .   : milestone, 855,

Loading

@andrewlock andrewlock merged commit a0d1454 into master Jan 10, 2025
121 of 124 checks passed
@andrewlock andrewlock deleted the andrew/ci/filter-ci-args branch January 10, 2025 13:48
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants