-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Microsoft.Azure.Functions.Worker.Extensions.Http from 3.0.12 to 3.2.0 in /tracer/test/test-applications/azure-functions/Samples.AzureFunctions.V4Isolated #6533
base: master
Are you sure you want to change the base?
Conversation
Bumps [Microsoft.Azure.Functions.Worker.Extensions.Http](https://github.com/Azure/azure-functions-dotnet-worker) from 3.0.12 to 3.2.0. - [Release notes](https://github.com/Azure/azure-functions-dotnet-worker/releases) - [Changelog](https://github.com/Azure/azure-functions-dotnet-worker/blob/main/release_notes.md) - [Commits](https://github.com/Azure/azure-functions-dotnet-worker/commits/http-extension-3.2.0) --- updated-dependencies: - dependency-name: Microsoft.Azure.Functions.Worker.Extensions.Http dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 239361 Passed, 1992 Skipped, 18h 28m 43.42s Total Time ❌ Failed Tests (1)
⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6533) - mean (68ms) : 66, 71
. : milestone, 68,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (6533) - mean (980ms) : 956, 1003
. : milestone, 980,
master - mean (975ms) : 946, 1003
. : milestone, 975,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6533) - mean (108ms) : 105, 110
. : milestone, 108,
master - mean (107ms) : 105, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (6533) - mean (680ms) : 666, 695
. : milestone, 680,
master - mean (677ms) : 661, 694
. : milestone, 677,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6533) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (90ms) : 89, 92
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (6533) - mean (634ms) : 618, 650
. : milestone, 634,
master - mean (630ms) : 615, 646
. : milestone, 630,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6533) - mean (194ms) : 190, 198
. : milestone, 194,
master - mean (194ms) : 189, 199
. : milestone, 194,
section CallTarget+Inlining+NGEN
This PR (6533) - mean (1,105ms) : 1081, 1128
. : milestone, 1105,
master - mean (1,104ms) : 1073, 1135
. : milestone, 1104,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6533) - mean (279ms) : 275, 283
. : milestone, 279,
master - mean (280ms) : 273, 286
. : milestone, 280,
section CallTarget+Inlining+NGEN
This PR (6533) - mean (876ms) : 838, 915
. : milestone, 876,
master - mean (869ms) : 842, 896
. : milestone, 869,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6533) - mean (268ms) : 264, 271
. : milestone, 268,
master - mean (267ms) : 262, 271
. : milestone, 267,
section CallTarget+Inlining+NGEN
This PR (6533) - mean (855ms) : 820, 890
. : milestone, 855,
master - mean (853ms) : 825, 880
. : milestone, 853,
|
Benchmarks Report for tracer 🐌Benchmarks for #6533 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.137 | 1,199.12 | 1,362.83 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.2μs | 1.1ns | 4.28ns | 0.0132 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.75μs | 0.511ns | 1.84ns | 0.013 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.8μs | 0.599ns | 2.32ns | 0.145 | 0 | 0 | 915 B |
#6533 | ExecuteAsync |
net6.0 | 1.36μs | 1.02ns | 3.81ns | 0.0136 | 0 | 0 | 952 B |
#6533 | ExecuteAsync |
netcoreapp3.1 | 1.77μs | 1.18ns | 4.55ns | 0.0123 | 0 | 0 | 952 B |
#6533 | ExecuteAsync |
net472 | 1.78μs | 0.337ns | 1.31ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.39μs | 1.39ns | 5.4ns | 0.0306 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.37μs | 4.88ns | 18.9ns | 0.0372 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.36μs | 1.6ns | 5.99ns | 0.493 | 0 | 0 | 3.12 KB |
#6533 | SendAsync |
net6.0 | 4.38μs | 1.88ns | 7.29ns | 0.0328 | 0 | 0 | 2.31 KB |
#6533 | SendAsync |
netcoreapp3.1 | 5.37μs | 1.11ns | 4.13ns | 0.0376 | 0 | 0 | 2.85 KB |
#6533 | SendAsync |
net472 | 7.33μs | 2.41ns | 9.33ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6533
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0
1.114
1,629.26
1,462.77
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 | 1.114 | 1,629.26 | 1,462.77 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.63μs | 0.876ns | 3.28ns | 0.0227 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.22μs | 1.08ns | 4.05ns | 0.0223 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.74μs | 0.952ns | 3.56ns | 0.249 | 0 | 0 | 1.57 KB |
#6533 | EnrichedLog |
net6.0 | 1.46μs | 0.899ns | 3.24ns | 0.0228 | 0 | 0 | 1.64 KB |
#6533 | EnrichedLog |
netcoreapp3.1 | 2.19μs | 1.21ns | 4.67ns | 0.0219 | 0 | 0 | 1.64 KB |
#6533 | EnrichedLog |
net472 | 2.78μs | 1.43ns | 5.55ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 120μs | 84.5ns | 316ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 121μs | 117ns | 422ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 152μs | 210ns | 812ns | 0.684 | 0.228 | 0 | 4.46 KB |
#6533 | EnrichedLog |
net6.0 | 116μs | 143ns | 554ns | 0.0581 | 0 | 0 | 4.28 KB |
#6533 | EnrichedLog |
netcoreapp3.1 | 120μs | 133ns | 517ns | 0 | 0 | 0 | 4.28 KB |
#6533 | EnrichedLog |
net472 | 151μs | 141ns | 547ns | 0.674 | 0.225 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.86μs | 1.03ns | 3.7ns | 0.0302 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.14μs | 1.92ns | 7.42ns | 0.0288 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.92μs | 0.771ns | 2.78ns | 0.32 | 0 | 0 | 2.02 KB |
#6533 | EnrichedLog |
net6.0 | 3.08μs | 2.66ns | 10.3ns | 0.0308 | 0 | 0 | 2.2 KB |
#6533 | EnrichedLog |
netcoreapp3.1 | 4.24μs | 1.61ns | 6.25ns | 0.0299 | 0 | 0 | 2.2 KB |
#6533 | EnrichedLog |
net472 | 4.89μs | 1.39ns | 5.39ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6533
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1
1.115
1,643.22
1,832.60
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 | 1.115 | 1,643.22 | 1,832.60 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.37μs | 0.821ns | 3.18ns | 0.0157 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.64μs | 0.671ns | 2.32ns | 0.0149 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.16μs | 0.773ns | 3ns | 0.183 | 0 | 0 | 1.16 KB |
#6533 | SendReceive |
net6.0 | 1.46μs | 3ns | 11.6ns | 0.016 | 0 | 0 | 1.14 KB |
#6533 | SendReceive |
netcoreapp3.1 | 1.83μs | 0.647ns | 2.33ns | 0.0156 | 0 | 0 | 1.14 KB |
#6533 | SendReceive |
net472 | 2.13μs | 0.649ns | 2.51ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.85μs | 1.03ns | 3.99ns | 0.0213 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.02μs | 5.11ns | 19.8ns | 0.022 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.18μs | 2.59ns | 9.7ns | 0.322 | 0 | 0 | 2.04 KB |
#6533 | EnrichedLog |
net6.0 | 2.62μs | 0.62ns | 2.4ns | 0.0223 | 0 | 0 | 1.6 KB |
#6533 | EnrichedLog |
netcoreapp3.1 | 3.85μs | 1.73ns | 6.46ns | 0.0212 | 0 | 0 | 1.65 KB |
#6533 | EnrichedLog |
net472 | 4.36μs | 3.01ns | 10.8ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #6533
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.194
485.32
579.43
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.194 | 485.32 | 579.43 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 463ns | 0.3ns | 1.12ns | 0.00814 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 552ns | 0.285ns | 1.07ns | 0.00785 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 691ns | 0.357ns | 1.38ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 486ns | 0.327ns | 1.27ns | 0.00976 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 734ns | 1.63ns | 6.32ns | 0.00947 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 902ns | 0.783ns | 3.03ns | 0.104 | 0 | 0 | 658 B |
#6533 | StartFinishSpan |
net6.0 | 454ns | 0.268ns | 1.04ns | 0.00797 | 0 | 0 | 576 B |
#6533 | StartFinishSpan |
netcoreapp3.1 | 561ns | 0.361ns | 1.4ns | 0.00764 | 0 | 0 | 576 B |
#6533 | StartFinishSpan |
net472 | 699ns | 0.492ns | 1.91ns | 0.0916 | 0 | 0 | 578 B |
#6533 | StartFinishScope |
net6.0 | 580ns | 0.25ns | 0.968ns | 0.00965 | 0 | 0 | 696 B |
#6533 | StartFinishScope |
netcoreapp3.1 | 657ns | 0.573ns | 2.22ns | 0.00956 | 0 | 0 | 696 B |
#6533 | StartFinishScope |
net472 | 910ns | 0.51ns | 1.98ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 630ns | 0.4ns | 1.55ns | 0.00981 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 959ns | 1.13ns | 4.37ns | 0.00956 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.15μs | 0.682ns | 2.64ns | 0.104 | 0 | 0 | 658 B |
#6533 | RunOnMethodBegin |
net6.0 | 595ns | 0.22ns | 0.824ns | 0.00984 | 0 | 0 | 696 B |
#6533 | RunOnMethodBegin |
netcoreapp3.1 | 873ns | 0.573ns | 2.22ns | 0.00946 | 0 | 0 | 696 B |
#6533 | RunOnMethodBegin |
net472 | 1.12μs | 0.98ns | 3.8ns | 0.104 | 0 | 0 | 658 B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ions/azure-functions/Samples.AzureFunctions.V4Isolated/Microsoft.Azure.Functions.Worker.Extensions.Http-3.2.0
Bumps Microsoft.Azure.Functions.Worker.Extensions.Http from 3.0.12 to 3.2.0.
Release notes
Sourced from Microsoft.Azure.Functions.Worker.Extensions.Http's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)