Actually include child processes when requested during a memory dump in tests - part 2 :D

[tonyredondo]

Summary of changes

Fix "dump child processes" not working

Reason for change

#6401 added the ability to say "dump the child processes too", except we didn't wire up the parameter.
#6520 tried to fix it, but was missing another call.

Implementation details

Wire up the parameter

[andrewlock]

:tableflip:

[datadog-ddstaging]

Datadog Report

Branch report: tony/actually-dump-children-2
Commit report: c8de0dd
Test service: dd-trace-dotnet

✅ 0 Failed, 239016 Passed, 1965 Skipped, 18h 35m 3.03s Total Time

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6537)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6537) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6537) - mean (978ms)  : 953, 1004
     .   : milestone, 978,
    master - mean (979ms)  : 948, 1010
     .   : milestone, 979,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6537) - mean (107ms)  : 105, 109
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6537) - mean (677ms)  : 660, 695
     .   : milestone, 677,
    master - mean (678ms)  : 664, 693
     .   : milestone, 678,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6537) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6537) - mean (628ms)  : 611, 644
     .   : milestone, 628,
    master - mean (635ms)  : 620, 649
     .   : milestone, 635,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6537) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6537) - mean (1,101ms)  : 1059, 1142
     .   : milestone, 1101,
    master - mean (1,103ms)  : 1066, 1140
     .   : milestone, 1103,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6537) - mean (279ms)  : 276, 282
     .   : milestone, 279,
    master - mean (277ms)  : 274, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6537) - mean (871ms)  : 844, 898
     .   : milestone, 871,
    master - mean (870ms)  : 843, 897
     .   : milestone, 870,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6537) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6537) - mean (845ms)  : 807, 883
     .   : milestone, 845,
    master - mean (852ms)  : 825, 878
     .   : milestone, 852,

Loading

[lucaspimentel]

Third time is the charm.