Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Visibility] Disable EarlyFlakeDetection test on alpine due to flakiness #6542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonyredondo
Copy link
Member

Summary of changes

This PR skips EarlyFlakeDetection tests on alpine due to flakiness.

I'm working to find the root cause in another branch

Reason for change

The flakiness on these tests in alpine are impacting productivity in the repo.

Implementation details

Just temporarily skip the tests if Alpine is detected.

@tonyredondo tonyredondo requested review from a team as code owners January 13, 2025 17:10
@github-actions github-actions bot added area:tests unit tests, integration tests area:ci-visibility labels Jan 13, 2025
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 13, 2025

Datadog Report

Branch report: tony/civisibility-disable-efd-tests-due-to-flakiness
Commit report: bdb5134
Test service: dd-trace-dotnet

✅ 0 Failed, 234827 Passed, 2261 Skipped, 18h 11m 24.13s Total Time

@andrewlock
Copy link
Member

andrewlock commented Jan 13, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6542) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (69ms)  : 65, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6542) - mean (973ms)  : 949, 998
     .   : milestone, 973,
    master - mean (977ms)  : 945, 1008
     .   : milestone, 977,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6542) - mean (108ms)  : 106, 109
     .   : milestone, 108,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6542) - mean (679ms)  : 657, 701
     .   : milestone, 679,
    master - mean (677ms)  : 656, 697
     .   : milestone, 677,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6542) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 90, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6542) - mean (632ms)  : 613, 651
     .   : milestone, 632,
    master - mean (631ms)  : 615, 647
     .   : milestone, 631,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6542) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (194ms)  : 190, 198
     .   : milestone, 194,

    section CallTarget+Inlining+NGEN
    This PR (6542) - mean (1,103ms)  : 1077, 1129
     .   : milestone, 1103,
    master - mean (1,101ms)  : 1070, 1132
     .   : milestone, 1101,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6542) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (278ms)  : 274, 282
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6542) - mean (871ms)  : 844, 898
     .   : milestone, 871,
    master - mean (870ms)  : 846, 895
     .   : milestone, 870,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6542) - mean (266ms)  : 260, 273
     .   : milestone, 266,
    master - mean (267ms)  : 261, 272
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6542) - mean (848ms)  : 812, 884
     .   : milestone, 848,
    master - mean (851ms)  : 818, 883
     .   : milestone, 851,

Loading

@tonyredondo tonyredondo force-pushed the tony/civisibility-disable-efd-tests-due-to-flakiness branch from e229dd4 to bdb5134 Compare January 13, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci-visibility area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants