[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

zacharycmontoya · 2025-01-13T22:15:03Z

Summary of changes

At instrumentation startup, if OpenTelemetry.Api v1.0.0+ is present, replace the OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator implementation (defaults to a NoopTextMapPropagator) with the following:

new CompositeTextMapPropagator(new TextMapPropagator[]
{
    new TraceContextPropagator(),
    new BaggagePropagator(),
});

Reason for change

There is a current feature gap when the user tries to use OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator.

If the user is using the OpenTelemetry SDK, the static property gets overwritten with a functioning implementation when the OpenTelemetry.Sdk type is loaded.

However, if the user removes the OpenTelemetry SDK from their application and relies on the Datadog .NET Tracer for implementing the OpenTelemetry Tracing API, the default propagator no longer gets a functional implementation. This change addresses that gap.

Implementation details

At instrumentation initialization, if the OpenTelemetry support is enabled (DD_TRACE_OTEL_ENABLED=true), use reflection to call into the static OpenTelemetry.Context.Propagation.Propagators class and overwrite the DefaultTextMapPropagator property in the same way as the OpenTelemetry SDK would, with a propagator that propagates W3C Tracecontext and W3C Baggage.

Test coverage

This PR adds to the snapshot testing of the Samples.NetActivitySdk application, asserting that the context propagation has a functioning implementation.

Other details

github-actions · 2025-01-13T22:15:50Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

+      custom.opentelemetry.defaulttextmappropagator.baggage: key=value,

tracer/src/Datadog.Trace/Activity/ActivityListener.cs

zacharycmontoya · 2025-01-13T22:24:33Z

tracer/src/Datadog.Trace/ClrProfiler/Instrumentation.cs

@@ -329,6 +329,9 @@ internal static void InitializeNoNativeParts(Stopwatch sw = null)
                {
                    Log.Debug("Initializing activity listener.");
                    Activity.ActivityListener.Initialize();
+
+                    Log.Debug("Initializing OpenTelemetry components.");
+                    OpenTelemetry.Sdk.Initialize();


I named this Datadog.Trace.OpenTelemetry.Sdk to better map the concepts to the OpenTelemetry SDK namespacing/file structure, but I'm open to feedback!

datadog-ddstaging · 2025-01-13T23:02:15Z

Datadog Report

Branch report: zach.montoya/otel-dropin-default-propagator
Commit report: d9d654c
Test service: dd-trace-dotnet

✅ 0 Failed, 202070 Passed, 729 Skipped, 2h 35m 56.49s Total Time

andrewlock · 2025-01-13T23:07:55Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (69ms)  : 65, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (981ms)  : 962, 1000
     .   : milestone, 981,
    master - mean (976ms)  : 956, 996
     .   : milestone, 976,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (677ms)  : 665, 689
     .   : milestone, 677,
    master - mean (672ms)  : 658, 687
     .   : milestone, 672,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (91ms)  : 90, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (630ms)  : 613, 647
     .   : milestone, 630,
    master - mean (632ms)  : 619, 646
     .   : milestone, 632,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (193ms)  : 189, 197
     .   : milestone, 193,
    master - mean (193ms)  : 188, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (1,097ms)  : 1068, 1126
     .   : milestone, 1097,
    master - mean (1,103ms)  : 1074, 1132
     .   : milestone, 1103,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (278ms)  : 274, 281
     .   : milestone, 278,
    master - mean (280ms)  : 275, 285
     .   : milestone, 280,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (867ms)  : 839, 895
     .   : milestone, 867,
    master - mean (870ms)  : 838, 903
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6544) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (267ms)  : 263, 270
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (6544) - mean (846ms)  : 814, 877
     .   : milestone, 846,
    master - mean (850ms)  : 820, 880
     .   : milestone, 850,

bouwkast

I think ForceDefaultIdFormat should be removed as it seems to change the IDs of Hierarchical Activities to be W3C

tracer/src/Datadog.Trace/Activity/ActivityListener.cs

bouwkast

LGTM!

andrewlock · 2025-01-15T06:14:02Z

Benchmarks Report for tracer 🐌

Benchmarks for #6544 compared to master:

1 benchmarks are faster, with geometric mean 1.114
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.02μs	41.3ns	198ns	0.0159	0.00795	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	57.6ns	378ns	0.016	0.00532	0	5.8 KB
master	`StartStopWithChild`	net472	16.3μs	52.6ns	204ns	1.05	0.31	0.106	6.22 KB
#6544	`StartStopWithChild`	net6.0	7.98μs	45.4ns	318ns	0.0156	0.00782	0	5.62 KB
#6544	`StartStopWithChild`	netcoreapp3.1	10.1μs	51.8ns	248ns	0.0202	0.0101	0	5.8 KB
#6544	`StartStopWithChild`	net472	16.4μs	56.5ns	219ns	1.05	0.319	0.0958	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	470μs	155ns	599ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	490ns	1.83μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	850μs	611ns	2.37μs	0.425	3.3 KB
#6544	`WriteAndFlushEnrichedTraces`	net6.0	505μs	246ns	921ns	0	2.7 KB
#6544	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	677μs	349ns	1.3μs	0	2.7 KB
#6544	`WriteAndFlushEnrichedTraces`	net472	856μs	832ns	3.22μs	0.425	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	153μs	893ns	8.28μs	0.142	14.47 KB
master	`SendRequest`	netcoreapp3.1	172μs	980ns	7.65μs	0.167	17.27 KB
master	`SendRequest`	net472	0.00163ns	0.000805ns	0.00301ns	0	0 b
#6544	`SendRequest`	net6.0	153μs	902ns	8.7μs	0.15	14.47 KB
#6544	`SendRequest`	netcoreapp3.1	168μs	959ns	6.98μs	0.161	17.27 KB
#6544	`SendRequest`	net472	0.000949ns	0.000514ns	0.00199ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6544

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.84 KB	41.48 KB	-359 B	-0.86%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	595μs	3.43μs	27.9μs	0.573	0	0	41.84 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	675μs	3.78μs	24.8μs	0.322	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	net472	820μs	2.17μs	7.84μs	8.47	2.82	0.403	53.27 KB
#6544	`WriteAndFlushEnrichedTraces`	net6.0	570μs	2.56μs	9.57μs	0.598	0	0	41.48 KB
#6544	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	683μs	3.78μs	22.4μs	0.321	0	0	41.86 KB
#6544	`WriteAndFlushEnrichedTraces`	net472	842μs	3.66μs	14.2μs	8.52	2.44	0.406	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.24μs	0.971ns	3.63ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.86μs	1.94ns	7.51ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.07μs	1.76ns	6.84ns	0.156	0.00103	987 B
#6544	`ExecuteNonQuery`	net6.0	1.28μs	1.41ns	5.29ns	0.0143	0	1.02 KB
#6544	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.28ns	4.78ns	0.0143	0	1.02 KB
#6544	`ExecuteNonQuery`	net472	2.07μs	1.9ns	7.37ns	0.157	0.00103	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.28μs	0.474ns	1.77ns	0.0135	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.01ns	3.79ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.53μs	2.86ns	11.1ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	0.437ns	1.63ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	0.691ns	2.59ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	2.41ns	9.33ns	0.166	1.05 KB
#6544	`CallElasticsearch`	net6.0	1.29μs	0.521ns	1.95ns	0.0136	976 B
#6544	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.625ns	2.34ns	0.0129	976 B
#6544	`CallElasticsearch`	net472	2.63μs	1.89ns	7.08ns	0.157	995 B
#6544	`CallElasticsearchAsync`	net6.0	1.35μs	0.773ns	2.99ns	0.0135	952 B
#6544	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	0.683ns	2.56ns	0.0138	1.02 KB
#6544	`CallElasticsearchAsync`	net472	2.71μs	1.68ns	6.5ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.418ns	1.62ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	2.09ns	8.11ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.87μs	0.384ns	1.44ns	0.145	915 B
#6544	`ExecuteAsync`	net6.0	1.39μs	0.652ns	2.44ns	0.0133	952 B
#6544	`ExecuteAsync`	netcoreapp3.1	1.62μs	1.11ns	4.14ns	0.0129	952 B
#6544	`ExecuteAsync`	net472	1.81μs	0.701ns	2.71ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.6μs	1.67ns	6.25ns	0.0323	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.35μs	2.31ns	8.94ns	0.0375	2.85 KB
master	`SendAsync`	net472	7.48μs	3.08ns	11.9ns	0.493	3.12 KB
#6544	`SendAsync`	net6.0	4.34μs	1.8ns	6.75ns	0.0305	2.31 KB
#6544	`SendAsync`	netcoreapp3.1	5.32μs	3.55ns	13.8ns	0.0373	2.85 KB
#6544	`SendAsync`	net472	7.33μs	1.73ns	6.68ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.49μs	1.11ns	4.14ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.14μs	0.921ns	3.32ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.78μs	0.944ns	3.53ns	0.249	1.57 KB
#6544	`EnrichedLog`	net6.0	1.49μs	1.37ns	5.32ns	0.023	1.64 KB
#6544	`EnrichedLog`	netcoreapp3.1	2.22μs	9.77ns	37.8ns	0.0219	1.64 KB
#6544	`EnrichedLog`	net472	2.8μs	1.22ns	4.55ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	152ns	589ns	0.0579	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	143ns	552ns	0.0603	0	4.28 KB
master	`EnrichedLog`	net472	152μs	137ns	529ns	0.684	0.228	4.46 KB
#6544	`EnrichedLog`	net6.0	116μs	159ns	616ns	0.0582	0	4.28 KB
#6544	`EnrichedLog`	netcoreapp3.1	121μs	221ns	857ns	0	0	4.28 KB
#6544	`EnrichedLog`	net472	151μs	133ns	516ns	0.675	0.225	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.18μs	1.35ns	5.23ns	0.0308	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.15μs	3.25ns	12.6ns	0.029	2.2 KB
master	`EnrichedLog`	net472	4.86μs	1.52ns	5.88ns	0.32	2.02 KB
#6544	`EnrichedLog`	net6.0	3μs	0.845ns	3.27ns	0.03	2.2 KB
#6544	`EnrichedLog`	netcoreapp3.1	4.34μs	1.78ns	6.18ns	0.0285	2.2 KB
#6544	`EnrichedLog`	net472	4.95μs	1.71ns	6.61ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.29μs	0.673ns	2.61ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	1.02ns	3.94ns	0.0157	1.14 KB
master	`SendReceive`	net472	2.06μs	0.975ns	3.78ns	0.184	1.16 KB
#6544	`SendReceive`	net6.0	1.32μs	0.687ns	2.57ns	0.0158	1.14 KB
#6544	`SendReceive`	netcoreapp3.1	1.76μs	0.7ns	2.71ns	0.0158	1.14 KB
#6544	`SendReceive`	net472	2.09μs	0.553ns	2.07ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	3.03ns	11.7ns	0.0219	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.98μs	1.12ns	4.35ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.33μs	2.73ns	10.2ns	0.324	2.04 KB
#6544	`EnrichedLog`	net6.0	2.81μs	1.23ns	4.77ns	0.0226	1.6 KB
#6544	`EnrichedLog`	netcoreapp3.1	3.8μs	2.65ns	10.2ns	0.0229	1.65 KB
#6544	`EnrichedLog`	net472	4.25μs	4.23ns	16.4ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6544

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.114	636.02	570.76

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	399ns	0.141ns	0.526ns	0.008	576 B
master	`StartFinishSpan`	netcoreapp3.1	636ns	0.276ns	1.03ns	0.00763	576 B
master	`StartFinishSpan`	net472	666ns	0.542ns	2.1ns	0.0917	578 B
master	`StartFinishScope`	net6.0	481ns	0.318ns	1.23ns	0.00986	696 B
master	`StartFinishScope`	netcoreapp3.1	718ns	0.334ns	1.25ns	0.00932	696 B
master	`StartFinishScope`	net472	837ns	0.656ns	2.54ns	0.104	658 B
#6544	`StartFinishSpan`	net6.0	399ns	0.18ns	0.675ns	0.00808	576 B
#6544	`StartFinishSpan`	netcoreapp3.1	571ns	0.497ns	1.86ns	0.00788	576 B
#6544	`StartFinishSpan`	net472	738ns	0.815ns	3.16ns	0.0918	578 B
#6544	`StartFinishScope`	net6.0	483ns	0.32ns	1.24ns	0.00971	696 B
#6544	`StartFinishScope`	netcoreapp3.1	706ns	0.457ns	1.77ns	0.00926	696 B
#6544	`StartFinishScope`	net472	851ns	0.947ns	3.67ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	690ns	0.524ns	2.03ns	0.0098	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	859ns	0.616ns	2.39ns	0.00955	696 B
master	`RunOnMethodBegin`	net472	1.03μs	0.655ns	2.54ns	0.105	658 B
#6544	`RunOnMethodBegin`	net6.0	659ns	0.364ns	1.41ns	0.00978	696 B
#6544	`RunOnMethodBegin`	netcoreapp3.1	946ns	0.45ns	1.74ns	0.009	696 B
#6544	`RunOnMethodBegin`	net472	1.06μs	0.688ns	2.66ns	0.104	658 B

zacharycmontoya added 2 commits January 13, 2025 13:52

Add tests for the default OpenTelemetry.Api Propagator

0eb03eb

Add default implementation for OpenTelemetry Propagator API

f3e6398

zacharycmontoya changed the title ~~[Tracing] Provide OpenTelemetry.Context.Propagation.Propagators~~ [Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator Jan 13, 2025

zacharycmontoya commented Jan 13, 2025

View reviewed changes

tracer/src/Datadog.Trace/Activity/ActivityListener.cs Outdated Show resolved Hide resolved

zacharycmontoya commented Jan 13, 2025

View reviewed changes

zacharycmontoya marked this pull request as ready for review January 13, 2025 22:26

zacharycmontoya requested a review from a team as a code owner January 13, 2025 22:26

zacharycmontoya changed the title ~~[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator~~ [AIDM-504] Jan 13, 2025

zacharycmontoya changed the title ~~[AIDM-504]~~ [Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] Jan 14, 2025

bouwkast reviewed Jan 14, 2025

View reviewed changes

tracer/src/Datadog.Trace/Activity/ActivityListener.cs Outdated Show resolved Hide resolved

Revert changes to Activity.ForceDefaultIdFormat

d9d654c

bouwkast approved these changes Jan 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

zacharycmontoya commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025

zacharycmontoya Jan 13, 2025

datadog-ddstaging bot commented Jan 13, 2025 •

edited

Loading

andrewlock commented Jan 13, 2025 •

edited

Loading

bouwkast left a comment

bouwkast left a comment

andrewlock commented Jan 15, 2025

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6544

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6544

Raw results

Raw results

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

Are you sure you want to change the base?

[Tracing] Provide default implementation for OpenTelemetry.Context.Propagation.Propagators.DefaultTextMapPropagator [AIDM-504] #6544

Conversation

zacharycmontoya commented Jan 13, 2025 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

github-actions bot commented Jan 13, 2025

Snapshots difference summary

zacharycmontoya Jan 13, 2025

Choose a reason for hiding this comment

datadog-ddstaging bot commented Jan 13, 2025 • edited Loading

Datadog Report

andrewlock commented Jan 13, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

bouwkast left a comment

Choose a reason for hiding this comment

bouwkast left a comment

Choose a reason for hiding this comment

andrewlock commented Jan 15, 2025

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6544

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6544

Raw results

Raw results

zacharycmontoya commented Jan 13, 2025 •

edited

Loading

datadog-ddstaging bot commented Jan 13, 2025 •

edited

Loading

andrewlock commented Jan 13, 2025 •

edited

Loading