Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in http2 plugin when it was enabled after request start #3714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Oct 12, 2023

What does this PR do?

Fix error in http2 plugin when it was enabled after request start.

Motivation

The http2 client plugin assumes that start was handled by the plugin when asyncStart is published. In most cases this is true, but it's possible that the plugin was enabled after a request started. This is not a problem if there were no other subscribers since the instrumentation itself won't run at that point, but if there is one, then the request will be patched even if the plugin was not there to handle start and add the store to the context.

@rochdev rochdev requested review from a team as code owners October 12, 2023 19:06
@rochdev rochdev requested a review from jbertran October 12, 2023 19:06
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Overall package size

Self size: 5.43 MB
Deduped: 61.07 MB
No deduping: 61.24 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.3 16.43 MB 16.43 MB
@datadog/native-appsec 4.0.0 14.83 MB 14.83 MB
@datadog/pprof 4.0.1 9.32 MB 10.16 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.2.0 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (04c8f60) to head (b1f9846).
Report is 399 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3714      +/-   ##
==========================================
- Coverage   85.09%   80.42%   -4.68%     
==========================================
  Files         227        3     -224     
  Lines        9288      373    -8915     
  Branches       33       33              
==========================================
- Hits         7904      300    -7604     
+ Misses       1384       73    -1311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rochdev rochdev force-pushed the fix-http2-late-plugin-init branch from a5eee0b to b1f9846 Compare October 31, 2023 16:44
@pr-commenter
Copy link

pr-commenter bot commented Oct 31, 2023

Benchmarks

Benchmark execution time: 2023-10-31 16:51:37

Comparing candidate commit b1f9846 in PR branch fix-http2-late-plugin-init with baseline commit 2b10ebd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 479 metrics, 13 unstable metrics.

@Qard Qard requested a review from a team as a code owner June 17, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant