-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error in http2 plugin when it was enabled after request start #3714
base: master
Are you sure you want to change the base?
Conversation
Overall package sizeSelf size: 5.43 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3714 +/- ##
==========================================
- Coverage 85.09% 80.42% -4.68%
==========================================
Files 227 3 -224
Lines 9288 373 -8915
Branches 33 33
==========================================
- Hits 7904 300 -7604
+ Misses 1384 73 -1311 ☔ View full report in Codecov by Sentry. |
a5eee0b
to
b1f9846
Compare
BenchmarksBenchmark execution time: 2023-10-31 16:51:37 Comparing candidate commit b1f9846 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 479 metrics, 13 unstable metrics. |
What does this PR do?
Fix error in http2 plugin when it was enabled after request start.
Motivation
The
http2
client plugin assumes thatstart
was handled by the plugin whenasyncStart
is published. In most cases this is true, but it's possible that the plugin was enabled after a request started. This is not a problem if there were no other subscribers since the instrumentation itself won't run at that point, but if there is one, then the request will be patched even if the plugin was not there to handle start and add the store to the context.