Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mongoose 8.0.0 in node 14 for v3.39.0 [TO DELETE] #3757

Closed
wants to merge 25 commits into from

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Nov 2, 2023

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

wconti27 and others added 21 commits October 31, 2023 18:04
Add tracking of supported integrations and supported integration versions and output data as artifacts during testing
---------

Co-authored-by: Stephen Belanger <[email protected]>
* Add hardcoded secret analyzer.

* Add secret samples

* Include secret column

* Use the new rewriter literals API

* Upgrade rewriter version

Co-authored-by: Ugaitz Urien <[email protected]>

---------

Co-authored-by: Julio Gonzalez <[email protected]>
Co-authored-by: Ugaitz Urien <[email protected]>
* Make IAST redaction pattern configurables

* Fix custom IAST redaction pattern configuration description

* Use optional chaining operator in config

* Refactor vulnerability formatter custom redaction patterns test

* Fix PR comments

* Optional chaining for iast experimental root configuration

* Fix config options override test

* Fix linting
* Add startup time benchmark for iast

* New CI image for startup benchmark

* Tweak startup benchmark app

* New CI image for startup benchmark

* Disable rewriter

* Enable rewriter

* Restore CI base image

* Fix linting

* Remove sed command to avoid logging in insecure-bank

* Move listening listener to server listen method for insecure-bank

* Checkout specific commit for insecure-bank

* Add appsec variants
* Fix knex nested queries

* Fix lint
* Handle headers with array values

* Add a test with array value in the evidence

* Stringify array values

* Test header empty array
Copy link

github-actions bot commented Nov 2, 2023

Overall package size

Self size: 5.44 MB
Deduped: 61.08 MB
No deduping: 61.24 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.3 16.43 MB 16.43 MB
@datadog/native-appsec 4.0.0 14.83 MB 14.83 MB
@datadog/pprof 4.0.1 9.32 MB 10.16 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.2.0 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@212e42e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v3.x    #3757   +/-   ##
=======================================
  Coverage        ?   85.12%           
=======================================
  Files           ?      227           
  Lines           ?     9299           
  Branches        ?       33           
=======================================
  Hits            ?     7916           
  Misses          ?     1383           
  Partials        ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Nov 2, 2023

Benchmarks

Benchmark execution time: 2023-11-02 10:21:50

Comparing candidate commit ecab32f in PR branch ugaitz/test-mongoose-for-v3.39.0 with baseline commit 212e42e in branch v3.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 716 metrics, 22 unstable metrics.

crysmags and others added 4 commits November 2, 2023 09:28
Adding support for Error handling with Next when using nextRequest. The error stack is now being added to the span and root span.

---------

Co-authored-by: Sam Brenner <[email protected]>
Co-authored-by: Sam Brenner <[email protected]>
@uurien uurien force-pushed the ugaitz/test-mongoose-for-v3.39.0 branch from a2ff0ec to ecab32f Compare November 2, 2023 10:13
@uurien uurien changed the title Fix mongoose 8.0.0 in node 14 for v3.39.0 Fix mongoose 8.0.0 in node 14 for v3.39.0 [TO DELETE] Nov 2, 2023
@uurien uurien closed this Nov 2, 2023
@tlhunter tlhunter deleted the ugaitz/test-mongoose-for-v3.39.0 branch January 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants