Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mocha@8 to mocha@9 (VULN-5521, VULN-5526) #4036

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Feb 7, 2024

What does this PR do?

  • upgrades the version of mocha
  • also modifies the DBM tests so that they should stop spontaneously failing when versions change

Motivation

  • fixes a pair of auto reported vulns which do not affect customer apps

Copy link

github-actions bot commented Feb 7, 2024

Overall package size

Self size: 6 MB
Deduped: 61.59 MB
No deduping: 62.35 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e7b3ba) 85.14% compared to head (e1b7591) 85.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4036      +/-   ##
==========================================
+ Coverage   85.14%   85.20%   +0.05%     
==========================================
  Files         243      243              
  Lines       10504    10544      +40     
  Branches       33       33              
==========================================
+ Hits         8944     8984      +40     
  Misses       1560     1560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2024

Benchmarks

Benchmark execution time: 2024-02-07 22:39:48

Comparing candidate commit e1b7591 in PR branch tlhunter/upgrade-mocha with baseline commit 9e7b3ba in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 3 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-120.202MB; -101.274MB] or [-12.733%; -10.728%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-126.291MB; -123.325MB] or [-13.123%; -12.815%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-123.779MB; -107.013MB] or [-13.025%; -11.260%]

@tlhunter tlhunter force-pushed the tlhunter/upgrade-mocha branch from 0cc02d8 to e691a99 Compare February 7, 2024 22:29
@tlhunter tlhunter force-pushed the tlhunter/upgrade-mocha branch from e691a99 to e1b7591 Compare February 7, 2024 22:32
@tlhunter tlhunter marked this pull request as ready for review February 7, 2024 22:39
@tlhunter tlhunter requested review from a team as code owners February 7, 2024 22:39
@tlhunter tlhunter requested a review from jbertran February 7, 2024 22:39
@tlhunter tlhunter merged commit eae0c8c into master Feb 8, 2024
109 of 111 checks passed
@tlhunter tlhunter deleted the tlhunter/upgrade-mocha branch February 8, 2024 00:05
@tlhunter tlhunter mentioned this pull request Feb 13, 2024
This was referenced Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants