-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix child_process test in node <16 #4059
Conversation
Overall package sizeSelf size: 6.04 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4059 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 243 243
Lines 10569 10569
Branches 33 33
=======================================
Hits 9019 9019
Misses 1550 1550 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-14 13:04:29 Comparing candidate commit 0f317ae in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 5 unstable metrics. scenario:plugin-graphql-with-depth-off-18
scenario:plugin-graphql-with-depth-on-max-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Integration tests are failing though. Is it flakiness?
It is failing also in master, I'm merging this. |
What does this PR do?
Fix the failing CI with child_process plugins in node <=16 release proposals.
PR with the same changes with CI running in node <=16: #4058
And the CI result in green for child_process: https://github.com/DataDog/dd-trace-js/actions/runs/7900095414/job/21560938934?pr=4058
Motivation
When
child_process.execFileSync()
is executed in node <=16, with{ shell: true }
and the executed application returns an error, it doesn't throw an execption and the result is an expected Buffer, we can't detect the error there, so we can't test it.