Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.6.0 proposal #4132

Merged
merged 24 commits into from
Mar 7, 2024
Merged

V5.6.0 proposal #4132

merged 24 commits into from
Mar 7, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Mar 4, 2024

Features

  • core: Update DSM encoding / decoding to work with other languages and use base64

Improvements

Bug fixes

szegedi and others added 13 commits March 4, 2024 18:25
* Improve index.d.ts for NodeNext

* Updates typedoc and rewrites types to work correctly with NodeNext

Fixes #3937
Fixes #4035

---------

Co-authored-by: Ben Asher <[email protected]>
Co-authored-by: Thomas Hunter II <[email protected]>
Co-authored-by: Igor Unanua <[email protected]>
Co-authored-by: simon-id <[email protected]>
Co-authored-by: Attila Szegedi <[email protected]>
* Add /register export for use
with --import flag

* Add !register.js to .npmignore

* Fix register.js lint

* Add missing exports to package.json

* Test startup for each loader/import scenario

* Remove exports entry from package.json to avoid breaking change

* Remove extensionless argv case from startup.spec.js

* Add version checks to startup.spec.js

* Use v20.6 instead of v20

* Improve version checks in startup.spec.js

---------

Co-authored-by: Sam Martin <[email protected]>
Co-authored-by: Sam Martin <[email protected]>
* Call done() only once

* Reset eachMessage method before setImmediate is executed
@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2024

Benchmarks

Benchmark execution time: 2024-03-06 17:09:08

Comparing candidate commit 882092b in PR branch v5.6.0-proposal with baseline commit 30ab66c in branch v5.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 262 metrics, 4 unstable metrics.

@uurien uurien changed the base branch from master to v5.x March 5, 2024 08:38
Copy link

github-actions bot commented Mar 5, 2024

Overall package size

Self size: 6.17 MB
Deduped: 61.16 MB
No deduping: 61.91 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.0 14.37 MB 14.38 MB
@datadog/pprof 5.1.0 8.83 MB 9.68 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 95.71865% with 14 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v5.x@30ab66c). Click here to learn what that means.

Files Patch % Lines
packages/datadog-instrumentations/src/mocha.js 0.00% 4 Missing ⚠️
packages/dd-trace/src/datastreams/pathway.js 81.81% 4 Missing ⚠️
...d-trace/src/appsec/iast/taint-tracking/rewriter.js 90.00% 1 Missing ⚠️
packages/dd-trace/src/config.js 99.61% 1 Missing ⚠️
packages/dd-trace/src/data_streams_context.js 0.00% 1 Missing ⚠️
packages/dd-trace/src/datastreams/processor.js 50.00% 1 Missing ⚠️
packages/dd-trace/src/telemetry/index.js 92.30% 1 Missing ⚠️
packages/dd-trace/src/tracer.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #4132   +/-   ##
=======================================
  Coverage        ?   85.20%           
=======================================
  Files           ?      247           
  Lines           ?    10878           
  Branches        ?       33           
=======================================
  Hits            ?     9269           
  Misses          ?     1609           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uurien uurien marked this pull request as ready for review March 5, 2024 11:09
@uurien uurien requested a review from a team as a code owner March 5, 2024 11:09
juan-fernandez
juan-fernandez previously approved these changes Mar 5, 2024
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from ci visibility's perspective.

Let's do a small change in the ci vis' notes (removing * **ci-visibility**: Early flake detection for cypress (#4122)). Final release notes for ci vis:

### Improvements

* **ci-visibility**: Grab jest's displayName config for multi-project configs (#4128)
* **ci-visibility**: Expose cypress after:spec handler (#4127)

### Bug fixes

* **ci-visibility**: Fix negative duration in playwright steps (#4113)

5.1.0 adds support for `.mjs.map` sourcemap files.
* Check if prepareStackTrace has been wrapped before restore it

* Use an IAST general flag
@uurien uurien force-pushed the v5.6.0-proposal branch from aa7c51e to dff4e59 Compare March 5, 2024 17:21
wconti27 and others added 3 commits March 6, 2024 17:59
… use base64 (#4123)

* Changes DSM to use most up to date encoding of base64 with non-deprecated pathway key dd-pathway-ctx-base64
* Refactors DSM to use a codec for encoding and decoding (makes future encoding updates easier).
* Updates DSM to check multiple encodings when decoding - base64 and deprecated - encodings, also accounting for possibility where a base64 encoded context was sent under the deprecated key.
@uurien uurien force-pushed the v5.6.0-proposal branch from dff4e59 to 882092b Compare March 6, 2024 17:00
@uurien uurien merged commit 4b08d51 into v5.x Mar 7, 2024
109 checks passed
@uurien uurien deleted the v5.6.0-proposal branch March 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.