Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy config_norm_rules.json from dd-go #5073

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Jan 7, 2025

What does this PR do?

Updates the file packages/dd-trace/test/fixtures/telemetry/config_norm_rules.json with a fresh copy from dd-go (located at trace/apps/tracer-telemetry-intake/telemetry-payload/static/config_norm_rules.json).

Motivation

This is needed in order for CI to validate the following upcoming new config options:

  • dynamicInstrumentationRedactedIdentifiers
  • dynamicInstrumentationRedactionExcludedIdentifiers

Those are added in this upcoming PR: #5053

Plugin Checklist

Additional Notes

This is needed in order for CI to validate the following upcoming new
config options:

- `dynamicInstrumentationRedactedIdentifiers`
- `dynamicInstrumentationRedactionExcludedIdentifiers`
@watson watson requested a review from a team as a code owner January 7, 2025 17:28
@watson watson self-assigned this Jan 7, 2025
Copy link
Collaborator Author

watson commented Jan 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 7, 2025

Overall package size

Self size: 8.42 MB
Deduped: 94.77 MB
No deduping: 95.28 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson mentioned this pull request Jan 7, 2025
2 tasks
@pr-commenter
Copy link

pr-commenter bot commented Jan 7, 2025

Benchmarks

Benchmark execution time: 2025-01-07 17:38:37

Comparing candidate commit b52de95 in PR branch watson/DEBUG-2630/copy-norm-rules with baseline commit 317c7a9 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 777 metrics, 20 unstable metrics.

scenario:log-without-log-20

  • 🟥 execution_time [+19.642ms; +21.550ms] or [+5.023%; +5.511%]

@watson watson merged commit e2bee27 into master Jan 8, 2025
308 checks passed
@watson watson deleted the watson/DEBUG-2630/copy-norm-rules branch January 8, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants