Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to support Unity 2020.2 or older #114

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

nowsprinting
Copy link
Contributor

Fixes

Fix to not call AssetDatabase.SaveAssetIfDirty() in Unity 2020.2 or older.
This API is added in Unity 2020.3.

Not offer an alternative because this is an optional feature.

refs #110 #111

Priority

I hope to your review && merge around one week.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 20, 2024 22:58
@github-actions github-actions bot added the fix label Nov 20, 2024
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit 3018607 into DeNA:master Nov 21, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/unity2019 branch November 21, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants