Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting item labels of SlackReporter #132

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix setting item labels of SlackReporter #132

merged 2 commits into from
Dec 23, 2024

Conversation

nowsprinting
Copy link
Contributor

Changes

  • s/sub team/user group/
  • s/Slack API token/Slack Bot OAuth token/

Priority

I hope to your review && merge && release v1.8.2 ASAP.
I will be featured in the fanzine distributed on December 30th.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner December 22, 2024 19:48
@github-actions github-actions bot added the fix label Dec 22, 2024
bo40
bo40 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit 88c92b5 into DeNA:master Dec 23, 2024
2 checks passed
@nowsprinting nowsprinting deleted the fix/slack_reporter_settings_label branch December 23, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40