Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to Agent is not destroyed #137

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Fix to Agent is not destroyed #137

merged 3 commits into from
Jan 10, 2025

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Jan 7, 2025 •
edited
Loading

Problem

Agent is not destroyed if the following sequence:

  1. Mapped scene is additive-loaded (not activated)
  2. Other scenes are additive-loaded (not unload mapped-scene because they are not single-loaded)
  3. Unload mapped scene

See test case DispatchByScene_SceneUnloadWithoutBecomingActive_DisposeAgent in Tests/Runtime/AgentDispatcherTest.cs

Fixes

AgentInspector object moves to mapped scene.

Other changes

  • Upgrade tests required test-helper package version to v1.1.1
    • Using unloadOthers option in CreateSceneAttribute

Priority

I hope to your review && merge && release it in around one week.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner January 7, 2025 12:59
@github-actions github-actions bot added the fix label Jan 7, 2025
@nowsprinting nowsprinting changed the title Fix not disposed of Agent that trigger scene was unloaded without becoming active Fix Agent is not destroyed if subsequent scenes are loaded with Additive Jan 7, 2025
@nowsprinting nowsprinting changed the title Fix Agent is not destroyed if subsequent scenes are loaded with Additive Fix Agent is not destroyed Jan 7, 2025
@nowsprinting nowsprinting changed the title Fix Agent is not destroyed Fix to Agent is not destroyed Jan 7, 2025
@nowsprinting nowsprinting mentioned this pull request Jan 7, 2025
Merged
1 task
@nowsprinting nowsprinting marked this pull request as draft January 9, 2025 12:23
@nowsprinting nowsprinting marked this pull request as ready for review January 9, 2025 17:31
@nowsprinting nowsprinting mentioned this pull request Jan 9, 2025
Open
1 task
@get-me-power get-me-power requested review from bo40 and asurato January 10, 2025 08:25
asurato
asurato approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit ff89ed3 into DeNA:master Jan 10, 2025
1 check passed
@nowsprinting nowsprinting deleted the fix/unload_scene branch January 10, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

@bo40 bo40 Awaiting requested review from bo40

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @asurato