-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate agent creation when reactivating scene #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditions: Specify observer agent and not specify fallback agent.
nowsprinting
changed the title
Fix/duplicate agents
Fix duplicate agent creation when reactivating scene
Apr 20, 2024
Kuniwak
reviewed
Apr 22, 2024
Kuniwak
reviewed
Apr 22, 2024
Kuniwak
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bugs.
Fix duplicate agent creation when reactivating scene
Problem
Duplicate agent creation.
Conditions
Cause
Agent creation when
SceneManager.activeSceneChanged
.Fix
Agent creation when
SceneManager.sceneLoaded
.Fix not dispatch observer agent case
Problem
Not dispatch (creation) observer agent.
Conditions
Specify observer agent, but not specify fallback agent.
Cause
Return before creating observer agent when not specified fallback agent.
Fix
Create observer agent even if fallback agent is not specified.
Contribution License Agreement