Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore tests using AQA when run on Linux player #86

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Ignore tests using AQA when run on Linux player #86

merged 1 commit into from
Oct 28, 2024

Conversation

nowsprinting
Copy link
Contributor

Problem

Infinite loops happen in tests using the Automated QA package when run on Linux player.

Solution

Ignore tests using AQA on Linux player.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 28, 2024 07:12
@github-actions github-actions bot added the chore label Oct 28, 2024
@get-me-power get-me-power requested review from bo40 and asurato October 28, 2024 09:02
@get-me-power
Copy link
Member

get-me-power commented Oct 28, 2024 •
edited
Loading

@nowsprinting

Once #86 and #83 and #84's PR are merged, I plan to release v1.7.0.

Is that okay?

@nowsprinting
Copy link
Contributor Author

@get-me-power san,
Please release v1.7 after merging #86 and #83.
I will fix #84 later.

@get-me-power
Copy link
Member

@nowsprinting san

OK, I got it.

bo40
bo40 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@get-me-power get-me-power merged commit 5b669a7 into DeNA:master Oct 28, 2024
2 checks passed
@nowsprinting nowsprinting deleted the chore/fix_tests_run_on_linux_player branch October 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

@asurato asurato Awaiting requested review from asurato

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nowsprinting @get-me-power @bo40