Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback-order parameter into InitializeOnLaunchAutopilotAttribute #90

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Add callback-order parameter into InitializeOnLaunchAutopilotAttribute #90

merged 7 commits into from
Oct 30, 2024

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Oct 29, 2024 •
edited
Loading

Changes

  • Add callback-order parameter into InitializeOnLaunchAutopilotAttribute
    • Call initialize methods by ordered
    • Using TypeCache when Unity 2021.3 or newer
    • Logger's initialization is earliest
  • Fix to remove unnecessary field reset
    • Non-public field and property is not serialized in OneTimeAgent, ConsoleLogger, and FileLogger
  • Fix to cancel launching autopilot when initialize failed

Priority

I hope to review && merge in this week.
There is no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner October 29, 2024 16:16
@nowsprinting nowsprinting force-pushed the feature/initialize_order branch from 159a6cf to 74cb55f Compare October 29, 2024 19:44
@get-me-power get-me-power requested review from asurato and bo40 October 30, 2024 07:41
asurato
asurato approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit bdeb5d7 into DeNA:master Oct 30, 2024
1 check passed
@nowsprinting nowsprinting deleted the feature/initialize_order branch October 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asurato asurato asurato approved these changes

@bo40 bo40 Awaiting requested review from bo40

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @asurato