Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post a report when normally termination #93

Merged

Conversation

nowsprinting
Copy link
Contributor

Before

Reporter posts a report when handling an error.

After

Reporter posts a report when Autopilot terminates.

Changes detail

The processing order changes.

Before:

  1. LogMessageHandler handles error
    i. Post a report (call reporter async)
    ii. Call Autopilot.TerminateAsync
    a. Terminated

After:

  1. LogMessageHandler handles error
    i. Call Autopilot.TerminateAsync
  2. Autopilot.TerminateAsync
    i. Post a report (call reporter async)
    ii. Terminated

This change achieved the following:

  • Can also report on normally terminated
  • Fix to prevent multiple report

Priority

I hope to review && merge in this week if possible.
There is no need to release it yet.


Contribution License Agreement

@nowsprinting nowsprinting marked this pull request as ready for review November 1, 2024 01:59
@nowsprinting nowsprinting requested a review from a team as a code owner November 1, 2024 01:59
@get-me-power get-me-power requested a review from asurato November 1, 2024 04:04
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit 02b7af5 into DeNA:master Nov 1, 2024
1 check passed
@asurato
Copy link
Contributor

asurato commented Nov 1, 2024

@nowsprinting
Thank you for your contribution!

@nowsprinting nowsprinting deleted the feature/report_on_normally_termination branch November 1, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants