Allow tying jumpsuits around waists (Impstation port) #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
size/M
|
RSI Diff Bot; head commit d902a42 merging into 90629ee Resources/Textures/Clothing/Uniforms/Jumpsuit/ancient.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos_casual.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/bartender.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/brigmedic.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/captain.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/cargotech.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/ce.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/chaplain.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/chemistry.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/cmo.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/detective.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/detective_grey.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/engineering.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/engineering_hazard.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/flannel.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/hop.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/hos.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/hos_alt.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/hydro.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/janitor.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/medical.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/ninja.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/paramedic.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/psychologist.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/qm.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/rainbow.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/roboticist.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/salvage.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/scientist.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/scientist_formal.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/security.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/security_blue.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/security_grey.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/senior_engineer.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/senior_officer.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/senior_physician.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/senior_researcher.rsi
Resources/Textures/Clothing/Uniforms/Jumpsuit/warden.rsi
|
Radezolid
requested changes
Jan 15, 2025
Resources/Locale/en-US/_Impstation/foldable/components/foldable-component.ftl
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_Impstation/Entities/Clothing/Uniforms/base_clothinguniforms.yml
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/atmos_casual.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/cargotech.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/hos.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/roboticist.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/security.rsi/meta.json
Outdated
Show resolved
Hide resolved
Resources/Textures/Clothing/Uniforms/Jumpsuit/warden.rsi/meta.json
Outdated
Show resolved
Hide resolved
alterae
force-pushed
the
slut-style
branch
4 times, most recently
from
1fd99c5 to
63e4781
Compare
Lyndomen
previously approved these changes
Jan 16, 2025
does this constitute Direction approval or just lyndo approval? |
Direction approved 👍 |
epic |
|
Radezolid's desired attribution fix has been completed (as discussed on the Discord) so this should be ready for merge now… |
Initial work on porting impstation/imp-station-14#375. Component gets the Impstation suffix to not conflict with the existing DeltaV component for rolled-up sleeves on some security uniforms.
Once again ported from impstation/imp-station-14#375. Only some of our many, many jumpsuits are affected, and all of them are in the default namespace. Some of these sprites aren't even used because our own (unmodified) _DV sprites take priority, so there is a lot of cleanup to be done.
Still porting impstation/imp-station-14#375. Notable jumpsuits NOT made foldable include: - The Salvage Specialist and HoP jumpsuits, which use _DV sprites at the moment. - Numerous security jumpsuits (due to rollable sleeves). - Pretty much all the colored jumpsuits for some reason. - The prisoner jumpsuit (this one in particular feels like a huge oversight). - All DeltaV-, Nyano-, EE-, and Impstation-specific jumpsuits. - Several seemingly random upstream jumpsuits including the reporter's jumpsuit and all variant bartender uniforms. - All skirts. Uncertain at this time whether to let those come in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of impstation/imp-station-14#375
About the PR
Allows (some) jumpsuits to be tied around the waist. Mostly upstream ones. There are some weird omissions.
Notable jumpsuits NOT made foldable include:
Important
I will not be doing any spritework for this PR myself, but will GLADLY accept additional sprites and do the YAML for them.
Why / Balance
Butch lesbians of the world rejoice (especially now that we have undershirts).
Technical details
Adds two new locale keys and one new YAML prototype. Modifies nearly forty upstream YAML prototypes and nearly forty RSI
meta.jsons. Adds nearly forty new sprite PNGs. Does not conflict with the existing mechanism for rolling up the sleeves on certain security uniforms.Media
Requirements
Breaking changes
Some prototypes have an additional parent. I don't think there's any actual work needed to deal with this.
Changelog
🆑