Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port]Game presets can now have cooldowns to prevent back-to-back modes #2744

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Jan 15, 2025

About the PR

add stuff from Impstation that makes it so we cant roll nukies twice in a row :trollface: did similar for survival, now you can only have 4 hours of vent critters not 10

Why / Balance

gamemodes bad

Technical details

port

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

no cl only for data miners

@Lyndomen Lyndomen requested review from a team as code owners January 15, 2025 19:26
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files Changes: C# Changes any cs files labels Jan 15, 2025
@Lyndomen
Copy link
Contributor Author

Lyndomen commented Jan 15, 2025

fixes #2737
well, it half fixes it

Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests from me

Resources/Prototypes/game_presets.yml Outdated Show resolved Hide resolved
Resources/Prototypes/game_presets.yml Outdated Show resolved Hide resolved
i hate whitespace

Signed-off-by: Lyndomen <[email protected]>
@Lyndomen
Copy link
Contributor Author

idk if test fail real

Radezolid
Radezolid previously approved these changes Jan 15, 2025
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three lines of YAML look good.

deltanedas
deltanedas previously approved these changes Jan 15, 2025
@deltanedas
Copy link
Member

deltanedas commented Jan 15, 2025

just need to disable this logic for tests (add a cvar probably)

Signed-off-by: Lyndomen <[email protected]>
@Lyndomen Lyndomen dismissed stale reviews from deltanedas and Radezolid via 83efcc7 January 16, 2025 14:13
Copy link
Contributor Author

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok direction approved

@deltanedas
Copy link
Member

still need to disable this logic for tests

@LadyDanger2743
Copy link

If there's anything that can be done to expedite the process of this PR, let me know. We have had SIX back-to-back NukeOps rounds today on Apoapsis; it's starting to get to folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants