Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: edit on GitHub #90

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: edit on GitHub #90

wants to merge 5 commits into from

Conversation

wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Nov 19, 2024 •
edited
Loading

Overview

Show the "Edit on GitHub" link on each page.

Status

  • should say "Suggest an update via GitHub"

Related

Changes

  • added config values
  • changed TACC-Docs version

Testing

  1. Be logged into GitHub.
  2. Open https://localhost:8000/.
  3. See "Edit on GitHub" link at top right.
  4. Click link.
  5. Verify GitHub edit page for that file appears.

UI

before after
ds-user-guide-91 ds-user-guide-90

Notes

DS User Guide was made public a while back, but adding "Edit on GitHub" link was delayed until the repo had good enough edit and test instructions.

@wesleyboar wesleyboar marked this pull request as ready for review November 19, 2024 20:31
@wesleyboar wesleyboar added the bug Something isn't working label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar