Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midleware system by codernirmal with help of devstack #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codernirmalnp
Copy link

@codernirmalnp codernirmalnp commented Oct 25, 2020

Hello Balram thakur Sir i resolve my promise and made certain changes hope you like it

Copy link
Owner

@DevStack06 DevStack06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey CodeNirmal, Here everything seems to fine 😊. I really appreciate your work., It's great you added encryption other things 😊. But here If will merge this things then there will be problems-:

  1. You changed the return property of checkusername,
  2. Made changes to the Directory structure
  3. And also added some extra endpoints 😊

Everything I really appreciate 😊, but if I will merge then, I have to explain this thing to other users because, It is main source Git_repo of the Blog_Server Series 😊

@DevStack06
Copy link
Owner

So as of now, I am not merging the code but later on, at some point in time, I will sure merge this code 😊. I will make sure your work will not be wasted 😊

@codernirmalnp
Copy link
Author

Thank you balram rathore can we do some project together. I am good at vue js,node js and laravel... But little bit in flutter . If you have any idea then we both can do project and sharpen our skill..

@DevStack06
Copy link
Owner

As of now, have lot of work :), but sure one day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants