Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling/nested menu #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Styling/nested menu #19

wants to merge 2 commits into from

Conversation

Spatovaliyski
Copy link
Contributor

Fixes the following issue: https://i.imgur.com/MOzxDR1.gifv
(Arrow in the fix too :D)

@Spatovaliyski
Mobile Menu: Fix toggled state for nested menus
76eb275 
Targeting only is-extended for sub-menu, that way it will extend only the parent, not every sub-menu
@Spatovaliyski
Merge branch 'master' into styling/nested-menu
96d2c10
@xavortm
Copy link
Contributor

xavortm commented May 22, 2019 •
edited
Loading

Honestly, I think that the _mobile-menu.scss file needs some love. That or the axe, it's something that has not been actively used for a while and I find it a bit buggy now. We should come up with a new mobile styles that are way simpler, better separated between the _header.scss and the _mobile-menu.scss files. or we can also move the desktop styles to _menu.scss and have the mobile ones there as well.

@Spatovaliyski and @kdankov thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spatovaliyski @xavortm