Display images on Adoptions page

[Dindihub]

Display images on Adoption's page to finish setting up the page.

Please review @chalin @lukpueh

[netlify]

✅ Deploy Preview for tufio ready!

Name	Link
🔨 Latest commit	ba55bf2
🔍 Latest deploy log	https://app.netlify.com/sites/tufio/deploys/66ce59984f1d5d00082a86f3
😎 Deploy Preview	https://deploy-preview-20--tufio.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[chalin]

This PR will need some rework following the merge of #19. See

• Community section adjustments #16

for a description of what needs to be done.

Note: instead of putting Adoptions images under static, put them under /content/en/community/adoptions/img.

[Dindihub]

This PR will need some rework following the merge of #19. See

• Community section adjustments #16

for a description of what needs to be done.

Note: instead of putting Adoptions images under static, put them under /content/en/community/adoptions/img.

@chalin Okay. I was thinking of opening a separate PR for that but this works too.

[Dindihub]

This PR will need some rework following the merge of #19. See

• Community section adjustments #16

for a description of what needs to be done.
Note: instead of putting Adoptions images under static, put them under /content/en/community/adoptions/img.

@chalin Okay. I was thinking of opening a separate PR for that but this works too.

@chalin may I ask why you want the images moved from static to community? It really complicated the code, it wouldn't run. I had to take it back to static :) Not sure what I'm doing wrong.

With the images in static it works just fine.

I tried changing the imgURL on the adoptions.html from {{ $imgUrl := printf "img/logos/adoptions/%s_logo.%s" $img $type | relURL }} to {{ $imgUrl := printf "en/community/adoptions/img/%s_logo.%s" $img $type | relURL }} but it wouldn't work.

[chalin]

In #17, I shared with you have to rebase.

Please rebase this PR. You'll need to resolve the conflicts that arise.

Also, can you tell me what output you get when you run git remote -v? If you see upstream, then remove it by running the following command: git remote remove upstream. You won't be contributing to the upstream project, and it just causes headaches otherwise.

[chalin]

@chalin may I ask why you want the images moved from static to community?

For improved cohesion: the images are only used in the adoptions section.

I tried changing the imgURL on the adoptions.html from {{ $imgUrl := printf "img/logos/adoptions/%s_logo.%s" $img $type | relURL }} to {{ $imgUrl := printf "en/community/adoptions/img/%s_logo.%s" $img $type | relURL }} but it wouldn't work.

After you've moved the files, the path to the images should simply be /img/%s_logo.%s because the path will be local to the folder. The full path you gave above should work too, as long as you drop the en/ prefix (if you look at the preview, there's no en/ in the URL path). Does that help?

[Dindihub]

In #17, I shared with you have to rebase.

Please rebase this PR. You'll need to resolve the conflicts that arise.

Also, can you tell me what output you get when you run git remote -v? If you see upstream, then remove it by running the following command: git remote remove upstream. You won't be contributing to the upstream project, and it just causes headaches otherwise.

Rebased and removed upstream. I realized my mistake was rebasing on local but forgetting to --force push. I think it's solved now.

[Dindihub]

@chalin may I ask why you want the images moved from static to community?

For improved cohesion: the images are only used in the adoptions section.

I tried changing the imgURL on the adoptions.html from {{ $imgUrl := printf "img/logos/adoptions/%s_logo.%s" $img $type | relURL }} to {{ $imgUrl := printf "en/community/adoptions/img/%s_logo.%s" $img $type | relURL }} but it wouldn't work.

After you've moved the files, the path to the images should simply be /img/%s_logo.%s because the path will be local to the folder. The full path you gave above should work too, as long as you drop the en/ prefix (if you look at the preview, there's no en/ in the URL path). Does that help?

It works now. Thanks

[Dindihub]

Please review again @chalin . Thanks

[chalin]

Getting closer, but the images are still not rendering. Run npm test locally and you'll see the invalid links.

For the sake of making progress on this PR, I'll address the issues in a followup commit over this PR.

[chalin]

Rename this to index.md (note the lack of underscore); otherwise we end up with this stutter in the path:

[chalin]

This page shouldn't exist under /get-started/, but we'll address this separately. I'll file an issue.

[chalin]

LGTM! All tests are passing (locally and via GH actions), and the images are rendering correctly in the Adoptions page.

[chalin]

Merging. @lukpueh if you have any comments we can address them via a followup PR.