Fixed bug in unwraping of string #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see sample 7a99e0ff0d7f0951c53a21dfabc03fb9e06d1c585de62cc71d962c1c4dde4190
The bug pertains to the unwrapping of strings. A string that should not
have been unwrapped was stripped of it's quotes, leading to this
situation :
Correct evaluation :
=IF(MFCO5<0, CALL("urlmon","URLDownloadToFileA","JJCCBB",0, (...)
Evaluation prior to fix :
=IF(MFCO5<0, CALL("urlmon","URLDownloadToFileA,"JJCCBB,0," (...)
because the string ","JJCCBB" was being stripped to "JJCCBB
This caused an error in the parsing of the formula, crashing the
program.
To fix it, I have change the unwrapping function to avoid unwrapping
when the count of quotes is uneven
|
I will check the PR soon, sorry for the late response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of the previous bad behavior, see sample 7a99e0ff0d7f0951c53a21dfabc03fb9e06d1c585de62cc71d962c1c4dde4190
The bug pertains to the unwrapping of strings. A string that should not
have been unwrapped was stripped of it's quotes, leading to this
situation :
Correct evaluation :
=IF(MFCO5<0, CALL("urlmon","URLDownloadToFileA","JJCCBB",0, (...)Evaluation prior to fix :
=IF(MFCO5<0, CALL("urlmon","URLDownloadToFileA,"JJCCBB,0," (...)because the string
","JJCCBB"was being stripped to"JJCCBBThis caused an error in the parsing of the formula, crashing the
program.
To fix it, I have changed the unwrapping function to avoid unwrapping
when the count of quotes is uneven