[1/n] Remove array_get #1374
Merged
[1/n] Remove array_get #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function cannot be properly typed as it is and fixing this would take a while, removing it is shorter and better. This PR only covers SETUP/* and api/*. It also deprecates array_get so users know that they should migrate. TESTS=None.
jchaffraix
force-pushed
the
julien_remove_array_get_1
branch
from
88c0c06 to
128301b
Compare
chrismiceli
approved these changes
Nov 20, 2024
cpeel
approved these changes
Nov 20, 2024
70ray
approved these changes
Nov 21, 2024
srjfoo
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function cannot be properly typed as it
is and fixing this would take a while, removing
it is shorter and better.
This PR only covers SETUP/* and api/*.
It also deprecates array_get so users know that
they should migrate.
TESTS=None.
Sandbox: https://www.pgdp.org/~cpeel/c.branch/julien_remove_array_get_1/