[7/7] Remove array_get #1385
Merged
[7/7] Remove array_get #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function cannot be properly typed as it is and fixing this would take a while, removing it is shorter and better. The change removes usage in the last remaining files. It also removes 2 tests for the function that were converted instead of removed. TESTS=Tested site/author searching and some project updates.
cpeel
approved these changes
Dec 8, 2024
|
I've added a commit to this branch that updates the |
chrismiceli
approved these changes
Dec 8, 2024
srjfoo
approved these changes
Dec 8, 2024
70ray
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function cannot be properly typed as it
is and fixing this would take a while, removing
it is shorter and better.
The change removes usage in the last remaining
files. It also removes 2 tests for the function
that were converted instead of removed.
TESTS=Tested site/author searching and some
project updates.
Sandbox at https://www.pgdp.org/~cpeel/c.branch/julien_remove_array_get_7/