Type pinc/ProjectSearch* #1393
Type pinc/ProjectSearch* #1393
Conversation
Typing all those files together made sense as they are all helping the search feature. TESTS=Run searches by different fields.
Co-authored-by: Casey Peel <[email protected]>
| @@ -83,7 +83,7 @@ class OptionSelector extends Selector | |||
| return $value; | |||
| } | |||
|
|
|||
| public function save_value($value) | |||
| public function save_value($value): void | |||
There was a problem hiding this comment.
That's a good point. We could have typed $value as mixed to match what Settings::set_value expects. This would give us some pretty weak typing though (mixed allows anything) but better than nothing.
Since this PR was merged, I will let it be for now. We do have some higher priority sites to fix but happy to prioritize this if you really want this solved sooner rather than later.
| { | ||
| $this->results_per_page = new OptionSelector( | ||
| 'n_results_per_page', | ||
| _('Results per page'), | ||
| 100, | ||
| '100', |
There was a problem hiding this comment.
Correct, the expected type is a string so PHP was doing the conversion for us. We just made it more visible.
| @@ -83,7 +83,7 @@ class OptionSelector extends Selector | |||
| return $value; | |||
| } | |||
|
|
|||
| public function save_value($value) | |||
| public function save_value($value): void | |||
There was a problem hiding this comment.
That's a good point. We could have typed $value as mixed to match what Settings::set_value expects. This would give us some pretty weak typing though (mixed allows anything) but better than nothing.
Since this PR was merged, I will let it be for now. We do have some higher priority sites to fix but happy to prioritize this if you really want this solved sooner rather than later.
| { | ||
| $this->results_per_page = new OptionSelector( | ||
| 'n_results_per_page', | ||
| _('Results per page'), | ||
| 100, | ||
| '100', |
There was a problem hiding this comment.
Correct, the expected type is a string so PHP was doing the conversion for us. We just made it more visible.
Typing all those files together made sense as
they are all helping the search feature.
TESTS=Run searches by different fields.
Sandbox: https://www.pgdp.org/~jchaffraix/c.branch/julien_type_projectsearch