Type api/ApiRouter.inc #1411
Open
Type api/ApiRouter.inc #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reworks the ApiRouter to clearly state that it was using a trie and add an appropriate TrieNode. This helped clarify what the code does and clean up the types in the class. TESTS=Tried calling some APIs after the change to confirm that the routing still works.
jchaffraix
force-pushed
the
julien_trie_in_apirouter
branch
from
e022b7a to
0acc756
Compare
Open
cpeel
reviewed
Jan 9, 2025
cpeel
approved these changes
Jan 11, 2025
chrismiceli
approved these changes
Jan 12, 2025
70ray
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the ApiRouter to clearly state that it was using a trie and add an appropriate TrieNode. This helped clarify what the code does and clean up the types in the class.
Sandbox: https://www.pgdp.org/~jchaffraix/c.branch/julien_trie_in_apirouter/
TESTS=Tried calling some APIs after the change to confirm that the routing still works.