solution by Yue for Jun Gi #337
Conversation
| library(ggplot2) | ||
| library(dplyr) | ||
| library(tidyr) | ||
| library(readxl) |
There was a problem hiding this comment.
it might be more simple to load the meta package library(tidyverse) instead of individual subpackages
| #the first one | ||
| #read xlsx file | ||
| file<-"Volleyball Passing- USA and TU.xlsx" | ||
| data <- read_excel(file,sheet = "TU sort by pass score") |
There was a problem hiding this comment.
- best set the working directory to the source file's location before calling
read_excel()to ensure the file is found.
Projects/JungiHong/Yue_Z9.Rmd
Outdated
| Pass_Score = as.factor("Pass Score"), | ||
| Attempts = as.numeric(Attempts), | ||
| Points_Won = as.numeric(Points_Won), | ||
| Points_Lost = as.numeric(Points_Lost)) |
There was a problem hiding this comment.
- best recompute this data based on the first two columns. maybe the author of the file did something wrong in aggregating this table?
Projects/JungiHong/Yue_Z9.Rmd
Outdated
| names_to = "Outcome", | ||
| values_to = "Count") | ||
|
|
||
| clean_data <- tidy_data %>% |
There was a problem hiding this comment.
- since you do not use or need
tidy_dataagain, join the two pipes...
dont create variables if you need them only once (directly after)...
| clean_data <- tidy_data %>% | ||
| group_by(`Pass Score`)%>% | ||
| filter(`Pass Score` %in% c("zeros", "ones", "twos", "threes"))%>% | ||
| mutate(`Pass Score` = factor(`Pass Score`, levels = c("zeros", "ones", "twos", "threes"))) |
There was a problem hiding this comment.
I think you can omit line 39 since factoring with predefined levels would make values that dont fit an NA..
Projects/JungiHong/Yue_Z9.Rmd
Outdated
| PassingScore = c(2.1, 2.3, 2.2, 2.0, 2.4), | ||
| PointsWon = c(140, 161, 117, 93, 150), | ||
| PointsLost = c(81, 58, 30, 67, 53) | ||
| ) |
There was a problem hiding this comment.
uaks... NEVER hard code data if you have a raw file.. ;)
- please replace with loading the data from file.. (and yes,.. it is an ugly file.. 😉👍)
There was a problem hiding this comment.
- try to extract and load ALL TEAMS' DATA (suitable for your targeted statistics) from the first sheet of the excel file..
|
Hi @Yue-Z9 I just reviewed your solution, Im not quite sure why there is a N/A for the stacked bar chart. For vollyeball there is only a max of 3 passes, so maybe exclude that part out? Also the second graph seems reasonable, but im not sure if the r values for both are exactly 1. Other than that, all looks good. |
Hi @Yue-Z9
I have extracted your solution files for @jungihong10 from his own branch into the new branch
yue_for_jungi.Here is the solutions file for reviewing.
Please pull and switch to this branch before working on your solution!
Best,
Martin