Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cosine-bell decomposition test #253

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 16, 2024

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes
  • New tests have been added to a test suite

@xylar xylar added enhancement New feature or request ocean Related to ocean tests or analysis labels Dec 16, 2024
@xylar xylar self-assigned this Dec 16, 2024
@xylar xylar force-pushed the cosine-bell-decomp branch from d7813ae to ab0df16 Compare December 25, 2024 10:53
@xylar xylar requested a review from cbegeman December 25, 2024 10:53
@xylar xylar marked this pull request as ready for review December 25, 2024 10:54
@xylar
Copy link
Collaborator Author

xylar commented Dec 25, 2024

Testing

I successfully ran the new omega_pr suite on Chrysalis with Intel (with Omega, of course).

I also successfully ran all tests in the cosine_bell suite (convergence_time tests don't pass the analysis step as expected) with MPAS-Ocean on Chrysalis with Intel.

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! I ran just the icos decomp test on chrys, intel with Omega and it passes

@xylar
Copy link
Collaborator Author

xylar commented Jan 2, 2025

@cbegeman, thanks very much for the review!

@xylar xylar merged commit 126f453 into E3SM-Project:main Jan 2, 2025
5 checks passed
@xylar xylar deleted the cosine-bell-decomp branch January 2, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants