Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for omega sphere transport tests #262

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cbegeman
Copy link
Collaborator

Add omega support for the sphere_transport test suite

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@cbegeman
Copy link
Collaborator Author

Testing

Test suite has been run on chrysalis, intel-impi with omega. All tests fail because they do not meet the order of convergence.

rotation_2d has 1st order convergence
correlated_tracers_2d, divergent_2d and nondivergent_2d do not converge

I will try reducing the omega time step and update this comment. I welcome any additional help on the omega side investigating the tests that do not converge.

@cbegeman cbegeman added in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis labels Jan 17, 2025
@xylar
Copy link
Collaborator

xylar commented Jan 18, 2025

@cbegeman, could you post images of the beginning and end states at the highest resolution? It could really be that the centered advection we currently have is not convergent for these more rigorous tracer tests with small-scale tracer or velocity-field structure.

This, in turn, would point to the urgency of higher-order tracer advection that we discussed on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress This PR is not ready for review or merging ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants