Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use readonly_files #220

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

use readonly_files #220

wants to merge 14 commits into from

Conversation

smoors
Copy link
Collaborator

@smoors smoors commented Dec 23, 2024

  • update CI/run_reframe.sh to use a shared file system
  • raise error if readonly_files is an empty list
  • add readonly_files to all tests
  • remove staging fixtures from cp2k and lammps
  • remove __init__.py from sourcesdirs add missing __init__.py files with added comment why they are there

fixes #211

Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove the empty init files, they are needed by the automatic API generation tools. Seems silly, but it is what it is :)

@casparvl
Copy link
Collaborator

casparvl commented Jan 9, 2025

Note: I haven't tested this PR yet, I'll do that once we agree on the actual changes in the code :)

@boegel
Copy link
Contributor

boegel commented Jan 9, 2025

Please don't remove the empty init files, they are needed by the automatic API generation tools. Seems silly, but it is what it is :)

Maybe we can put a comment in the init files to explain why they're there?

@smoors
Copy link
Collaborator Author

smoors commented Jan 9, 2025

Note: I haven't tested this PR yet, I'll do that once we agree on the actual changes in the code :)

for reference: they were only removed from the src directories, but we agreed that it's useful to have a list of the sources in the docs too.
i'll add them back

Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me (barring the __init__ removals), now running

reframe --system=snellius:rome -t CI -t '1_nodes|2_nodes' --run

just to test.

Update: all tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to deal with readonly_files
3 participants