-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use readonly_files #220
base: main
Are you sure you want to change the base?
use readonly_files #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove the empty init files, they are needed by the automatic API generation tools. Seems silly, but it is what it is :)
Note: I haven't tested this PR yet, I'll do that once we agree on the actual changes in the code :) |
Maybe we can put a comment in the init files to explain why they're there? |
for reference: they were only removed from the src directories, but we agreed that it's useful to have a list of the sources in the docs too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me (barring the __init__
removals), now running
reframe --system=snellius:rome -t CI -t '1_nodes|2_nodes' --run
just to test.
Update: all tests passed.
CI/run_reframe.sh
to use a shared file systemreadonly_files
is an empty listreadonly_files
to all testscp2k
andlammps
removeadd missing__init__.py
fromsourcesdirs
__init__.py
files with added comment why they are therefixes #211