don't set water species property for species that air_composition handles #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmielin
approved these changes
Dec 24, 2024
nusbaume
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Thanks @peverwhee! Just have one comment request but otherwise everything looks good.
| @@ -119,7 +119,6 @@ subroutine initialize_constituents_register(constituents, errmsg, errcode) | |||
| vertical_dim = 'vertical_layer_dimension', & | |||
| min_value = 0.0_kind_phys, & | |||
| advected = .true., & | |||
| water_species = .true., & | |||
There was a problem hiding this comment.
Maybe worth adding a comment stating why we aren't setting the water_species property here? Otherwise I feel like future us will forget and add it back in again.
There was a problem hiding this comment.
Agreed @nusbaume I wasn't aware that air_composition could modify the water_species property after initialization so I thought it had to be set right here. A comment will be really helpful for when we forget about this one day 😄
There was a problem hiding this comment.
comment added. thanks guys!
jimmielin
added a commit
that referenced
this pull request
Dec 31, 2024
Tag name (The PR title should also include the tag name): `atmos_phys0_07_001` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * Update extraterrestrial flux in TUV-x prior to calculating rate constants #152 by @boulderdaze * Simplify deallocation of multiple objects associated with the TUV-x #156 by @boulderdaze * Fill in errmsg, errflg in check_energy schemes #160 by @jimmielin * Validates the MUSICA meta data against the CCPP standard names #162 by @boulderdaze * Add constituent tendency updater #111 by @peverwhee * Add cloud optical calculations for use in TUV-x #167 by @mattldawson * Add initialize_constituents scheme #149 by @peverwhee * Add diagnostics to TJ2016 test schemes #170 by @peverwhee * update "radians" to "rad" #173 by @peverwhee * Solar zenith angle and Earth-Sun distance #171 by @mattldawson * Update standard names for tropopause_find #140 by @jimmielin * Update surface albedo units #181 by @mattldawson * don't set water species property for species that air_composition handles #185 by @peverwhee List all test failures: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): peverwhee
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Removes water_species property from instantiate call for water vapor mixing ratio species (as air_composition will set those). We may run into this issue again at some point for the water vapor number concentration variables, but hopefully by then we'll have metadata properties for setting that!
can supersede ESCOMP/CAM-SIMA#342
Describe any changes made to the namelist: n/a
List all files eliminated and why: n/a
List all files added and what they do: n/a
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M test/test_schemes/initialize_constituents.F90
List any test failures: all expected tests pass
Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? no