Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dadadj for CCPP framework #91

Merged
merged 28 commits into from
Jul 25, 2024
Merged

Refactor dadadj for CCPP framework #91

merged 28 commits into from
Jul 25, 2024

Conversation

jtruesdal
Copy link
Contributor

Add dadadj ccpp routine meta data and suite xml files to atmos_phys.

@nusbaume nusbaume self-requested a review May 14, 2024 16:48
@nusbaume nusbaume added the enhancement New feature or request label May 14, 2024
nusbaume
nusbaume requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jtruesdal ! I do have some change requests, but please let me know if you have any questions or concerns with any of them. Thanks!

dadadj/dadadj.F90 Outdated Show resolved Hide resolved
dadadj/dadadj.F90 Outdated Show resolved Hide resolved
dadadj/dadadj.F90 Outdated Show resolved Hide resolved
dadadj/dadadj.F90 Outdated Show resolved Hide resolved
dadadj/dadadj.F90 Outdated Show resolved Hide resolved
dadadj/dadadj_namelist.xml Outdated Show resolved Hide resolved
dadadj/dadadj_namelist.xml Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
suite_dadadj.xml Outdated Show resolved Hide resolved
nusbaume
nusbaume requested changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super-close! I just have a few last (hopefully very minor) requests.

dry_adiabatic_adjust/dadadj.F90 Outdated Show resolved Hide resolved
suite_cam7.xml Show resolved Hide resolved
dry_adiabatic_adjust/dadadj.meta Show resolved Hide resolved
nusbaume
nusbaume reviewed May 29, 2024
View reviewed changes
suite_cam7.xml Outdated Show resolved Hide resolved
nusbaume
nusbaume approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great now, thanks!

@nusbaume nusbaume requested review from cacraigucar and peverwhee June 1, 2024 03:58
@nusbaume nusbaume mentioned this pull request Jun 1, 2024
Merged
cacraigucar
cacraigucar requested changes Jun 4, 2024
View reviewed changes
doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
doc/NamesNotInDictionary.txt Outdated Show resolved Hide resolved
dry_adiabatic_adjust/dadadj.F90 Show resolved Hide resolved
@jtruesdal jtruesdal requested a review from cacraigucar June 22, 2024 00:14
cacraigucar
cacraigucar requested changes Jun 24, 2024
View reviewed changes
doc/ChangeLog Outdated Show resolved Hide resolved
@jtruesdal
Copy link
Contributor Author

jtruesdal commented Jul 10, 2024 •
edited
Loading

I've added a new temporary update routine to update the q tendency. (dadadj_apply_qv_tendency.F90 and .meta)
This will be removed once a standard utility for updating the constituents is in place. I also modified the parameterization run method to return a heating tendency which now takes care of a roundoff issue in temperature. Everything is again bfb.

@jtruesdal
dry adiabatic suite moved to test_sdfs subdirectory, cam7 suite will …
26591e1 
…contain new ccpp parameterizations. dadadj is first one
@jtruesdal
Copy link
Contributor Author

@cacraigucar @nusbaume I added a new temporary run method to update the constituent array (dadadj_apply_qv_tendency.F90/meta). Everything is working so hopefully this is the final review. I'm placing these snapshot files in their proper location.

@cacraigucar cacraigucar removed the request for review from peverwhee July 15, 2024 17:53
nusbaume
nusbaume approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just some minor requests to update a comment, a long name, and the ChangeLog (doesn't need a re-review though).

doc/ChangeLog Outdated Show resolved Hide resolved
doc/ChangeLog Outdated Show resolved Hide resolved
dry_adiabatic_adjust/dadadj.F90 Outdated Show resolved Hide resolved
dry_adiabatic_adjust/dadadj_apply_qv_tendency.meta Outdated Show resolved Hide resolved
@nusbaume nusbaume changed the base branch from main to development July 25, 2024 00:24
@nusbaume nusbaume merged commit 7710ff3 into ESCOMP:development Jul 25, 2024
1 check passed
@nusbaume nusbaume mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nusbaume nusbaume nusbaume approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

Assignees

@jtruesdal jtruesdal

Labels
enhancement New feature or request
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtruesdal @cacraigucar @nusbaume