Skip to content

Commit

Permalink
Merge pull request #4514 from ESMCI/update-perf-btr
Browse files Browse the repository at this point in the history
Fixes separating std and performance blessing

When blessing performance diffs, the default hist and namelists would
be run as well. This PR separates these, there is now two distinct blessing
paths; standard (hist and namelists) and performance.

Test suite: pytest CIME/tests/test_unit*
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes n/a
User interface changes?: N
Update gh-pages html (Y/N)?: N
  • Loading branch information
jgfouca authored Nov 14, 2023
2 parents dab95c1 + 126b568 commit f5fd575
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CIME/bless_test_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def bless_test_results(
bless_perf=False,
**_, # Capture all for extra
):
bless_all = not (namelists_only | hist_only)
bless_all = not (namelists_only | hist_only | bless_tput | bless_mem | bless_perf)

test_status_files = get_test_status_files(test_root, compiler, test_id=test_id)

Expand Down
6 changes: 3 additions & 3 deletions CIME/tests/test_unit_bless_test_results.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ def test_bless_perf(
ts = TestStatus.return_value
ts.get_name.return_value = "SMS.f19_g16.S.docker_gnu"
ts.get_overall_test_status.return_value = ("PASS", "RUN")
ts.get_status.side_effect = ["PASS", "PASS", "PASS", "FAIL", "FAIL"]
ts.get_status.side_effect = ["PASS", "PASS", "FAIL", "FAIL", "FAIL"]

case = Case.return_value.__enter__.return_value

Expand Down Expand Up @@ -470,7 +470,7 @@ def test_bless_memory_only(
ts = TestStatus.return_value
ts.get_name.return_value = "SMS.f19_g16.S.docker_gnu"
ts.get_overall_test_status.return_value = ("PASS", "RUN")
ts.get_status.side_effect = ["PASS", "PASS", "PASS", "FAIL"]
ts.get_status.side_effect = ["PASS", "PASS", "FAIL", "FAIL"]

case = Case.return_value.__enter__.return_value

Expand Down Expand Up @@ -509,7 +509,7 @@ def test_bless_throughput_only(
ts = TestStatus.return_value
ts.get_name.return_value = "SMS.f19_g16.S.docker_gnu"
ts.get_overall_test_status.return_value = ("PASS", "RUN")
ts.get_status.side_effect = ["PASS", "PASS", "PASS", "FAIL"]
ts.get_status.side_effect = ["PASS", "PASS", "FAIL", "FAIL"]

case = Case.return_value.__enter__.return_value

Expand Down

0 comments on commit f5fd575

Please sign in to comment.