Add Dockerfile for logrotate #76
Conversation
| } | ||
|
|
||
| # docker volume logs | ||
| /var/lib/docker/volumes/*log*/_data/* { |
There was a problem hiding this comment.
I think we need to be more specific about this. User might have other containers running which have log in their name. We might end up rotating their files too.
There was a problem hiding this comment.
Also, why the location of directories is same as of the host 🤔
There was a problem hiding this comment.
/var/lib/docker/volumes/, this directory will not work in case of macOS.
Also, this will skip the logs of EasyEngine itself.
For macOS a pattern inside ~/easyengine for services and sites will have to be written.
| } | ||
|
|
||
| # docker volume logs | ||
| /var/lib/docker/volumes/*log*/_data/* { |
There was a problem hiding this comment.
/var/lib/docker/volumes/, this directory will not work in case of macOS.
Also, this will skip the logs of EasyEngine itself.
For macOS a pattern inside ~/easyengine for services and sites will have to be written.
There was a problem hiding this comment.
@mrrobot47 We need to make this file logrotate/easyengine.conf accessible on the host
issue: EasyEngine/feature-requests#73