-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lua): stick "side" missing from model.getInput #5801
Conversation
If I wasn't clear, the actual firmware does compile, but that's all the testing I could do, I spent the whole morning trying with companion. |
034aa95
to
c098a07
Compare
No, that was clear... I've just rebased this on the current state of main as it was from before a fix was pushed for the just-broken Companion builds. So Companion should work for you again locally if you reset your local branch to the remote branch. |
Ok, so this is working fine on GX12, is returning/displaying 3, 2 or 1 depending on the side mode set. Should this be -- "TNS|PR5801 Test|TNE"
local modelInput
local exit = 0
local function init()
modelInput = model.getInput(0,0)
end
local function run(event, touchState)
lcd.clear()
lcd.drawText( 0, 0, "PR5801 modelInput.mode")
lcd.drawText( 0, 20, "Mode : " .. tostring(modelInput.side) )
if event == EVT_VIRTUAL_EXIT then
exit = 1
end
return exit
end
return { run=run, init=init } |
Perfectly happy with either. I did think about that but instead documented that it was side. Happy to make the change if you want |
Yeah, I think it would be a good idea to call it `side` or even something
like `stickSide` so it's self-explanatory what it relates to. Dealers
choice lol
…On Tue, Jan 21, 2025 at 4:55 PM Matt Forrester ***@***.***> wrote:
Perfectly happy with either. I did think about that but instead documented
that it was side.
Happy to make the change if you want
—
Reply to this email directly, view it on GitHub
<#5801 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJ66KNA7S24G5XY57WNEP32LXVODAVCNFSM6AAAAABVNWT7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBTHAYDAOJYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
47addc8
to
a8f1b47
Compare
Model > Input -> Side is missing from the Lua API.
This PR puts it back in.
NOTE: I think this is correct, I've been able to compile firmware, but currently I am unable to get the simulator to compile on a Ubuntu22 VM. It dies with the following error and my C++ skills are not going to be sufficient to move forward.