Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bw): prevent phantom 'Script error' message after trying to load a Lua 5.2 luac file #5819

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jan 22, 2025

Prevent phantom 'Script error' message after trying to load a Lua 5.2 version file.

Radio shows a 'Script error' message after trying to run a tool where a Lua 5.2 version .luac file already exists.

@philmoz philmoz added bug 🪲 Something isn't working UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios lua labels Jan 22, 2025
@philmoz philmoz added this to the 2.11 milestone Jan 22, 2025
@pfeerick pfeerick changed the title fix(b&w): radio shows a 'Script error' message after trying to run a tool where a Lua 5.2 version .luac file already exists. fix(bw): prevent phantom 'Script error' message essage after trying to load a Lua 5.2 luac file Jan 22, 2025
@pfeerick pfeerick changed the title fix(bw): prevent phantom 'Script error' message essage after trying to load a Lua 5.2 luac file fix(bw): prevent phantom 'Script error' message after trying to load a Lua 5.2 luac file Jan 22, 2025
radio/src/lua/lua_api.h Outdated Show resolved Hide resolved
@pfeerick
Copy link
Member

Worked perfectly on T12Max... ExpressLRS and Wizard Loader which had been compiled with Lua 5.2 just worked without any error messages.

@pfeerick pfeerick merged commit d69de50 into main Jan 22, 2025
29 checks passed
@pfeerick pfeerick deleted the philmoz/fix-phantom-error branch January 22, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working lua UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants