-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop interactive mode #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice.
About using &&
for running several commands, won't this conflict with the native unix &&
? For instance, running gad sprint && review && vagrant up
won't work anymore, right?
@chalasr It's slightly better than that: the
I you think this do more wrong than right, I'm prepared to remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either about the several commands features. IMHO we should simply leverage on basic shell features for such things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I would remove it, that will prevent from wtf moments
Just played a bit with this, the following runs fine:
Firstly, I think we should add some validation rules to the options and validate them before performing any http request or writing anything to the output, in order to provide meaningful error messages when an option is missing or has an invalid value. Secondly, is it expected that global options (e.g. |
@chalasr I moved your concerns in a specific issue. |
👌 Merging then |
gad changelog --all
to see all issues for the sprint)