Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crates #71

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Update crates #71

merged 2 commits into from
Jul 4, 2020

Conversation

nilgoyette
Copy link
Collaborator

I'm not sure if this is what you wanted but I updated all the crates

  • using a X.Y versioning, not X.Y.Z, because I don't see the point of being explicit about the last number. Please educate me if I shouldn't have done that :)
  • including safe-transmute which you just updated. Yay, no more RC crates.
  • nalgebra required more changes, they dropped algo in favor of simba.
  • I added some #[rustfmt::skip] because the matrices were auto-formatted. I hate that. I needed that add them on top of the functions, otherwise attributes on expressions are experimental. I hate that even more.

Did you have other goals before a release? We want to use nalgebra 0.21 but we depend on nifti-rs. I'm aware of #62 , but it could be a 0.10 release.

Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • using a X.Y versioning, not X.Y.Z, because I don't see the point of being explicit about the last number. Please educate me if I shouldn't have done that :)

I generally do what the extra tool cargo add already does, which is enough to cover any potential edge case. For public dependencies, it may be desirable to widen the range of supported versions, so long as semver compliance is maintained. And when a specific patch is truly needed, that can be overridden later. So yes, this is fine.

  • including safe-transmute which you just updated. Yay, no more RC crates.

If you are interested in safe transmutation in Rust, you might also like to know about more recent progress towards safe transmute constructs in the standard library: Project safe transmute. The current plan is to adopt the type-level constructs found in typic.

  • nalgebra required more changes, they dropped algo in favor of simba.

photo-1564648931

  • I added some #[rustfmt::skip] because the matrices were auto-formatted. I hate that. I needed that add them on top of the functions, otherwise attributes on expressions are experimental. I hate that even more.

We can keep it like this, since there doesn't appear to be a nicer way to instruct rustfmt to do what we want.

I agree that this is an acceptable time to release 0.10.0. Thanks!

@Enet4 Enet4 merged commit 963972e into Enet4:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants